zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-02 10:55:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer using nameof(x) over literal "x" (#1781)

Browse Source 
* updated XML docs and added some missing bits.

* prefer nameof(x) over literal "x"
This commit is contained in:
Itai Bar-Haim
2018-03-07 12:43:10 +02:00
committed by Ryan Gribble
parent c223f5ae9a
commit 4e804f61a6
218 changed files with 2707 additions and 2706 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Http/Connection.cs
+44 -44
View File
@@ -138,11 +138,11 @@ namespace Octokit
IHttpClient httpClient,
IJsonSerializer serializer)
{
Ensure.ArgumentNotNull(productInformation, "productInformation");
Ensure.ArgumentNotNull(baseAddress, "baseAddress");
Ensure.ArgumentNotNull(credentialStore, "credentialStore");
Ensure.ArgumentNotNull(httpClient, "httpClient");
Ensure.ArgumentNotNull(serializer, "serializer");
Ensure.ArgumentNotNull(productInformation, nameof(productInformation));
Ensure.ArgumentNotNull(baseAddress, nameof(baseAddress));
Ensure.ArgumentNotNull(credentialStore, nameof(credentialStore));
Ensure.ArgumentNotNull(httpClient, nameof(httpClient));
Ensure.ArgumentNotNull(serializer, nameof(serializer));
if (!baseAddress.IsAbsoluteUri)
{
@@ -174,21 +174,21 @@ namespace Octokit
public Task<IApiResponse<T>> Get<T>(Uri uri, IDictionary<string, string> parameters, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
return SendData<T>(uri.ApplyParameters(parameters), HttpMethod.Get, null, accepts, null, CancellationToken.None);
}
public Task<IApiResponse<T>> Get<T>(Uri uri, IDictionary<string, string> parameters, string accepts, CancellationToken cancellationToken)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
return SendData<T>(uri.ApplyParameters(parameters), HttpMethod.Get, null, accepts, null, cancellationToken);
}
public Task<IApiResponse<T>> Get<T>(Uri uri, TimeSpan timeout)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
return SendData<T>(uri, HttpMethod.Get, null, null, null, timeout, CancellationToken.None);
}
@@ -201,7 +201,7 @@ namespace Octokit
/// <returns><seealso cref="IResponse"/> representing the received HTTP response</returns>
public Task<IApiResponse<string>> GetHtml(Uri uri, IDictionary<string, string> parameters)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
return GetHtml(new Request
{
@@ -213,17 +213,17 @@ namespace Octokit
public Task<IApiResponse<T>> Patch<T>(Uri uri, object body)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
return SendData<T>(uri, HttpVerb.Patch, body, null, null, CancellationToken.None);
}
public Task<IApiResponse<T>> Patch<T>(Uri uri, object body, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNull(accepts, "accepts");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
Ensure.ArgumentNotNull(accepts, nameof(accepts));
return SendData<T>(uri, HttpVerb.Patch, body, accepts, null, CancellationToken.None);
}
@@ -235,7 +235,7 @@ namespace Octokit
/// <returns><seealso cref="IResponse"/> representing the received HTTP response</returns>
public async Task<HttpStatusCode> Post(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var response = await SendData<object>(uri, HttpMethod.Post, null, null, null, CancellationToken.None).ConfigureAwait(false);
return response.HttpResponse.StatusCode;
@@ -243,7 +243,7 @@ namespace Octokit
public async Task<HttpStatusCode> Post(Uri uri, object body, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var response = await SendData<object>(uri, HttpMethod.Post, body, accepts, null, CancellationToken.None).ConfigureAwait(false);
return response.HttpResponse.StatusCode;
@@ -251,15 +251,15 @@ namespace Octokit
public Task<IApiResponse<T>> Post<T>(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
return SendData<T>(uri, HttpMethod.Post, null, null, null, CancellationToken.None);
}
public Task<IApiResponse<T>> Post<T>(Uri uri, object body, string accepts, string contentType)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
return SendData<T>(uri, HttpMethod.Post, body, accepts, contentType, CancellationToken.None);
}
@@ -277,25 +277,25 @@ namespace Octokit
/// <returns><seealso cref="IResponse"/> representing the received HTTP response</returns>
public Task<IApiResponse<T>> Post<T>(Uri uri, object body, string accepts, string contentType, string twoFactorAuthenticationCode)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNullOrEmptyString(twoFactorAuthenticationCode, "twoFactorAuthenticationCode");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
Ensure.ArgumentNotNullOrEmptyString(twoFactorAuthenticationCode, nameof(twoFactorAuthenticationCode));
return SendData<T>(uri, HttpMethod.Post, body, accepts, contentType, CancellationToken.None, twoFactorAuthenticationCode);
}
public Task<IApiResponse<T>> Post<T>(Uri uri, object body, string accepts, string contentType, TimeSpan timeout)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
return SendData<T>(uri, HttpMethod.Post, body, accepts, contentType, timeout, CancellationToken.None);
}
public Task<IApiResponse<T>> Post<T>(Uri uri, object body, string accepts, string contentType, Uri baseAddress)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(body, "body");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(body, nameof(body));
return SendData<T>(uri, HttpMethod.Post, body, accepts, contentType, CancellationToken.None, baseAddress: baseAddress);
}
@@ -338,8 +338,8 @@ namespace Octokit
string twoFactorAuthenticationCode = null,
Uri baseAddress = null)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.GreaterThanZero(timeout, "timeout");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.GreaterThanZero(timeout, nameof(timeout));
var request = new Request
{
@@ -362,7 +362,7 @@ namespace Octokit
string twoFactorAuthenticationCode = null,
Uri baseAddress = null)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var request = new Request
{
@@ -403,7 +403,7 @@ namespace Octokit
/// <returns><seealso cref="IResponse"/> representing the received HTTP response</returns>
public async Task<HttpStatusCode> Patch(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var request = new Request
{
@@ -423,8 +423,8 @@ namespace Octokit
/// <returns><seealso cref="IResponse"/> representing the received HTTP response</returns>
public async Task<HttpStatusCode> Patch(Uri uri, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(accepts, "accepts");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(accepts, nameof(accepts));
var response = await SendData<object>(uri, new HttpMethod("PATCH"), null, accepts, null, CancellationToken.None).ConfigureAwait(false);
return response.HttpResponse.StatusCode;
@@ -437,7 +437,7 @@ namespace Octokit
/// <returns>The returned <seealso cref="HttpStatusCode"/></returns>
public async Task<HttpStatusCode> Put(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var request = new Request
{
@@ -471,7 +471,7 @@ namespace Octokit
/// <returns>The returned <seealso cref="HttpStatusCode"/></returns>
public async Task<HttpStatusCode> Delete(Uri uri)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var request = new Request
{
@@ -491,7 +491,7 @@ namespace Octokit
/// <returns>The returned <seealso cref="HttpStatusCode"/></returns>
public async Task<HttpStatusCode> Delete(Uri uri, string twoFactorAuthenticationCode)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(uri, nameof(uri));
var response = await SendData<object>(uri, HttpMethod.Delete, null, null, null, CancellationToken.None, twoFactorAuthenticationCode).ConfigureAwait(false);
return response.HttpResponse.StatusCode;
@@ -505,8 +505,8 @@ namespace Octokit
/// <returns>The returned <seealso cref="HttpStatusCode"/></returns>
public async Task<HttpStatusCode> Delete(Uri uri, object data)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(data, "data");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(data, nameof(data));
var request = new Request
{
@@ -528,8 +528,8 @@ namespace Octokit
/// <returns>The returned <seealso cref="HttpStatusCode"/></returns>
public async Task<HttpStatusCode> Delete(Uri uri, object data, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(accepts, "accepts");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(accepts, nameof(accepts));
var response = await SendData<object>(uri, HttpMethod.Delete, data, accepts, null, CancellationToken.None).ConfigureAwait(false);
return response.HttpResponse.StatusCode;
@@ -543,8 +543,8 @@ namespace Octokit
/// <param name="data">The object to serialize as the body of the request</param>
public Task<IApiResponse<T>> Delete<T>(Uri uri, object data)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(data, "data");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(data, nameof(data));
return SendData<T>(uri, HttpMethod.Delete, data, null, null, CancellationToken.None);
}
@@ -559,8 +559,8 @@ namespace Octokit
/// <param name="accepts">Specifies accept response media type</param>
public Task<IApiResponse<T>> Delete<T>(Uri uri, object data, string accepts)
{
Ensure.ArgumentNotNull(uri, "uri");
Ensure.ArgumentNotNull(accepts, "accepts");
Ensure.ArgumentNotNull(uri, nameof(uri));
Ensure.ArgumentNotNull(accepts, nameof(accepts));
return SendData<T>(uri, HttpMethod.Delete, data, accepts, null, CancellationToken.None);
}
@@ -600,7 +600,7 @@ namespace Octokit
// Note this is for convenience. We probably shouldn't allow this to be mutable.
set
{
Ensure.ArgumentNotNull(value, "value");
Ensure.ArgumentNotNull(value, nameof(value));
_authenticator.CredentialStore = new InMemoryCredentialStore(value);
}
}