From 55e009a87af0608be838fc5519b29cfb7da297bd Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Tue, 24 May 2016 17:06:49 +0700 Subject: [PATCH 1/2] fixed incorrect names of tests --- .../Clients/RepositoryDeployKeysClientTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs index e740359e..acbd4530 100644 --- a/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs +++ b/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs @@ -58,7 +58,7 @@ public class RepositoryDeployKeysClientTests : IDisposable } [IntegrationTest(Skip = "See https://github.com/octokit/octokit.net/issues/1003 for investigating this failing test")] - public async Task ReturnsCorrectCountOfHooksWithoutStart() + public async Task ReturnsCorrectCountOfDeployKeysWithoutStart() { var deployKeys = await _fixture.GetAll(_context.RepositoryOwner, _context.RepositoryName); Assert.Equal(0, deployKeys.Count); @@ -92,7 +92,7 @@ public class RepositoryDeployKeysClientTests : IDisposable } [IntegrationTest(Skip = "See https://github.com/octokit/octokit.net/issues/1003 for investigating this failing test")] - public async Task ReturnsCorrectCountOfHooksWithStart() + public async Task ReturnsCorrectCountOfDeployKeysWithStart() { var deployKeys = await _fixture.GetAll(_context.RepositoryOwner, _context.RepositoryName); Assert.Equal(0, deployKeys.Count); From da63e4757fa44260dc78690542b71a1481d17611 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Tue, 24 May 2016 18:36:41 +0700 Subject: [PATCH 2/2] renamed variables inside test methods --- .../Clients/RepositoryDeployKeysClientTests.cs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs index acbd4530..6e10606f 100644 --- a/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs +++ b/Octokit.Tests.Integration/Clients/RepositoryDeployKeysClientTests.cs @@ -64,8 +64,8 @@ public class RepositoryDeployKeysClientTests : IDisposable Assert.Equal(0, deployKeys.Count); var list = new List(); - var hooksCount = 5; - for (int i = 0; i < hooksCount; i++) + var deployKeysCount = 5; + for (int i = 0; i < deployKeysCount; i++) { var item = new NewDeployKey { @@ -82,13 +82,13 @@ public class RepositoryDeployKeysClientTests : IDisposable var options = new ApiOptions { - PageSize = hooksCount, + PageSize = deployKeysCount, PageCount = 1 }; deployKeys = await _fixture.GetAll(_context.RepositoryOwner, _context.RepositoryName, options); - Assert.Equal(hooksCount, deployKeys.Count); + Assert.Equal(deployKeysCount, deployKeys.Count); } [IntegrationTest(Skip = "See https://github.com/octokit/octokit.net/issues/1003 for investigating this failing test")] @@ -98,8 +98,8 @@ public class RepositoryDeployKeysClientTests : IDisposable Assert.Equal(0, deployKeys.Count); var list = new List(); - var hooksCount = 5; - for (int i = 0; i < hooksCount; i++) + var deployKeysCount = 5; + for (int i = 0; i < deployKeysCount; i++) { var item = new NewDeployKey { @@ -130,8 +130,8 @@ public class RepositoryDeployKeysClientTests : IDisposable public async Task ReturnsDistinctResultsBasedOnStartPage() { var list = new List(); - var hooksCount = 5; - for (int i = 0; i < hooksCount; i++) + var deployKeysCount = 5; + for (int i = 0; i < deployKeysCount; i++) { var item = new NewDeployKey {