diff --git a/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs b/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs index dfa5141f..0db4442c 100644 --- a/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs @@ -13,7 +13,7 @@ namespace Octokit.Reactive /// The comment id /// The reaction to create /// - IObservable CreateReaction(string owner, string name, int number, NewReaction reaction); + IObservable Create(string owner, string name, int number, NewReaction reaction); /// /// List reactions for a specified Commit Comment diff --git a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs index 3f7e7955..45488f5f 100644 --- a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs @@ -13,7 +13,7 @@ namespace Octokit.Reactive /// The issue id /// The reaction to create /// - IObservable CreateReaction(string owner, string name, int number, NewReaction reaction); + IObservable Create(string owner, string name, int number, NewReaction reaction); /// /// List reactions for a specified Commit Comment diff --git a/Octokit.Reactive/Clients/ObservableCommitCommentReactionsClient.cs b/Octokit.Reactive/Clients/ObservableCommitCommentReactionsClient.cs index 99371ac6..cb95edac 100644 --- a/Octokit.Reactive/Clients/ObservableCommitCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/ObservableCommitCommentReactionsClient.cs @@ -26,13 +26,13 @@ namespace Octokit.Reactive /// The comment id /// The reaction to create /// - public IObservable CreateReaction(string owner, string name, int number, NewReaction reaction) + public IObservable Create(string owner, string name, int number, NewReaction reaction) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNull(reaction, "reaction"); - return _client.CreateReaction(owner, name, number, reaction).ToObservable(); + return _client.Create(owner, name, number, reaction).ToObservable(); } /// diff --git a/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs b/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs index b2b1dc30..ffa33fcf 100644 --- a/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs @@ -26,13 +26,13 @@ namespace Octokit.Reactive /// The issue id /// The reaction to create /// - public IObservable CreateReaction(string owner, string name, int number, NewReaction reaction) + public IObservable Create(string owner, string name, int number, NewReaction reaction) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNull(reaction, "reaction"); - return _client.CreateReaction(owner, name, number, reaction).ToObservable(); + return _client.Create(owner, name, number, reaction).ToObservable(); } /// diff --git a/Octokit.Tests/Clients/CommitCommentsReactionsClientTests.cs b/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs similarity index 80% rename from Octokit.Tests/Clients/CommitCommentsReactionsClientTests.cs rename to Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs index 97632bb1..0263379f 100644 --- a/Octokit.Tests/Clients/CommitCommentsReactionsClientTests.cs +++ b/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs @@ -5,7 +5,7 @@ using Xunit; namespace Octokit.Tests.Clients { - public class CommitCommentsReactionsClientTests + public class CommitCommentReactionsClientTests { public class TheCtor { @@ -35,11 +35,11 @@ namespace Octokit.Tests.Clients var connection = Substitute.For(); var client = new ReactionsClient(connection); - await Assert.ThrowsAsync(() => client.CommitComment.CreateReaction(null, "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.CreateReaction("", "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.CreateReaction("owner", null, 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.CreateReaction("owner", "", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.CreateReaction("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.CommitComment.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.CommitComment.Create("", "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", "name", 1, null)); } } diff --git a/Octokit.Tests/Clients/IssuesReactionsClientTests.cs b/Octokit.Tests/Clients/IssueReactionsClientTests.cs similarity index 82% rename from Octokit.Tests/Clients/IssuesReactionsClientTests.cs rename to Octokit.Tests/Clients/IssueReactionsClientTests.cs index f8e9c156..22069d46 100644 --- a/Octokit.Tests/Clients/IssuesReactionsClientTests.cs +++ b/Octokit.Tests/Clients/IssueReactionsClientTests.cs @@ -5,7 +5,7 @@ using Xunit; namespace Octokit.Tests.Clients { - public class IssuesReactionsClientTests + public class IssueReactionsClientTests { public class TheCtor { @@ -35,11 +35,11 @@ namespace Octokit.Tests.Clients var connection = Substitute.For(); var client = new ReactionsClient(connection); - await Assert.ThrowsAsync(() => client.Issue.CreateReaction(null, "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.Issue.CreateReaction("", "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.Issue.CreateReaction("owner", null, 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.Issue.CreateReaction("owner", "", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.Issue.CreateReaction("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.Issue.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Issue.Create("", "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Issue.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Issue.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Issue.Create("owner", "name", 1, null)); } } diff --git a/Octokit.Tests/Octokit.Tests.csproj b/Octokit.Tests/Octokit.Tests.csproj index 87c1ed5b..30d5ab71 100644 --- a/Octokit.Tests/Octokit.Tests.csproj +++ b/Octokit.Tests/Octokit.Tests.csproj @@ -85,8 +85,8 @@ - - + + diff --git a/Octokit/Clients/CommitCommentReactionsClient.cs b/Octokit/Clients/CommitCommentReactionsClient.cs index 7b19b4f0..da4ddc07 100644 --- a/Octokit/Clients/CommitCommentReactionsClient.cs +++ b/Octokit/Clients/CommitCommentReactionsClient.cs @@ -19,7 +19,7 @@ namespace Octokit /// The comment id /// The reaction to create /// - public Task CreateReaction(string owner, string name, int number, NewReaction reaction) + public Task Create(string owner, string name, int number, NewReaction reaction) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); diff --git a/Octokit/Clients/ICommitCommentReactionsClient.cs b/Octokit/Clients/ICommitCommentReactionsClient.cs index ffe8e5e6..d4664ecc 100644 --- a/Octokit/Clients/ICommitCommentReactionsClient.cs +++ b/Octokit/Clients/ICommitCommentReactionsClient.cs @@ -14,7 +14,7 @@ namespace Octokit /// The comment id /// The reaction to create /// - Task CreateReaction(string owner, string name, int number, NewReaction reaction); + Task Create(string owner, string name, int number, NewReaction reaction); /// /// Get all reactions for a specified Commit Comment diff --git a/Octokit/Clients/IIssueReactionsClient.cs b/Octokit/Clients/IIssueReactionsClient.cs index 9868a285..208503bf 100644 --- a/Octokit/Clients/IIssueReactionsClient.cs +++ b/Octokit/Clients/IIssueReactionsClient.cs @@ -24,6 +24,6 @@ namespace Octokit /// The issue id /// The reaction to create /// - Task CreateReaction(string owner, string name, int number, NewReaction reaction); + Task Create(string owner, string name, int number, NewReaction reaction); } } diff --git a/Octokit/Clients/IssueReactionsClient.cs b/Octokit/Clients/IssueReactionsClient.cs index 12f5cfb0..f4e07714 100644 --- a/Octokit/Clients/IssueReactionsClient.cs +++ b/Octokit/Clients/IssueReactionsClient.cs @@ -20,7 +20,7 @@ namespace Octokit /// The issue id /// The reaction to create /// - public Task CreateReaction(string owner, string name, int number, NewReaction reaction) + public Task Create(string owner, string name, int number, NewReaction reaction) { Ensure.ArgumentNotNull(owner, "owner"); Ensure.ArgumentNotNull(name, "name");