zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-05 23:06:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release v0.25 - She'll be Comin' Round the Mountain (#1656)

Browse Source 
* Run `build -Target FormatCode` to fixup whitespace etc

* Fix delete release asset integration test

* Fix repository fork test

* Fix pagination test for PR Review Request

* First cut of release notes

* update release notes

* Update release notes

* include links to contributors

* Add breaking changes/advisories section

* Tidy up formatting

* Tidy up wording
This commit is contained in:
Ryan Gribble
2017-08-23 21:27:15 +10:00
committed by GitHub
parent 951ca4f742
commit 5e89232521
39 changed files with 164 additions and 99 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Octokit.Reactive/Clients/IObservablePullRequestsClient.cs
View File

@@ -21,7 +21,7 @@ namespace Octokit.Reactive
/// Client for managing reviews.
/// </summary>
IObservablePullRequestReviewsClient Review { get; }
/// <summary>
/// Client for managing review comments.
/// </summary>

18
Octokit.Reactive/Clients/ObservablePullRequestReviewsClient.cs
View File

@@ -35,7 +35,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> Create(string owner, string name, int number, PullRequestReviewCreate review)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(review, nameof(review));
return _client.Create(owner, name, number, review).ToObservable();
}
@@ -65,7 +65,7 @@ namespace Octokit.Reactive
public IObservable<Unit> Delete(string owner, string name, int number, long reviewId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number, reviewId).ToObservable();
}
@@ -94,7 +94,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> Dismiss(string owner, string name, int number, long reviewId, PullRequestReviewDismiss dismissMessage)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(dismissMessage, nameof(dismissMessage));
return _client.Dismiss(owner, name, number, reviewId, dismissMessage).ToObservable();
@@ -125,7 +125,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> GetAll(string owner, string name, int number)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAll(owner, name, number, ApiOptions.None);
}
@@ -152,7 +152,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> GetAll(string owner, string name, int number, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReview>(ApiUrls.PullRequestReviews(owner, name, number), null, null, options);
@@ -183,7 +183,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> Get(string owner, string name, int number, long reviewId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number, reviewId).ToObservable();
}
@@ -212,7 +212,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReview> Submit(string owner, string name, int number, long reviewId, PullRequestReviewSubmit submitMessage)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(submitMessage, nameof(submitMessage));
return _client.Submit(owner, name, number, reviewId, submitMessage).ToObservable();
@@ -269,7 +269,7 @@ namespace Octokit.Reactive
public IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int number, long reviewId, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name,nameof(name));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(owner, name, number, reviewId), options);
@@ -286,7 +286,7 @@ namespace Octokit.Reactive
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, number, reviewId),options);
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, number, reviewId), options);
}
}
}

2
Octokit.Tests.Integration/Clients/OrganizationOutsideCollaboratorsClientTests.cs
View File

@@ -258,7 +258,7 @@ namespace Octokit.Tests.Integration.Clients
[OrganizationTest]
public async Task CannotRemoveMemberOfOrganizationAsOutsideCollaborator()
{
var ex = await Assert.ThrowsAsync<UserIsOrganizationMemberException>(()
var ex = await Assert.ThrowsAsync<UserIsOrganizationMemberException>(()
=> _gitHub.Organization.OutsideCollaborator.Delete(Helper.Organization, Helper.UserName));
Assert.True(string.Equals(

4
Octokit.Tests.Integration/Clients/ProjectsClientTests.cs
View File

@@ -53,7 +53,7 @@ public class ProjectsClientTests
{
var project1 = await CreateRepositoryProjectHelper(_github, _context.RepositoryId);
var project2 = await CreateRepositoryProjectHelper(_github, _context.RepositoryId);
// Make 2nd project closed
var result = await _github.Repository.Project.Update(project2.Id, new ProjectUpdate { State = ItemState.Closed });
@@ -236,7 +236,7 @@ public class ProjectsClientTests
public async Task GetsAllFilteredProjectsForRepository()
{
var project = await CreateOrganizationProjectHelper(_github, Helper.Organization);
// Make project closed
var result = await _github.Repository.Project.Update(project.Id, new ProjectUpdate { State = ItemState.Closed });

16
Octokit.Tests.Integration/Clients/PullRequestReviewRequestsClientTests.cs
View File

@@ -87,7 +87,7 @@ public class PullRequestReviewRequestsClientTests
public async Task ReturnsCorrectCountOfReviewRequestsWithStart()
{
var number = await CreateTheWorld(_github, _context);
var options = new ApiOptions
{
PageSize = 1,
@@ -107,7 +107,7 @@ public class PullRequestReviewRequestsClientTests
var options = new ApiOptions
{
PageSize = 1,
PageCount = 2,
PageCount = 1,
StartPage = 2
};
var reviewRequests = await _client.GetAll(_context.RepositoryId, number, options);
@@ -119,7 +119,7 @@ public class PullRequestReviewRequestsClientTests
public async Task ReturnsDistinctResultsBasedOnStartPage()
{
var number = await CreateTheWorld(_github, _context);
var startOptions = new ApiOptions
{
PageSize = 1,
@@ -144,7 +144,7 @@ public class PullRequestReviewRequestsClientTests
public async Task ReturnsDistinctResultsBasedOnStartPageWithRepositoryId()
{
var number = await CreateTheWorld(_github, _context);
var startOptions = new ApiOptions
{
PageSize = 1,
@@ -172,7 +172,7 @@ public class PullRequestReviewRequestsClientTests
public async Task DeletesRequests()
{
var number = await CreateTheWorld(_github, _context);
var reviewRequestsBeforeDelete = await _client.GetAll(_context.RepositoryOwner, _context.RepositoryName, number);
var reviewRequestToCreate = new PullRequestReviewRequest(_collaboratorLogins);
await _client.Delete(_context.RepositoryOwner, _context.RepositoryName, number, reviewRequestToCreate);
@@ -186,11 +186,11 @@ public class PullRequestReviewRequestsClientTests
public async Task DeletesRequestsWithRepositoryId()
{
var number = await CreateTheWorld(_github, _context);
var reviewRequestsBeforeDelete = await _client.GetAll(_context.RepositoryId, number);
var reviewRequestsBeforeDelete = await _client.GetAll(_context.RepositoryId, number);
var reviewRequestToCreate = new PullRequestReviewRequest(_collaboratorLogins);
await _client.Delete(_context.RepositoryId, number, reviewRequestToCreate);
var reviewRequestsAfterDelete = await _client.GetAll(_context.RepositoryId, number);
var reviewRequestsAfterDelete = await _client.GetAll(_context.RepositoryId, number);
Assert.NotEmpty(reviewRequestsBeforeDelete);
Assert.Empty(reviewRequestsAfterDelete);

6
Octokit.Tests.Integration/Clients/ReleasesClientTests.cs
View File

@@ -788,7 +788,7 @@ public class ReleasesClientTests
await _releaseClient.DeleteAsset(_context.RepositoryOwner, _context.RepositoryName, result.Id);
await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.DeleteAsset(_context.RepositoryOwner, _context.RepositoryName, result.Id));
await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetAsset(_context.RepositoryOwner, _context.RepositoryName, result.Id));
}
[IntegrationTest]
@@ -806,7 +806,9 @@ public class ReleasesClientTests
Assert.NotNull(asset);
await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.DeleteAsset(_context.Repository.Id, result.Id));
await _releaseClient.DeleteAsset(_context.Repository.Id, result.Id);
await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetAsset(_context.Repository.Id, result.Id));
}
}

8
Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs
View File

@@ -700,9 +700,9 @@ public class RepositoriesClientTests
{
var github = Helper.GetAuthenticatedClient();
var repository = await github.Repository.Get("haacked", "libgit2sharp");
var repository = await github.Repository.Get("octokitnet-test1", "octokit.net");
Assert.Equal("https://github.com/Haacked/libgit2sharp.git", repository.CloneUrl);
Assert.Equal("https://github.com/octokitnet-test1/octokit.net.git", repository.CloneUrl);
Assert.True(repository.Fork);
}
@@ -711,9 +711,9 @@ public class RepositoriesClientTests
{
var github = Helper.GetAuthenticatedClient();
var repository = await github.Repository.Get(4550038);
var repository = await github.Repository.Get(100559458);
Assert.Equal("https://github.com/Haacked/libgit2sharp.git", repository.CloneUrl);
Assert.Equal("https://github.com/octokitnet-test1/octokit.net.git", repository.CloneUrl);
Assert.True(repository.Fork);
}

2
Octokit.Tests.Integration/Clients/RepositoryCollaboratorClientTests.cs
View File

@@ -381,7 +381,7 @@ public class RepositoryCollaboratorClientTests
var fixture = github.Repository.Collaborator;
var permission = await fixture.ReviewPermission(context.RepositoryOwner, context.RepositoryName, "octokitnet-test1");
Assert.Equal(PermissionLevel.None, permission.Permission);
}
}

2
Octokit.Tests.Integration/Reactive/ObservableNotificationsClientTests.cs
View File

@@ -12,7 +12,7 @@ public class ObservableNotificationsClientTests
public async Task MarksNotificationsRead()
{
var client = new ObservableGitHubClient(Helper.GetAuthenticatedClient());
await client.Activity.Notifications.MarkAsRead();
}
}

4
Octokit.Tests.Integration/Reactive/ObservableProjectsClientTests.cs
View File

@@ -55,7 +55,7 @@ public class ObservableProjectsClientTests
{
var project1 = await CreateRepositoryProjectHelper(_github, _context.RepositoryId);
var project2 = await CreateRepositoryProjectHelper(_github, _context.RepositoryId);
// Make 2nd project closed
var result = await _github.Repository.Project.Update(project2.Id, new ProjectUpdate { State = ItemState.Closed });
@@ -238,7 +238,7 @@ public class ObservableProjectsClientTests
public async Task GetsAllFilteredProjectsForRepository()
{
var project = await CreateOrganizationProjectHelper(_github, Helper.Organization);
// Make project closed
var result = await _github.Repository.Project.Update(project.Id, new ProjectUpdate { State = ItemState.Closed });

1
Octokit.Tests.Integration/Reactive/ObservableRepositoryCollaboratorClientTests.cs
View File

@@ -141,7 +141,6 @@ public class ObservableRepositoryCollaboratorClientTests
}
public class TheReviewPermissionMethod
{
[IntegrationTest]
public async Task ReturnsReadPermissionForNonCollaborator()
{

6
Octokit.Tests/Clients/OrganizationOutsideCollaboratorsClientTests.cs
View File

@@ -138,8 +138,8 @@ namespace Octokit.Tests.Clients
client.Delete("org", "user");
connection.Connection.Received().Delete(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators/user"),
Arg.Any<object>(),
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators/user"),
Arg.Any<object>(),
"application/vnd.github.korra-preview+json");
}
@@ -150,7 +150,7 @@ namespace Octokit.Tests.Clients
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Delete(null, "user"));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Delete("org", null));
await Assert.ThrowsAsync<ArgumentException>(() => client.Delete("", "user"));
await Assert.ThrowsAsync<ArgumentException>(() => client.Delete("org", ""));
}

4
Octokit.Tests/Clients/ProjectCardsClientTests.cs
View File

@@ -75,7 +75,7 @@ namespace Octokit.Tests.Clients
newCard,
"application/vnd.github.inertia-preview+json");
}
[Fact]
public async Task EnsuresNonNullArguments()
{
@@ -151,7 +151,7 @@ namespace Octokit.Tests.Clients
public async Task EnsuresNonNullArguments()
{
var client = new ProjectCardsClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Move(1, null));
}
}

2
Octokit.Tests/Clients/ProjectsClientTests.cs
View File

@@ -249,7 +249,7 @@ namespace Octokit.Tests.Clients
public async Task EnsuresNonNullArguments()
{
var client = new ProjectsClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Update(1, null));
}
}

2
Octokit.Tests/Clients/PullRequestReviewRequestsClientTests.cs
View File

@@ -123,7 +123,7 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewRequestsClient(connection);
IReadOnlyList<string> fakeReviewers = new List<string> { "zxc", "asd"};
IReadOnlyList<string> fakeReviewers = new List<string> { "zxc", "asd" };
var pullRequestReviewRequest = new PullRequestReviewRequest(fakeReviewers);
client.Create("fakeOwner", "fakeRepoName", 13, pullRequestReviewRequest);

13
Octokit.Tests/Clients/PullRequestReviewsClientTests.cs
View File

@@ -172,7 +172,7 @@ public class PullRequestReviewsClientTests
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
var comment = new DraftPullRequestReviewComment("Comment content", "file.css", 7);
var review = new PullRequestReviewCreate()
@@ -240,7 +240,7 @@ public class PullRequestReviewsClientTests
await Assert.ThrowsAsync<ArgumentException>(() => client.Create("fakeOwner", "", 1, review));
}
}
public class TheDeleteMethod
{
[Fact]
@@ -257,7 +257,6 @@ public class PullRequestReviewsClientTests
[Fact]
public async Task PostsToCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
@@ -285,7 +284,6 @@ public class PullRequestReviewsClientTests
[Fact]
public async Task PostsToCorrectUrl()
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
@@ -301,7 +299,6 @@ public class PullRequestReviewsClientTests
[Fact]
public async Task PostsToCorrectUrlWithRepositoryId()
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
@@ -341,7 +338,7 @@ public class PullRequestReviewsClientTests
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
await client.GetAllComments("owner", "name", 13, 13);
connection.Received().GetAll<PullRequestReviewComment>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/pulls/13/reviews/13/comments"), null, Args.ApiOptions);
@@ -399,7 +396,7 @@ public class PullRequestReviewsClientTests
{
var connection = Substitute.For<IApiConnection>();
var client = new PullRequestReviewsClient(connection);
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllComments(null, "name", 1, 1));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllComments("owner", null, 1, 1));
@@ -418,7 +415,7 @@ public class PullRequestReviewsClientTests
var submitMessage = new PullRequestReviewSubmit()
{
Body = "string",
Body = "string",
Event = PullRequestReviewEvent.Approve
};
await client.Submit("owner", "name", 13, 13, submitMessage);

5
Octokit.Tests/Clients/RepoCollaboratorsClientTests.cs
View File

@@ -201,7 +201,7 @@ namespace Octokit.Tests.Clients
client.ReviewPermission("owner", "test", "user1");
connection.Received().Get<CollaboratorPermission>(
Arg.Is<Uri>(u => u.ToString() == "repos/owner/test/collaborators/user1/permission"),
Arg.Any<Dictionary<string, string>>(),
Arg.Any<Dictionary<string, string>>(),
"application/vnd.github.korra-preview+json");
}
@@ -214,7 +214,7 @@ namespace Octokit.Tests.Clients
client.ReviewPermission(1L, "user1");
connection.Received().Get<CollaboratorPermission>(
Arg.Is<Uri>(u => u.ToString() == "repositories/1/collaborators/user1/permission"),
Arg.Any<Dictionary<string, string>>(),
Arg.Any<Dictionary<string, string>>(),
"application/vnd.github.korra-preview+json");
}
@@ -233,7 +233,6 @@ namespace Octokit.Tests.Clients
await Assert.ThrowsAsync<ArgumentNullException>(() => client.ReviewPermission(1L, null));
await Assert.ThrowsAsync<ArgumentException>(() => client.ReviewPermission(1L, ""));
}
}
public class TheAddMethod

4
Octokit.Tests/Helpers/UriExtensionsTests.cs
View File

@@ -92,7 +92,7 @@ namespace Octokit.Tests.Helpers
var uri = new Uri("https://api.github.com/repositories/1/milestones?state=closed&sort=due_date&direction=asc&page=2");
var parameters = new Dictionary<string, string> { { "state", "open" }, { "sort", "other" }, { "per_page", "5" } };
var actual = uri.ApplyParameters(parameters);
Assert.Equal(
@@ -106,7 +106,7 @@ namespace Octokit.Tests.Helpers
var uri = new Uri("repositories/1/milestones?state=closed&sort=due_date&direction=asc&page=2", UriKind.Relative);
var parameters = new Dictionary<string, string> { { "state", "open" }, { "sort", "other" }, { "per_page", "5" } };
var actual = uri.ApplyParameters(parameters);
Assert.Equal(

4
Octokit.Tests/Models/StringEnumTests.cs
View File

@@ -38,7 +38,7 @@ namespace Octokit.Tests.Models
[Fact]
public void ShouldThrowForInvalidEnumValue()
{
Assert.Throws<ArgumentException>(() => new StringEnum<AccountType>((AccountType) 1337));
Assert.Throws<ArgumentException>(() => new StringEnum<AccountType>((AccountType)1337));
}
}
@@ -134,7 +134,7 @@ namespace Octokit.Tests.Models
public void ShouldThrowForInvalidEnumValue()
{
StringEnum<AccountType> stringEnum;
Assert.Throws<ArgumentException>(() => stringEnum = (AccountType) 1337);
Assert.Throws<ArgumentException>(() => stringEnum = (AccountType)1337);
}
}

20
Octokit.Tests/Reactive/ObservableOrganizationOutsideCollaboratorsClientTests.cs
View File

@@ -51,8 +51,8 @@ namespace Octokit.Tests.Reactive
client.GetAll("org", options);
gitHubClient.Connection.Received(1).Get<List<User>>(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
"application/vnd.github.korra-preview+json");
}
@@ -86,8 +86,8 @@ namespace Octokit.Tests.Reactive
client.GetAll("org", OrganizationMembersFilter.All);
gitHubClient.Connection.Received(1).Get<List<User>>(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=all"),
Args.EmptyDictionary,
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=all"),
Args.EmptyDictionary,
"application/vnd.github.korra-preview+json");
}
@@ -107,8 +107,8 @@ namespace Octokit.Tests.Reactive
client.GetAll("org", OrganizationMembersFilter.All, options);
gitHubClient.Connection.Received(1).Get<List<User>>(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=all"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=all"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
"application/vnd.github.korra-preview+json");
}
@@ -121,8 +121,8 @@ namespace Octokit.Tests.Reactive
client.GetAll("org", OrganizationMembersFilter.TwoFactorAuthenticationDisabled);
gitHubClient.Connection.Received(1).Get<List<User>>(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=2fa_disabled"),
Args.EmptyDictionary,
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=2fa_disabled"),
Args.EmptyDictionary,
"application/vnd.github.korra-preview+json");
}
@@ -142,8 +142,8 @@ namespace Octokit.Tests.Reactive
client.GetAll("org", OrganizationMembersFilter.TwoFactorAuthenticationDisabled, options);
gitHubClient.Connection.Received(1).Get<List<User>>(
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=2fa_disabled"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
Arg.Is<Uri>(u => u.ToString() == "orgs/org/outside_collaborators?filter=2fa_disabled"),
Arg.Is<IDictionary<string, string>>(d => d.Count == 2),
"application/vnd.github.korra-preview+json");
}
}

8
Octokit.Tests/Reactive/ObservableProjectsClientTests.cs
View File

@@ -185,7 +185,7 @@ namespace Octokit.Tests.Reactive
client.Get(1);
gitHubClient.Repository.Project.Received().Get(1);
}
}
}
public class TheCreateForRepositoryMethod
@@ -200,7 +200,7 @@ namespace Octokit.Tests.Reactive
client.CreateForRepository(1, newProject);
gitHubClient.Repository.Project.Received().CreateForRepository(1, newProject);
}
}
[Fact]
public async Task EnsuresNonNullArguments()
@@ -250,7 +250,7 @@ namespace Octokit.Tests.Reactive
client.Update(1, updateProject);
gitHubClient.Repository.Project.Received().Update(1, updateProject);
}
}
[Fact]
public async Task EnsuresNonNullArguments()
@@ -273,7 +273,7 @@ namespace Octokit.Tests.Reactive
client.Delete(1);
gitHubClient.Repository.Project.Received().Delete(1);
}
}
}
}
}

9
Octokit.Tests/Reactive/ObservablePullRequestReviewsClientTests.cs
View File

@@ -91,7 +91,6 @@ namespace Octokit.Tests.Reactive
[Fact]
public async Task RequestsCorrectUrlMulti()
{
var firstPageUrl = new Uri("repos/owner/name/pulls/7/reviews", UriKind.Relative);
var secondPageUrl = new Uri("https://example.com/page/2");
var firstPageLinks = new Dictionary<string, Uri> { { "next", secondPageUrl } };
@@ -219,7 +218,6 @@ namespace Octokit.Tests.Reactive
Assert.Throws<ArgumentException>(() => client.GetAll("", "name", 1, ApiOptions.None));
Assert.Throws<ArgumentException>(() => client.GetAll("owner", "", 1, ApiOptions.None));
}
}
@@ -254,7 +252,7 @@ namespace Octokit.Tests.Reactive
Assert.Throws<ArgumentNullException>(() => client.Get(null, "name", 1, 1));
Assert.Throws<ArgumentNullException>(() => client.Get("owner", null, 1, 1));
Assert.Throws<ArgumentException>(() => client.Get("", "name", 1, 1));
Assert.Throws<ArgumentException>(() => client.Get("owner", "", 1, 1));
}
@@ -365,7 +363,7 @@ namespace Octokit.Tests.Reactive
Assert.Throws<ArgumentNullException>(() => client.Delete(null, "name", 1, 1));
Assert.Throws<ArgumentNullException>(() => client.Delete("owner", null, 1, 1));
Assert.Throws<ArgumentException>(() => client.Delete("", "name", 1, 1));
Assert.Throws<ArgumentException>(() => client.Delete("owner", "", 1, 1));
}
@@ -584,7 +582,7 @@ namespace Octokit.Tests.Reactive
.Returns(Task.Factory.StartNew<IApiResponse<List<PullRequestReviewComment>>>(() => secondPageResponse));
gitHubClient.Connection.Get<List<PullRequestReviewComment>>(thirdPageUrl, Args.EmptyDictionary, null)
.Returns(Task.Factory.StartNew<IApiResponse<List<PullRequestReviewComment>>>(() => lastPageResponse));
var client = new ObservablePullRequestReviewsClient(gitHubClient);
var results = await client.GetAllComments(1, 7, 1).ToArray();
@@ -615,7 +613,6 @@ namespace Octokit.Tests.Reactive
Assert.Throws<ArgumentException>(() => client.GetAllComments("", "name", 1, 1, ApiOptions.None));
Assert.Throws<ArgumentException>(() => client.GetAllComments("owner", "", 1, 1, ApiOptions.None));
}
}

1
Octokit/Clients/IProjectCardsClient.cs
View File

@@ -12,7 +12,6 @@ namespace Octokit
/// </remarks>
public interface IProjectCardsClient
{
/// <summary>
/// Gets all cards.
/// </summary>

4
Octokit/Clients/ProjectColumnsClient.cs
View File

@@ -40,7 +40,7 @@ namespace Octokit
public Task<IReadOnlyList<ProjectColumn>> GetAll(int projectId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, "options");
return ApiConnection.GetAll<ProjectColumn>(ApiUrls.ProjectColumns(projectId), new Dictionary<string, string>(), AcceptHeaders.ProjectsApiPreview, options);
}
@@ -105,7 +105,7 @@ namespace Octokit
{
return false;
}
}
}
/// <summary>
/// Moves a column.

4
Octokit/Clients/ProjectsClient.cs
View File

@@ -246,7 +246,7 @@ namespace Octokit
return ApiConnection.Post<Project>(ApiUrls.OrganizationProjects(organization), newProject, AcceptHeaders.ProjectsApiPreview);
}
/// <summary>
/// Updates a project for this repository.
/// </summary>
@@ -261,7 +261,7 @@ namespace Octokit
return ApiConnection.Patch<Project>(ApiUrls.Project(id), projectUpdate, AcceptHeaders.ProjectsApiPreview);
}
/// <summary>
/// Deletes a project.
/// </summary>

2
Octokit/Clients/PullRequestReviewsClient.cs
View File

@@ -30,7 +30,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, number, ApiOptions.None);
}
/// <summary>

4
Octokit/Clients/RepoCollaboratorsClient.cs
View File

@@ -172,7 +172,7 @@ namespace Octokit
return ApiConnection
.Get<CollaboratorPermission>(ApiUrls.RepoCollaboratorPermission(repositoryId, user), null, AcceptHeaders.OrganizationMembershipPreview);
}
/// <summary>
/// Adds a new collaborator to the repository.
/// </summary>
@@ -210,7 +210,7 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(user, "user");
try
{
{
var response = await Connection.Put<object>(ApiUrls.RepoCollaborator(owner, name, user), permission).ConfigureAwait(false);
return response.HttpResponse.IsTrue();
}

1
Octokit/Clients/RepositoryBranchesClient.cs
View File

@@ -536,7 +536,6 @@ namespace Octokit
Ensure.ArgumentNotNullOrEmptyString(branch, "branch");
return ApiConnection.Get<EnforceAdmins>(ApiUrls.RepoProtectedBranchAdminEnforcement(repositoryId, branch), null, AcceptHeaders.ProtectedBranchesApiPreview);
}
/// <summary>

2
Octokit/Exceptions/UserIsLastOwnerOfOrganizationException.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit
/// </summary>
/// <param name="response">The HTTP payload from the server</param>
/// <param name="innerException">The inner exception</param>
public UserIsLastOwnerOfOrganizationException(IResponse response, ApiException innerException)
public UserIsLastOwnerOfOrganizationException(IResponse response, ApiException innerException)
: base(response, innerException)
{
Debug.Assert(response != null && response.StatusCode == HttpStatusCode.Forbidden,

2
Octokit/Exceptions/UserIsNotMemberOfOrganizationException.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit
/// </summary>
/// <param name="response">The HTTP payload from the server</param>
/// <param name="innerException">The inner exception</param>
public UserIsNotMemberOfOrganizationException(IResponse response, ApiException innerException)
public UserIsNotMemberOfOrganizationException(IResponse response, ApiException innerException)
: base(response, innerException)
{
Debug.Assert(response != null && response.StatusCode == HttpStatusCode.NotFound,

2
Octokit/Exceptions/UserIsOrganizationMemberException.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit
/// </summary>
/// <param name="response">The HTTP payload from the server</param>
/// <param name="innerException">The inner exception</param>
public UserIsOrganizationMemberException(IResponse response, ApiException innerException)
public UserIsOrganizationMemberException(IResponse response, ApiException innerException)
: base(response, innerException)
{
Debug.Assert(response != null && response.StatusCode == (HttpStatusCode)422,

2
Octokit/GitHubClient.cs
View File

@@ -205,7 +205,7 @@ namespace Octokit
/// Refer to the API documentation for more information: https://developer.github.com/v3/pulls/
/// </remarks>
public IPullRequestsClient PullRequest { get; private set; }
/// <summary>
/// Access GitHub's Repositories API.
/// </summary>

1
Octokit/Helpers/AcceptHeaders.cs
View File

@@ -48,6 +48,5 @@ namespace Octokit
public const string ProjectsApiPreview = "application/vnd.github.inertia-preview+json";
public const string OrganizationMembershipPreview = "application/vnd.github.korra-preview+json";
}
}

2
Octokit/Models/Request/PullRequestReviewCreate.cs
View File

@@ -35,7 +35,7 @@ namespace Octokit
/// List of comments to include with this review
/// </summary>
public List<DraftPullRequestReviewComment> Comments { get; set; }
internal string DebuggerDisplay
{
get

4
Octokit/Models/Request/PullRequestReviewSubmit.cs
View File

@@ -14,7 +14,7 @@ namespace Octokit
public PullRequestReviewSubmit()
{
}
/// <summary>
/// The body of the review message
/// </summary>
@@ -24,7 +24,7 @@ namespace Octokit
/// The review event - Approve, Request Changes, Comment
/// </summary>
public PullRequestReviewEvent Event { get; set; }
internal string DebuggerDisplay
{
get

1
Octokit/Models/Request/RepositoryUpdate.cs
View File

@@ -12,7 +12,6 @@ namespace Octokit
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class RepositoryUpdate
{
/// <summary>
/// Creates an object that describes an update to a repository on GitHub.
/// </summary>

12
Octokit/Models/Response/PullRequestReview.cs
View File

@@ -15,7 +15,7 @@ namespace Octokit
Id = id;
}
public PullRequestReview(long id, string commitId, User user, string body, string htmlUrl, string pullRequestUrl, PullRequestReviewState state)
public PullRequestReview(long id, string commitId, User user, string body, string htmlUrl, string pullRequestUrl, PullRequestReviewState state)
{
Id = id;
CommitId = commitId;
@@ -25,7 +25,7 @@ namespace Octokit
PullRequestUrl = pullRequestUrl;
State = state;
}
/// <summary>
/// The review Id.
/// </summary>
@@ -40,7 +40,7 @@ namespace Octokit
/// The commit Id the review is associated with.
/// </summary>
public string CommitId { get; protected set; }
/// <summary>
/// The user that created the review.
/// </summary>
@@ -50,7 +50,7 @@ namespace Octokit
/// The text of the review.
/// </summary>
public string Body { get; protected set; }
/// <summary>
/// The URL for this review on Github.com
/// </summary>
@@ -60,7 +60,7 @@ namespace Octokit
/// The URL for the pull request via the API.
/// </summary>
public string PullRequestUrl { get; protected set; }
internal string DebuggerDisplay
{
get { return string.Format(CultureInfo.InvariantCulture, "Id: {0}, State: {1}, User: {2}", Id, State.DebuggerDisplay, User.DebuggerDisplay); }
@@ -71,7 +71,7 @@ namespace Octokit
{
[Parameter(Value = "APPROVED")]
Approved,
[Parameter(Value = "CHANGES_REQUESTED")]
ChangesRequested,

2
Octokit/Models/Response/StringEnum.cs
View File

@@ -109,7 +109,7 @@ namespace Octokit
return false;
}
return obj is StringEnum<TEnum> && Equals((StringEnum<TEnum>) obj);
return obj is StringEnum<TEnum> && Equals((StringEnum<TEnum>)obj);
}
public override int GetHashCode()

75
ReleaseNotes.md
View File

@@ -1,3 +1,78 @@
### New in 0.25.0 (released 23/8/2017)
## Advisories and Breaking Changes
- Octokit.net has been ported to dotnetcore :tada: providing libraries targetting `netstandard1.1` and `net45` frameworks
- `Enum` fields in Octokit response classes are now wrapped in an `StringEnum<TEnum>` helper class, to provide more robustness in dealing with unknown API values for these fields. Whilst the changes are backwards compatible, please consult the guidance on [working with Enums](https://github.com/octokit/octokit.net/blob/master/docs/working-with-enums.md) for more information
- `IncludeAdmins` field is no longer present in `BranchProtectionRequiredStatusChecks` and `BranchProtectionRequiredStatusChecksUpdate` classes, instead use the new `EnforceAdmins` field on `BranchProtectionSettingsUpdate` or the [new explicit methods](https://github.com/octokit/octokit.net/blob/master/Octokit/Clients/IRepositoryBranchesClient.cs#L304-L365) for configuring Admin Enforcement on protected branches. This was an [upstream API breaking change](https://developer.github.com/changes/2017-05-02-adoption-of-admin-enforced/) so we couldn't follow our normal deprecation schedule
## Release Notes
### Milestone: CAKE Builds
**Features/Enhancements**
- Add a build task to validate LINQPad samples - [#1551](https://github.com/octokit/octokit.net/pull/1551) via [@mderriey](https://github.com/mderriey)
- Add a code formatting task to CAKE - [#1550](https://github.com/octokit/octokit.net/pull/1550) via [@mderriey](https://github.com/mderriey)
- Add GitVersion configuration file - [#1555](https://github.com/octokit/octokit.net/pull/1555) via [@mderriey](https://github.com/mderriey)
### Milestone: dotnetcore Support
**Features/Enhancements**
- Port to .NET Core - [#1503](https://github.com/octokit/octokit.net/pull/1503) via [@mderriey](https://github.com/mderriey), [@ryangribble](https://github.com/ryangribble)
- Remove unneeded files for .NET Core - [#1549](https://github.com/octokit/octokit.net/pull/1549) via [@mderriey](https://github.com/mderriey)
- Migrate dotnetcore to vs2017 tooling - [#1567](https://github.com/octokit/octokit.net/pull/1567) via [@ryangribble](https://github.com/ryangribble), [@mderriey](https://github.com/mderriey)
- Provide [SourceLink](https://github.com/ctaggart/SourceLink) capability for Octokit and Octokit.Reactive assemblies - [#1574](https://github.com/octokit/octokit.net/pull/1574) via [@ryangribble](https://github.com/ryangribble), [@mderriey](https://github.com/mderriey)
- Deliver the dotnetcore port and CAKE build framework changes - [#1581](https://github.com/octokit/octokit.net/pull/1581) via [@ryangribble](https://github.com/ryangribble), [@mderriey](https://github.com/mderriey)
**Fixes**
- Fix broken JSON deserialization in .NET 4.5 after VS2017 project update - [#1647](https://github.com/octokit/octokit.net/pull/1647) via [@mderriey](https://github.com/mderriey)
### Milestone: None
**Features/Enhancements**
- Add support for the newly resurrected `PullRequest.MergeCommitSha` property - [#1562](https://github.com/octokit/octokit.net/pull/1562) via [@alexperovich](https://github.com/alexperovich)
- Enhance `RepositoryBranchesClient` to support Admin Enforcement changes - [#1598](https://github.com/octokit/octokit.net/pull/1598) via [@M-Zuber](https://github.com/M-Zuber)
- Implement [Pull Request Review Requests API (Preview)](https://developer.github.com/v3/pulls/review_requests/) - [#1588](https://github.com/octokit/octokit.net/pull/1588) via [@gdziadkiewicz](https://github.com/gdziadkiewicz), [@ryangribble](https://github.com/ryangribble)
- Provide a robust way to handle unknown enum values returned by GitHub API, to prevent deserialization errors until the enum values can be added to octokit - [#1595](https://github.com/octokit/octokit.net/pull/1595) via [@khellang](https://github.com/khellang), [@ryangribble](https://github.com/ryangribble)
- Implement [Projects API (Preview)](https://developer.github.com/v3/projects/) - [#1480](https://github.com/octokit/octokit.net/pull/1480) via [@maddin2016](https://github.com/maddin2016), [@ryangribble](https://github.com/ryangribble)
- Implement `ReviewPermission()` functionality for `OrganizationMembersClient` (Preview API) - [#1633](https://github.com/octokit/octokit.net/pull/1633) via [@alfhenrik](https://github.com/alfhenrik)
- Implement [Organization OutsideCollaborators API (Preview)](https://developer.github.com/v3/orgs/outside_collaborators/) - [#1639](https://github.com/octokit/octokit.net/pull/1639) via [@alfhenrik](https://github.com/alfhenrik), [@ryangribble](https://github.com/ryangribble)
- Implement pagination support for `OrganizationOutsideCollaboratorsClient.GetAll()` method - [#1650](https://github.com/octokit/octokit.net/pull/1650) via [@ryangribble](https://github.com/ryangribble)
- Implement `GetAllPendingInvitations()` functionality for `OrganizationMembersClient` and `TeamsClient` (Preview API) - [#1640](https://github.com/octokit/octokit.net/pull/1640) via [@alfhenrik](https://github.com/alfhenrik), [@ryangribble](https://github.com/ryangribble)
- Implement [Pull Request Reviews API](https://developer.github.com/v3/pulls/reviews/) - [#1648](https://github.com/octokit/octokit.net/pull/1648) via [@hartra344](https://github.com/hartra344), [@ryangribble](https://github.com/ryangribble)
**Fixes**
- Fix `RepositoryTrafficClient` to handle upstream API change in timestamps from Unix epoch time to ISO8601 - [#1560](https://github.com/octokit/octokit.net/pull/1560) via [@mderriey](https://github.com/mderriey), [@ryangribble](https://github.com/ryangribble)
- Fix more `IssueTimelineClient` deserialization exceptions by adding more new `EventInfoState` values - [#1563](https://github.com/octokit/octokit.net/pull/1563) via [@ryangribble](https://github.com/ryangribble)
- Fix `NotificationsClient.MarkAsRead()` exception by specifying a payload body in the `PUT` request - [#1579](https://github.com/octokit/octokit.net/pull/1579) via [@shiftkey](https://github.com/shiftkey), [@ryangribble](https://github.com/ryangribble)
- Fix `connection.GetLastApiInfo()` was returning `null` in some situations - [#1580](https://github.com/octokit/octokit.net/pull/1580) via [@ryangribble](https://github.com/ryangribble)
- Fix even more `IssueTimelineClient` deserialization exceptions by adding even more new `EventInfoState` values (this is getting old!) - [#1591](https://github.com/octokit/octokit.net/pull/1591) via [@lynnfaraday](https://github.com/lynnfaraday), [@ryangribble](https://github.com/ryangribble)
- `NewRepositoryWebHook.ToRequest()` no longer discards existing fields if they are set - [#1623](https://github.com/octokit/octokit.net/pull/1623) via [@ctolkien](https://github.com/ctolkien)
- Fix pagination on API calls that use `Uri` parameters (typically for requests that include some form of filtering) - [#1649](https://github.com/octokit/octokit.net/pull/1649) via [@ryangribble](https://github.com/ryangribble)
- Fixed `RepositoryCommitsClient.GetSha1()` to correctly obtain the sha1 of the specified commit, after the API went from preview to official - [#1654](https://github.com/octokit/octokit.net/pull/1654) via [@ryangribble](https://github.com/ryangribble)
**Housekeeping**
- Remove obsolete constructor of `RepositoryUpdate` request class - [#1569](https://github.com/octokit/octokit.net/pull/1569) via [@eriawan](https://github.com/eriawan)
- Remove unused Rx-Main dependency from LINQPad samples - [#1593](https://github.com/octokit/octokit.net/pull/1593) via [@NickCraver](https://github.com/NickCraver)
- Change response models 'Url' properties from `Uri` to `string` - [#1585](https://github.com/octokit/octokit.net/pull/1585) via [@mderriey](https://github.com/mderriey)
- Remove obsolete branch protection methods/classes - [#1620](https://github.com/octokit/octokit.net/pull/1620) via [@ryangribble](https://github.com/ryangribble)
- Remove methods and members that were marked `[Obsolete]` in 0.23 or earlier - [#1622](https://github.com/octokit/octokit.net/pull/1622) via [@ryangribble](https://github.com/ryangribble)
**Documentation Updates**
- Fix `Issue` documentation samples (`GetForRepository()` should be `GetForRepository()`) - [#1602](https://github.com/octokit/octokit.net/pull/1602) via [@tnaoto](https://github.com/tnaoto)
- Fix `Release` documentation samples (`ReleaseUpdate` should be `NewRelease`) - [#1611](https://github.com/octokit/octokit.net/pull/1611) via [@watsonlu](https://github.com/watsonlu)
### New in 0.24.0 (released 17/1/2017)
**Features/Enhancements**