From 5f306cfdcc0cae3ee3c2a6e695899c3a287725a1 Mon Sep 17 00:00:00 2001 From: Abdelkhalek Oussama Elhamer Date: Wed, 23 Mar 2016 19:04:16 +0100 Subject: [PATCH] Change the GetAll methode signature in the ICommitStatusClient interface --- Octokit.Tests/Clients/CommitStatusClientTests.cs | 2 +- Octokit/Clients/CommitStatusClient.cs | 12 ++++++------ Octokit/Clients/ICommitStatusClient.cs | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Octokit.Tests/Clients/CommitStatusClientTests.cs b/Octokit.Tests/Clients/CommitStatusClientTests.cs index cafa6250..46a16e50 100644 --- a/Octokit.Tests/Clients/CommitStatusClientTests.cs +++ b/Octokit.Tests/Clients/CommitStatusClientTests.cs @@ -35,7 +35,7 @@ namespace Octokit.Tests.Clients StartPage = 1 }; - client.GetAll("fake", "repo",options, "sha"); + client.GetAll("fake", "repo", "sha", options); connection.Received() .GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/commits/sha/statuses")); diff --git a/Octokit/Clients/CommitStatusClient.cs b/Octokit/Clients/CommitStatusClient.cs index ab77f1f9..b890bdff 100644 --- a/Octokit/Clients/CommitStatusClient.cs +++ b/Octokit/Clients/CommitStatusClient.cs @@ -36,7 +36,7 @@ namespace Octokit Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); - return GetAll(owner,name,ApiOptions.None,reference); + return GetAll(owner,name,reference,ApiOptions.None); } /// @@ -47,16 +47,16 @@ namespace Octokit /// https://developer.github.com/v3/repos/statuses/#list-statuses-for-a-specific-ref /// /// The owner of the repository - /// The name of the repository - /// Options for changing the API response + /// The name of the repository /// The reference (SHA, branch name, or tag name) to list commits for + /// Options for changing the API response /// - public Task> GetAll(string owner, string name, ApiOptions options, string reference) + public Task> GetAll(string owner, string name, string reference, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); - Ensure.ArgumentNotNullOrEmptyString(name, "name"); - Ensure.ArgumentNotNull(options, "options"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + Ensure.ArgumentNotNull(options, "options"); return ApiConnection.GetAll(ApiUrls.CommitStatuses(owner, name, reference),options); } diff --git a/Octokit/Clients/ICommitStatusClient.cs b/Octokit/Clients/ICommitStatusClient.cs index 990bb652..eb3c7209 100644 --- a/Octokit/Clients/ICommitStatusClient.cs +++ b/Octokit/Clients/ICommitStatusClient.cs @@ -32,11 +32,11 @@ namespace Octokit /// https://developer.github.com/v3/repos/statuses/#list-statuses-for-a-specific-ref /// /// The owner of the repository - /// The name of the repository - /// Options for changing the API response + /// The name of the repository /// The reference (SHA, branch name, or tag name) to list commits for + /// Options for changing the API response /// - Task> GetAll(string owner, string name, ApiOptions options, string reference); + Task> GetAll(string owner, string name, string reference, ApiOptions options); /// /// Retrieves a combined view of statuses for the specified reference. A reference can be a commit SHA, a branch name, or