From 6092c4f4912ef1627fd51095878377f47315a53e Mon Sep 17 00:00:00 2001 From: Matt Burke Date: Wed, 2 Oct 2013 17:24:54 -0400 Subject: [PATCH] Reduce noise. * Remove using statements that were the only change to a file. * Remove methods that were added and are no longer used. --- .../RepositoriesClientTests.cs | 1 - Octokit.Tests/Clients/ReleasesClientTests.cs | 4 +-- .../Clients/RepositoriesClientTests.cs | 2 -- Octokit/ApiExtensions.cs | 8 ------ Octokit/Clients/ApiPagination.cs | 13 ---------- Octokit/Helpers/StringExtensions.cs | 5 ---- Octokit/Http/ApiConnection.cs | 25 ------------------- Octokit/Http/IApiConnection.cs | 2 -- Octokit/IApiPagination.cs | 1 - 9 files changed, 2 insertions(+), 59 deletions(-) diff --git a/Octokit.Tests.Integration/RepositoriesClientTests.cs b/Octokit.Tests.Integration/RepositoriesClientTests.cs index 92157975..3b55a09c 100644 --- a/Octokit.Tests.Integration/RepositoriesClientTests.cs +++ b/Octokit.Tests.Integration/RepositoriesClientTests.cs @@ -1,5 +1,4 @@ using System; -using System.Linq; using System.Threading.Tasks; using Xunit; diff --git a/Octokit.Tests/Clients/ReleasesClientTests.cs b/Octokit.Tests/Clients/ReleasesClientTests.cs index 2ab3ffc1..c7de133e 100644 --- a/Octokit.Tests/Clients/ReleasesClientTests.cs +++ b/Octokit.Tests/Clients/ReleasesClientTests.cs @@ -23,7 +23,7 @@ namespace Octokit.Tests.Clients releasesClient.GetAll("fake", "repo"); - client.Received().GetAll(Arg.Is(u => u.ToString() == "/repos/fake/repo/releases"), null); + client.Received().GetAll(Arg.Is(u => u.ToString() == "/repos/fake/repo/releases"), null); } [Fact] @@ -47,7 +47,7 @@ namespace Octokit.Tests.Clients releasesClient.CreateRelease("fake", "repo", data); - client.Received().Create(Arg.Is(u => u.ToString() == "/repos/fake/repo/releases"), data); + client.Received().Create(Arg.Is(u => u.ToString() == "/repos/fake/repo/releases"), data); } [Fact] diff --git a/Octokit.Tests/Clients/RepositoriesClientTests.cs b/Octokit.Tests/Clients/RepositoriesClientTests.cs index 0504b6d5..08a0ec5b 100644 --- a/Octokit.Tests/Clients/RepositoriesClientTests.cs +++ b/Octokit.Tests/Clients/RepositoriesClientTests.cs @@ -1,6 +1,4 @@ using System; -using System.Collections.Generic; -using System.IO; using System.Text; using System.Threading.Tasks; using NSubstitute; diff --git a/Octokit/ApiExtensions.cs b/Octokit/ApiExtensions.cs index 58a882ef..d813a203 100644 --- a/Octokit/ApiExtensions.cs +++ b/Octokit/ApiExtensions.cs @@ -26,14 +26,6 @@ namespace Octokit return connection.GetAll(endpoint, null); } - public static Task> GetAll(this IApiConnection connection, Uri endpoint) - { - Ensure.ArgumentNotNull(connection, "connection"); - Ensure.ArgumentNotNull(endpoint, "endpoint"); - - return connection.GetAll(endpoint, null); - } - public static Task GetHtml(this IApiConnection connection, Uri endpoint) { Ensure.ArgumentNotNull(connection, "connection"); diff --git a/Octokit/Clients/ApiPagination.cs b/Octokit/Clients/ApiPagination.cs index ff5e0a8d..997d9a13 100644 --- a/Octokit/Clients/ApiPagination.cs +++ b/Octokit/Clients/ApiPagination.cs @@ -26,18 +26,5 @@ namespace Octokit.Clients } return new ReadOnlyCollection(allItems); } - - public async Task> GetAllPages(Func>> getFirstPage) - { - Ensure.ArgumentNotNull(getFirstPage, "getFirstPage"); - - var page = await getFirstPage(); - var allItems = new List(page); - while ((page = await page.GetNextPage()) != null) - { - allItems.AddRange(page); - } - return new ReadOnlyCollection(allItems); - } } } diff --git a/Octokit/Helpers/StringExtensions.cs b/Octokit/Helpers/StringExtensions.cs index e62d711f..a834271f 100644 --- a/Octokit/Helpers/StringExtensions.cs +++ b/Octokit/Helpers/StringExtensions.cs @@ -51,11 +51,6 @@ namespace Octokit } #endif - public static string EscapeUri(this string s) - { - return Uri.EscapeUriString(s); - } - // :trollface: [SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "Ruby don't care. Ruby don't play that.")] diff --git a/Octokit/Http/ApiConnection.cs b/Octokit/Http/ApiConnection.cs index b155241a..04a0cd57 100644 --- a/Octokit/Http/ApiConnection.cs +++ b/Octokit/Http/ApiConnection.cs @@ -55,13 +55,6 @@ namespace Octokit.Http return await pagination.GetAllPages(async () => await GetPage(endpoint, parameters)); } - public async Task> GetAll(Uri endpoint, IDictionary parameters) - { - Ensure.ArgumentNotNull(endpoint, "endpoint"); - - return await pagination.GetAllPages(async () => await GetPage(endpoint, parameters)); - } - public async Task Create(Uri endpoint, object data) { Ensure.ArgumentNotNull(endpoint, "endpoint"); @@ -72,16 +65,6 @@ namespace Octokit.Http return response.BodyAsObject; } - public async Task Create(Uri endpoint, object data) - { - Ensure.ArgumentNotNull(endpoint, "endpoint"); - Ensure.ArgumentNotNull(data, "data"); - - var response = await Connection.PostAsync(endpoint, data); - - return response.BodyAsObject; - } - public async Task Update(Uri endpoint, object data) { Ensure.ArgumentNotNull(endpoint, "endpoint"); @@ -125,13 +108,5 @@ namespace Octokit.Http var response = await Connection.GetAsync>(endpoint, parameters); return new ReadOnlyPagedCollection(response, Connection); } - - async Task> GetPage(Uri endpoint, IDictionary parameters) - { - Ensure.ArgumentNotNull(endpoint, "endpoint"); - - var response = await Connection.GetAsync>(endpoint, parameters); - return new ReadOnlyPagedCollection(response, Connection); - } } } diff --git a/Octokit/Http/IApiConnection.cs b/Octokit/Http/IApiConnection.cs index 5c264232..36e33bf7 100644 --- a/Octokit/Http/IApiConnection.cs +++ b/Octokit/Http/IApiConnection.cs @@ -18,9 +18,7 @@ namespace Octokit.Http Task GetItem(Uri endpoint, IDictionary parameters); Task GetHtml(Uri endpoint, IDictionary parameters); Task> GetAll(Uri endpoint, IDictionary parameters); - Task> GetAll(Uri endpoint, IDictionary parameters); Task Create(Uri endpoint, object data); - Task Create(Uri endpoint, object data); Task Update(Uri endpoint, object data); Task Delete(Uri endpoint); Task Upload(Uri uri, Stream rawData, Dictionary headers); diff --git a/Octokit/IApiPagination.cs b/Octokit/IApiPagination.cs index b7986b71..a6aae0e7 100644 --- a/Octokit/IApiPagination.cs +++ b/Octokit/IApiPagination.cs @@ -7,6 +7,5 @@ namespace Octokit public interface IApiPagination { Task> GetAllPages(Func>> getFirstPage); - Task> GetAllPages(Func>> getFirstPage); } } \ No newline at end of file