Enable support for milestone-based issues queries (#1788)

* Added support for Milestone filter in SearchIssuesRequest

* Fixed some styling issues to match with the style of the existing code

* Wrap milestone value with double quotes as milestones can contain spaces

* Allow milestone filter to contain double quotes

* Ability to search by milestone exclusions

* Moved the EscapeDoubleQuotes method to StringExtensions
This commit is contained in:
mkArtak
2018-03-27 23:45:51 -07:00
committed by Ryan Gribble
parent 4e804f61a6
commit 6577c3ccba
6 changed files with 107 additions and 7 deletions
@@ -64,5 +64,30 @@ namespace Octokit.Tests.Helpers
Assert.Equal(expected, template.ExpandUriTemplate(new { name = "example name.txt", label = "labeltext" }).ToString());
}
}
public class EscapeDoubleQuotesMethod
{
[Fact]
public void EscapeDoubleQuotesReturnsNullForNullInput()
{
Assert.Equal(null, (null as string).EscapeDoubleQuotes());
}
[Fact]
public void EscapeDoubleQuotesReturnsInputWithoutDoubleQuotes()
{
string input = "some test input without double quotes in it";
Assert.Equal(input, input.EscapeDoubleQuotes());
}
[Fact]
public void EscapeDoubleQuotesEscapesAllDoubleQuotes()
{
string input = "\"test milestone\"";
Assert.Equal("\\\"test milestone\\\"", input.EscapeDoubleQuotes());
}
}
}
}