zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-05 23:06:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

[FIX]: reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs. (#2948)

Browse Source 
* reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs.

* updates interfaces and implementations for id naming

* updates reactive to match sync SDKs
This commit is contained in:
Nick Floyd
2024-07-02 15:31:59 -05:00
committed by GitHub
parent 6565a07974
commit 6bb0408582
77 changed files with 1945 additions and 1945 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Octokit.Reactive/Clients/IObservableAssigneesClient.cs
View File

@@ -51,20 +51,20 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="assignees">List of names of assignees to add</param>
/// <returns></returns>
IObservable<Issue> AddAssignees(string owner, string name, int number, AssigneesUpdate assignees);
IObservable<Issue> AddAssignees(string owner, string name, int issueNumber, AssigneesUpdate assignees);
/// <summary>
/// Remove assignees from a specified Issue.
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="assignees">List of assignees to remove </param>
/// <returns></returns>
IObservable<Issue> RemoveAssignees(string owner, string name, int number, AssigneesUpdate assignees);
IObservable<Issue> RemoveAssignees(string owner, string name, int issueNumber, AssigneesUpdate assignees);
/// <summary>
/// Checks to see if a user is an assignee for a repository.

40
Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs
View File

@@ -107,16 +107,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber);
/// <summary>
/// Gets Issue Comments for a specified Issue.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber);
/// <summary>
/// Gets Issue Comments for a specified Issue.
@@ -124,18 +124,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, ApiOptions options);
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options);
/// <summary>
/// Gets Issue Comments for a specified Issue.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, ApiOptions options);
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options);
/// <summary>
/// Gets Issue Comments for a specified Issue.
@@ -143,18 +143,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request);
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request);
/// <summary>
/// Gets Issue Comments for a specified Issue.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request);
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request);
/// <summary>
/// Gets Issue Comments for a specified Issue.
@@ -162,20 +162,20 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request, ApiOptions options);
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request, ApiOptions options);
/// <summary>
/// Gets Issue Comments for a specified Issue.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request, ApiOptions options);
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request, ApiOptions options);
/// <summary>
/// Creates a new Issue Comment for a specified Issue.
@@ -183,18 +183,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="newComment">The text of the new comment</param>
IObservable<IssueComment> Create(string owner, string name, int number, string newComment);
IObservable<IssueComment> Create(string owner, string name, int issueNumber, string newComment);
/// <summary>
/// Creates a new Issue Comment for a specified Issue.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="newComment">The text of the new comment</param>
IObservable<IssueComment> Create(long repositoryId, int number, string newComment);
IObservable<IssueComment> Create(long repositoryId, int issueNumber, string newComment);
/// <summary>
/// Updates a specified Issue Comment.

24
Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
View File

@@ -17,8 +17,8 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
IObservable<Reaction> GetAll(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Reaction> GetAll(string owner, string name, int issueNumber);
/// <summary>
/// List reactions for a specified Issue.
@@ -26,26 +26,26 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, int issueNumber, ApiOptions options);
/// <summary>
/// List reactions for a specified Issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
IObservable<Reaction> GetAll(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Reaction> GetAll(long repositoryId, int issueNumber);
/// <summary>
/// List reactions for a specified Issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, int issueNumber, ApiOptions options);
/// <summary>
/// Creates a reaction for a specified Issue.
@@ -53,18 +53,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, int issueNumber, NewReaction reaction);
/// <summary>
/// Creates a reaction for a specified Issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, int issueNumber, NewReaction reaction);
/// <summary>
/// Deletes a reaction for a specified Issue

16
Octokit.Reactive/Clients/IObservableIssueTimelineClient.cs
View File

@@ -18,8 +18,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <param name="number">The issue number</param>
IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int issueNumber);
/// <summary>
/// Gets all the various events that have occurred around an issue or pull request.
@@ -29,9 +29,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int number, ApiOptions options);
IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int issueNumber, ApiOptions options);
/// <summary>
/// Gets all the various events that have occurred around an issue or pull request.
@@ -40,8 +40,8 @@ namespace Octokit.Reactive
/// https://developer.github.com/v3/issues/timeline/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int issueNumber);
/// <summary>
/// Gets all the various events that have occurred around an issue or pull request.
@@ -50,8 +50,8 @@ namespace Octokit.Reactive
/// https://developer.github.com/v3/issues/timeline/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int number, ApiOptions options);
IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options);
}
}

26
Octokit.Reactive/Clients/IObservableIssuesClient.cs
View File

@@ -23,8 +23,8 @@ namespace Octokit.Reactive
IObservableMilestonesClient Milestone { get; }
/// <summary>
/// Client for reading various event information associated with issues/pull requests.
/// This is useful both for display on issue/pull request information pages and also to
/// Client for reading various event information associated with issues/pull requests.
/// This is useful both for display on issue/pull request information pages and also to
/// determine who should be notified of comments.
/// </summary>
IObservableIssuesEventsClient Events { get; }
@@ -57,10 +57,10 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Issue> Get(string owner, string name, int number);
IObservable<Issue> Get(string owner, string name, int issueNumber);
/// <summary>
/// Gets a single Issue by number.
@@ -69,10 +69,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/#get-a-single-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Issue> Get(long repositoryId, int number);
IObservable<Issue> Get(long repositoryId, int issueNumber);
/// <summary>
/// Gets all open issues assigned to the authenticated user across all the authenticated user’s visible
@@ -96,7 +96,7 @@ namespace Octokit.Reactive
IObservable<Issue> GetAllForCurrent(ApiOptions options);
/// <summary>
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// member repositories, and organization repositories.
/// </summary>
/// <remarks>
@@ -106,7 +106,7 @@ namespace Octokit.Reactive
IObservable<Issue> GetAllForCurrent(IssueRequest request);
/// <summary>
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// member repositories, and organization repositories.
/// </summary>
/// <remarks>
@@ -306,10 +306,10 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/#create-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="issueUpdate">An <see cref="IssueUpdate"/> instance describing the changes to make to the issue
/// </param>
IObservable<Issue> Update(string owner, string name, int number, IssueUpdate issueUpdate);
IObservable<Issue> Update(string owner, string name, int issueNumber, IssueUpdate issueUpdate);
/// <summary>
/// Creates an issue for the specified repository. Any user with pull access to a repository can create an
@@ -317,9 +317,9 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/#create-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="issueUpdate">An <see cref="IssueUpdate"/> instance describing the changes to make to the issue
/// </param>
IObservable<Issue> Update(long repositoryId, int number, IssueUpdate issueUpdate);
IObservable<Issue> Update(long repositoryId, int issueNumber, IssueUpdate issueUpdate);
}
}
}

16
Octokit.Reactive/Clients/IObservableIssuesEventsClient.cs
View File

@@ -19,8 +19,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
IObservable<IssueEvent> GetAllForIssue(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<IssueEvent> GetAllForIssue(string owner, string name, int issueNumber);
/// <summary>
/// Gets all events for the issue.
@@ -29,8 +29,8 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
IObservable<IssueEvent> GetAllForIssue(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<IssueEvent> GetAllForIssue(long repositoryId, int issueNumber);
/// <summary>
/// Gets all events for the issue.
@@ -40,9 +40,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueEvent> GetAllForIssue(string owner, string name, int number, ApiOptions options);
IObservable<IssueEvent> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options);
/// <summary>
/// Gets all events for the issue.
@@ -51,9 +51,9 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<IssueEvent> GetAllForIssue(long repositoryId, int number, ApiOptions options);
IObservable<IssueEvent> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options);
/// <summary>
/// Gets all events for the repository.

64
Octokit.Reactive/Clients/IObservableIssuesLabelsClient.cs
View File

@@ -20,8 +20,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
IObservable<Label> GetAllForIssue(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Label> GetAllForIssue(string owner, string name, int issueNumber);
/// <summary>
/// Gets all labels for the issue.
@@ -30,8 +30,8 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#list-labels-on-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
IObservable<Label> GetAllForIssue(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Label> GetAllForIssue(long repositoryId, int issueNumber);
/// <summary>
/// Gets all labels for the issue.
@@ -41,9 +41,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Label> GetAllForIssue(string owner, string name, int number, ApiOptions options);
IObservable<Label> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options);
/// <summary>
/// Gets all labels for the issue.
@@ -52,9 +52,9 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#list-labels-on-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Label> GetAllForIssue(long repositoryId, int number, ApiOptions options);
IObservable<Label> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options);
/// <summary>
/// Gets all labels for the repository.
@@ -104,8 +104,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
IObservable<Label> GetAllForMilestone(string owner, string name, int number);
/// <param name="milestoneNumber">The number of the milestone</param>
IObservable<Label> GetAllForMilestone(string owner, string name, int milestoneNumber);
/// <summary>
/// Gets labels for every issue in a milestone
@@ -114,8 +114,8 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#get-labels-for-every-issue-in-a-milestone">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the milestone</param>
IObservable<Label> GetAllForMilestone(long repositoryId, int number);
/// <param name="milestoneNumber">The number of the milestone</param>
IObservable<Label> GetAllForMilestone(long repositoryId, int milestoneNumber);
/// <summary>
/// Gets labels for every issue in a milestone
@@ -125,9 +125,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <param name="milestoneNumber">The number of the milestone</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Label> GetAllForMilestone(string owner, string name, int number, ApiOptions options);
IObservable<Label> GetAllForMilestone(string owner, string name, int milestoneNumber, ApiOptions options);
/// <summary>
/// Gets labels for every issue in a milestone
@@ -136,9 +136,9 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#get-labels-for-every-issue-in-a-milestone">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <param name="milestoneNumber">The number of the milestone</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Label> GetAllForMilestone(long repositoryId, int number, ApiOptions options);
IObservable<Label> GetAllForMilestone(long repositoryId, int milestoneNumber, ApiOptions options);
/// <summary>
/// Gets a single Label by name.
@@ -238,9 +238,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to add</param>
IObservable<Label> AddToIssue(string owner, string name, int number, string[] labels);
IObservable<Label> AddToIssue(string owner, string name, int issueNumber, string[] labels);
/// <summary>
/// Adds a label to an issue
@@ -249,9 +249,9 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#add-labels-to-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to add</param>
IObservable<Label> AddToIssue(long repositoryId, int number, string[] labels);
IObservable<Label> AddToIssue(long repositoryId, int issueNumber, string[] labels);
/// <summary>
/// Removes a label from an issue
@@ -261,9 +261,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labelName">The name of the label to remove</param>
IObservable<Label> RemoveFromIssue(string owner, string name, int number, string labelName);
IObservable<Label> RemoveFromIssue(string owner, string name, int issueNumber, string labelName);
/// <summary>
/// Removes a label from an issue
@@ -272,9 +272,9 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labelName">The name of the label to remove</param>
IObservable<Label> RemoveFromIssue(long repositoryId, int number, string labelName);
IObservable<Label> RemoveFromIssue(long repositoryId, int issueNumber, string labelName);
/// <summary>
/// Replaces all labels on the specified issues with the provided labels
@@ -284,9 +284,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to set</param>
IObservable<Label> ReplaceAllForIssue(string owner, string name, int number, string[] labels);
IObservable<Label> ReplaceAllForIssue(string owner, string name, int issueNumber, string[] labels);
/// <summary>
/// Replaces all labels on the specified issues with the provided labels
@@ -295,9 +295,9 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#replace-all-labels-for-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to set</param>
IObservable<Label> ReplaceAllForIssue(long repositoryId, int number, string[] labels);
IObservable<Label> ReplaceAllForIssue(long repositoryId, int issueNumber, string[] labels);
/// <summary>
/// Removes all labels from an issue
@@ -307,8 +307,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
IObservable<Unit> RemoveAllFromIssue(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Unit> RemoveAllFromIssue(string owner, string name, int issueNumber);
/// <summary>
/// Removes all labels from an issue
@@ -317,7 +317,7 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#remove-all-labels-from-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
IObservable<Unit> RemoveAllFromIssue(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Unit> RemoveAllFromIssue(long repositoryId, int issueNumber);
}
}

16
Octokit.Reactive/Clients/IObservableLockUnlockClient.cs
View File

@@ -14,18 +14,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/issues/#lock-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="lockReason">The reason for locking the issue</param>
IObservable<Unit> Lock(string owner, string name, int number, LockReason? lockReason = null);
IObservable<Unit> Lock(string owner, string name, int issueNumber, LockReason? lockReason = null);
/// <summary>
/// Locks an issue for the specified repository. Issue owners and users with push access can lock an issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/issues/#lock-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="lockReason">The reason for locking the issue</param>
IObservable<Unit> Lock(long repositoryId, int number, LockReason? lockReason = null);
IObservable<Unit> Lock(long repositoryId, int issueNumber, LockReason? lockReason = null);
/// <summary>
/// Unlocks an issue for the specified repository. Issue owners and users with push access can unlock an issue.
@@ -33,15 +33,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/issues/#unlock-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
IObservable<Unit> Unlock(string owner, string name, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Unit> Unlock(string owner, string name, int issueNumber);
/// <summary>
/// Unlocks an issue for the specified repository. Issue owners and users with push access can unlock an issue.
/// </summary>
/// <remarks>https://developer.github.com/v3/issues/#unlock-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
IObservable<Unit> Unlock(long repositoryId, int number);
/// <param name="issueNumber">The issue number</param>
IObservable<Unit> Unlock(long repositoryId, int issueNumber);
}
}

20
Octokit.Reactive/Clients/IObservableMilestonesClient.cs
View File

@@ -21,7 +21,7 @@ namespace Octokit.Reactive
/// <returns></returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Milestone> Get(string owner, string name, int number);
IObservable<Milestone> Get(string owner, string name, int milestoneNumber);
/// <summary>
/// Gets a single Milestone by number.
@@ -32,7 +32,7 @@ namespace Octokit.Reactive
/// <returns></returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<Milestone> Get(long repositoryId, int number);
IObservable<Milestone> Get(long repositoryId, int milestoneNumber);
/// <summary>
/// Gets all open milestones for the repository.
@@ -154,11 +154,11 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/milestones/#update-a-milestone</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <param name="milestoneUpdate">An <see cref="MilestoneUpdate"/> instance describing the changes to make to the Milestone
/// </param>
/// <returns></returns>
IObservable<Milestone> Update(string owner, string name, int number, MilestoneUpdate milestoneUpdate);
IObservable<Milestone> Update(string owner, string name, int milestoneNumber, MilestoneUpdate milestoneUpdate);
/// <summary>
/// Updates a milestone for the specified repository. Any user with pull access to a repository can create a
@@ -166,11 +166,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/milestones/#update-a-milestone</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <param name="milestoneUpdate">An <see cref="MilestoneUpdate"/> instance describing the changes to make to the Milestone
/// </param>
/// <returns></returns>
IObservable<Milestone> Update(long repositoryId, int number, MilestoneUpdate milestoneUpdate);
IObservable<Milestone> Update(long repositoryId, int milestoneNumber, MilestoneUpdate milestoneUpdate);
/// <summary>
/// Deletes a milestone for the specified repository. Any user with pull access to a repository can create an
@@ -179,9 +179,9 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/milestones/#delete-a-milestone</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int number);
IObservable<Unit> Delete(string owner, string name, int milestoneNumber);
/// <summary>
/// Deletes a milestone for the specified repository. Any user with pull access to a repository can create an
@@ -189,8 +189,8 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/milestones/#delete-a-milestone</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int number);
IObservable<Unit> Delete(long repositoryId, int milestoneNumber);
}
}

20
Octokit.Reactive/Clients/IObservableNotificationsClient.cs
View File

@@ -160,38 +160,38 @@ namespace Octokit.Reactive
/// <summary>
/// Retrives a single <see cref="Notification"/> by Id.
/// </summary>
/// <param name="id">The Id of the notification to retrieve.</param>
/// <param name="notificationId">The Id of the notification to retrieve.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#view-a-single-thread</remarks>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
IObservable<Notification> Get(int id);
IObservable<Notification> Get(int notificationId);
/// <summary>
/// Marks a single notification as read.
/// </summary>
/// <param name="id">The id of the notification.</param>
/// <param name="notificationId">The id of the notification.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#mark-a-thread-as-read</remarks>
IObservable<Unit> MarkAsRead(int id);
IObservable<Unit> MarkAsRead(int notificationId);
/// <summary>
/// Retrives a <see cref="ThreadSubscription"/> for the provided thread id.
/// </summary>
/// <param name="id">The Id of the thread to retrieve subscription status.</param>
/// <param name="threadId">The Id of the thread to retrieve subscription status.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#get-a-thread-subscription</remarks>
IObservable<ThreadSubscription> GetThreadSubscription(int id);
IObservable<ThreadSubscription> GetThreadSubscription(int threadId);
/// <summary>
/// Sets the authenticated user's subscription settings for a given thread.
/// </summary>
/// <param name="id">The Id of the thread to update.</param>
/// <param name="threadId">The Id of the thread to update.</param>
/// <param name="threadSubscription">The subscription parameters to set.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#set-a-thread-subscription</remarks>
IObservable<ThreadSubscription> SetThreadSubscription(int id, NewThreadSubscription threadSubscription);
IObservable<ThreadSubscription> SetThreadSubscription(int threadId, NewThreadSubscription threadSubscription);
/// <summary>
/// Deletes the authenticated user's subscription to a given thread.
/// </summary>
/// <param name="id">The Id of the thread to delete subscription from.</param>
/// <param name="threadId">The Id of the thread to delete subscription from.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#delete-a-thread-subscription</remarks>
IObservable<Unit> DeleteThreadSubscription(int id);
IObservable<Unit> DeleteThreadSubscription(int threadId);
}
}

16
Octokit.Reactive/Clients/IObservableProjectColumnsClient.cs
View File

@@ -36,9 +36,9 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#get-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
/// <param name="columnId">The id of the column</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
IObservable<ProjectColumn> Get(int id);
IObservable<ProjectColumn> Get(int columnId);
/// <summary>
/// Creates a column.
@@ -56,9 +56,9 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#update-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
/// <param name="columnId">The id of the column</param>
/// <param name="projectColumnUpdate">New values to update the column with</param>
IObservable<ProjectColumn> Update(int id, ProjectColumnUpdate projectColumnUpdate);
IObservable<ProjectColumn> Update(int columnId, ProjectColumnUpdate projectColumnUpdate);
/// <summary>
/// Deletes a column.
@@ -66,8 +66,8 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#delete-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
IObservable<bool> Delete(int id);
/// <param name="columnId">The id of the column</param>
IObservable<bool> Delete(int columnId);
/// <summary>
/// Moves a column.
@@ -75,8 +75,8 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#move-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
/// <param name="columnId">The id of the column</param>
/// <param name="position">The position to move the column</param>
IObservable<bool> Move(int id, ProjectColumnMove position);
IObservable<bool> Move(int columnId, ProjectColumnMove position);
}
}

12
Octokit.Reactive/Clients/IObservableProjectsClient.cs
View File

@@ -141,9 +141,9 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#get-a-project">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The Id of the project</param>
/// <param name="projectId">The Id of the project</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
IObservable<Project> Get(int id);
IObservable<Project> Get(int projectId);
/// <summary>
/// Creates a project for the specified repository.
@@ -171,9 +171,9 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#update-a-project">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The Id of the project</param>
/// <param name="projectId">The Id of the project</param>
/// <param name="projectUpdate">The modified project</param>
IObservable<Project> Update(int id, ProjectUpdate projectUpdate);
IObservable<Project> Update(int projectId, ProjectUpdate projectUpdate);
/// <summary>
/// Deletes a project.
@@ -181,8 +181,8 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#delete-a-project">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The Id of the project</param>
IObservable<bool> Delete(int id);
/// <param name="projectId">The Id of the project</param>
IObservable<bool> Delete(int projectId);
/// <summary>
/// A client for GitHub's Project Cards API.

32
Octokit.Reactive/Clients/IObservablePullRequestReviewCommentsClient.cs
View File

@@ -17,16 +17,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestReviewComment> GetAll(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestReviewComment> GetAll(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets review comments for a specified pull request.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestReviewComment> GetAll(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestReviewComment> GetAll(long repositoryId, int pullRequestNumber);
/// <summary>
/// Gets review comments for a specified pull request.
@@ -34,18 +34,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReviewComment> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<PullRequestReviewComment> GetAll(string owner, string name, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Gets review comments for a specified pull request.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReviewComment> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<PullRequestReviewComment> GetAll(long repositoryId, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Gets a list of the pull request review comments in a specified repository.
@@ -138,18 +138,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
IObservable<PullRequestReviewComment> Create(string owner, string name, int number, PullRequestReviewCommentCreate comment);
IObservable<PullRequestReviewComment> Create(string owner, string name, int pullRequestNumber, PullRequestReviewCommentCreate comment);
/// <summary>
/// Creates a comment on a pull request review.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
IObservable<PullRequestReviewComment> Create(long repositoryId, int number, PullRequestReviewCommentCreate comment);
IObservable<PullRequestReviewComment> Create(long repositoryId, int pullRequestNumber, PullRequestReviewCommentCreate comment);
/// <summary>
/// Creates a comment on a pull request review as a reply to another comment.
@@ -157,18 +157,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
IObservable<PullRequestReviewComment> CreateReply(string owner, string name, int number, PullRequestReviewCommentReplyCreate comment);
IObservable<PullRequestReviewComment> CreateReply(string owner, string name, int pullRequestNumber, PullRequestReviewCommentReplyCreate comment);
/// <summary>
/// Creates a comment on a pull request review as a reply to another comment.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
IObservable<PullRequestReviewComment> CreateReply(long repositoryId, int number, PullRequestReviewCommentReplyCreate comment);
IObservable<PullRequestReviewComment> CreateReply(long repositoryId, int pullRequestNumber, PullRequestReviewCommentReplyCreate comment);
/// <summary>
/// Edits a comment on a pull request review.

24
Octokit.Reactive/Clients/IObservablePullRequestReviewRequestsClient.cs
View File

@@ -17,16 +17,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#list-review-requests</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<RequestedReviews> Get(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<RequestedReviews> Get(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets review requests for a specified pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#list-review-requests</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<RequestedReviews> Get(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<RequestedReviews> Get(long repositoryId, int pullRequestNumber);
/// <summary>
/// Creates review requests on a pull request for specified users.
@@ -34,18 +34,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#create-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of user will be requested for review</param>
IObservable<PullRequest> Create(string owner, string name, int number, PullRequestReviewRequest users);
IObservable<PullRequest> Create(string owner, string name, int pullRequestNumber, PullRequestReviewRequest users);
/// <summary>
/// Creates review requests on a pull request for specified users.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#create-a-review-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of user will be requested for review</param>
IObservable<PullRequest> Create(long repositoryId, int number, PullRequestReviewRequest users);
IObservable<PullRequest> Create(long repositoryId, int pullRequestNumber, PullRequestReviewRequest users);
/// <summary>
/// Deletes review request for given users on a pull request.
@@ -53,17 +53,17 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#delete-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of users that will be not longer requested for review</param>
IObservable<Unit> Delete(string owner, string name, int number, PullRequestReviewRequest users);
IObservable<Unit> Delete(string owner, string name, int pullRequestNumber, PullRequestReviewRequest users);
/// <summary>
/// Deletes review request for given users on a pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#delete-a-review-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of users that will be not longer requested for review</param>
IObservable<Unit> Delete(long repositoryId, int number, PullRequestReviewRequest users);
IObservable<Unit> Delete(long repositoryId, int pullRequestNumber, PullRequestReviewRequest users);
}
}

72
Octokit.Reactive/Clients/IObservablePullRequestReviewsClient.cs
View File

@@ -17,16 +17,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestReview> GetAll(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestReview> GetAll(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets reviews for a specified pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestReview> GetAll(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestReview> GetAll(long repositoryId, int pullRequestNumber);
/// <summary>
/// Gets reviews for a specified pull request.
@@ -34,18 +34,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReview> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<PullRequestReview> GetAll(string owner, string name, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Gets reviews for a specified pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReview> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<PullRequestReview> GetAll(long repositoryId, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Gets a single pull request review by ID.
@@ -53,18 +53,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<PullRequestReview> Get(string owner, string name, int number, long reviewId);
IObservable<PullRequestReview> Get(string owner, string name, int pullRequestNumber, long reviewId);
/// <summary>
/// Gets a single pull request review by ID.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<PullRequestReview> Get(long repositoryId, int number, long reviewId);
IObservable<PullRequestReview> Get(long repositoryId, int pullRequestNumber, long reviewId);
/// <summary>
/// Creates a pull request review.
@@ -72,18 +72,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="review">The review</param>
IObservable<PullRequestReview> Create(string owner, string name, int number, PullRequestReviewCreate review);
IObservable<PullRequestReview> Create(string owner, string name, int pullRequestNumber, PullRequestReviewCreate review);
/// <summary>
/// Creates a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="review">The review</param>
IObservable<PullRequestReview> Create(long repositoryId, int number, PullRequestReviewCreate review);
IObservable<PullRequestReview> Create(long repositoryId, int pullRequestNumber, PullRequestReviewCreate review);
/// <summary>
/// Deletes a pull request review.
@@ -91,18 +91,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#delete-a-pending-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<Unit> Delete(string owner, string name, int number, long reviewId);
IObservable<Unit> Delete(string owner, string name, int pullRequestNumber, long reviewId);
/// <summary>
/// Deletes a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#delete-a-pending-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<Unit> Delete(long repositoryId, int number, long reviewId);
IObservable<Unit> Delete(long repositoryId, int pullRequestNumber, long reviewId);
/// <summary>
/// Submits a pull request review.
@@ -110,20 +110,20 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#submit-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="submitMessage">The message and event being submitted for the review</param>
IObservable<PullRequestReview> Submit(string owner, string name, int number, long reviewId, PullRequestReviewSubmit submitMessage);
IObservable<PullRequestReview> Submit(string owner, string name, int pullRequestNumber, long reviewId, PullRequestReviewSubmit submitMessage);
/// <summary>
/// Submits a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#submit-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="submitMessage">The message and event being submitted for the review</param>
IObservable<PullRequestReview> Submit(long repositoryId, int number, long reviewId, PullRequestReviewSubmit submitMessage);
IObservable<PullRequestReview> Submit(long repositoryId, int pullRequestNumber, long reviewId, PullRequestReviewSubmit submitMessage);
/// <summary>
/// Dismisses a pull request review.
@@ -131,20 +131,20 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#dismiss-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="dismissMessage">The message indicating why the review was dismissed</param>
IObservable<PullRequestReview> Dismiss(string owner, string name, int number, long reviewId, PullRequestReviewDismiss dismissMessage);
IObservable<PullRequestReview> Dismiss(string owner, string name, int pullRequestNumber, long reviewId, PullRequestReviewDismiss dismissMessage);
/// <summary>
/// Dismisses a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#dismiss-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="dismissMessage">The message indicating why the review was dismissed</param>
IObservable<PullRequestReview> Dismiss(long repositoryId, int number, long reviewId, PullRequestReviewDismiss dismissMessage);
IObservable<PullRequestReview> Dismiss(long repositoryId, int pullRequestNumber, long reviewId, PullRequestReviewDismiss dismissMessage);
/// <summary>
/// Lists comments for a single review
@@ -152,18 +152,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int number, long reviewId);
IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int pullRequestNumber, long reviewId);
/// <summary>
/// Dismisses a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int number, long reviewId);
IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int pullRequestNumber, long reviewId);
/// <summary>
/// Lists comments for a single review
@@ -171,19 +171,19 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int number, long reviewId, ApiOptions options);
IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int pullRequestNumber, long reviewId, ApiOptions options);
/// <summary>
/// Dismisses a pull request review.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int number, long reviewId, ApiOptions options);
IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int pullRequestNumber, long reviewId, ApiOptions options);
}
}

56
Octokit.Reactive/Clients/IObservablePullRequestsClient.cs
View File

@@ -39,10 +39,10 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the pull request</param>
/// <param name="pullRequestNumber">The pull request number</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<PullRequest> Get(string owner, string name, int number);
IObservable<PullRequest> Get(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets a single Pull Request by number.
@@ -51,10 +51,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/pulls/#get-a-single-pull-request
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the pull request</param>
/// <param name="pullRequestNumber">The pull request number</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<PullRequest> Get(long repositoryId, int number);
IObservable<PullRequest> Get(long repositoryId, int pullRequestNumber);
/// <summary>
/// Gets all open pull requests for the repository.
@@ -163,20 +163,20 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#update-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The PullRequest number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="pullRequestUpdate">An <see cref="PullRequestUpdate"/> instance describing the changes to make to the PullRequest
/// </param>
IObservable<PullRequest> Update(string owner, string name, int number, PullRequestUpdate pullRequestUpdate);
IObservable<PullRequest> Update(string owner, string name, int pullRequestNumber, PullRequestUpdate pullRequestUpdate);
/// <summary>
/// Update a pull request for the specified repository.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#update-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The PullRequest number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="pullRequestUpdate">An <see cref="PullRequestUpdate"/> instance describing the changes to make to the PullRequest
/// </param>
IObservable<PullRequest> Update(long repositoryId, int number, PullRequestUpdate pullRequestUpdate);
IObservable<PullRequest> Update(long repositoryId, int pullRequestNumber, PullRequestUpdate pullRequestUpdate);
/// <summary>
/// Merge a pull request.
@@ -184,18 +184,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#merge-a-pull-request-merge-buttontrade</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="mergePullRequest">A <see cref="MergePullRequest"/> instance describing a pull request merge</param>
IObservable<PullRequestMerge> Merge(string owner, string name, int number, MergePullRequest mergePullRequest);
IObservable<PullRequestMerge> Merge(string owner, string name, int pullRequestNumber, MergePullRequest mergePullRequest);
/// <summary>
/// Merge a pull request.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#merge-a-pull-request-merge-buttontrade</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="mergePullRequest">A <see cref="MergePullRequest"/> instance describing a pull request merge</param>
IObservable<PullRequestMerge> Merge(long repositoryId, int number, MergePullRequest mergePullRequest);
IObservable<PullRequestMerge> Merge(long repositoryId, int pullRequestNumber, MergePullRequest mergePullRequest);
/// <summary>
/// Gets the pull request merge status.
@@ -203,16 +203,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<bool> Merged(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<bool> Merged(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets the pull request merge status.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<bool> Merged(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<bool> Merged(long repositoryId, int pullRequestNumber);
/// <summary>
/// Gets the list of commits on a pull request.
@@ -220,16 +220,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#list-commits-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestCommit> Commits(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestCommit> Commits(string owner, string name, int pullRequestNumber);
/// <summary>
/// Gets the list of commits on a pull request.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#list-commits-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestCommit> Commits(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestCommit> Commits(long repositoryId, int pullRequestNumber);
/// <summary>
/// Get the list of files on a pull request.
@@ -237,9 +237,9 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestFile> Files(string owner, string name, int number, ApiOptions options);
IObservable<PullRequestFile> Files(string owner, string name, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Get the list of files on a pull request.
@@ -247,24 +247,24 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestFile> Files(string owner, string name, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestFile> Files(string owner, string name, int pullRequestNumber);
/// <summary>
/// Get the list of files on a pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
IObservable<PullRequestFile> Files(long repositoryId, int number, ApiOptions options);
IObservable<PullRequestFile> Files(long repositoryId, int pullRequestNumber, ApiOptions options);
/// <summary>
/// Get the list of files on a pull request.
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
IObservable<PullRequestFile> Files(long repositoryId, int number);
/// <param name="pullRequestNumber">The pull request number</param>
IObservable<PullRequestFile> Files(long repositoryId, int pullRequestNumber);
}
}

8
Octokit.Reactive/Clients/IObservableReleasesClient.cs
View File

@@ -330,8 +330,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The repository's owner</param>
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the <see cref="ReleaseAsset"/>.</param>
IObservable<Unit> DeleteAsset(string owner, string name, int id);
/// <param name="assetId">The id of the <see cref="ReleaseAsset"/>.</param>
IObservable<Unit> DeleteAsset(string owner, string name, int assetId);
/// <summary>
/// Deletes the specified <see cref="ReleaseAsset"/> from the specified repository
@@ -340,7 +340,7 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/repos/releases/#delete-a-release-asset">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the <see cref="ReleaseAsset"/>.</param>
IObservable<Unit> DeleteAsset(long repositoryId, int id);
/// <param name="assetId">The id of the <see cref="ReleaseAsset"/>.</param>
IObservable<Unit> DeleteAsset(long repositoryId, int assetId);
}
}

18
Octokit.Reactive/Clients/IObservableRepositoryDeployKeysClient.cs
View File

@@ -20,9 +20,9 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository.</param>
/// <param name="name">The name of the repository.</param>
/// <param name="number">The id of the deploy key.</param>
/// <param name="deployKeyId">The id of the deploy key.</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
IObservable<DeployKey> Get(string owner, string name, int number);
IObservable<DeployKey> Get(string owner, string name, int deployKeyId);
/// <summary>
/// Get a single deploy key by number for a repository.
@@ -31,9 +31,9 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/keys/#get"> API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository.</param>
/// <param name="number">The id of the deploy key.</param>
/// <param name="deployKeyId">The id of the deploy key.</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")]
IObservable<DeployKey> Get(long repositoryId, int number);
IObservable<DeployKey> Get(long repositoryId, int deployKeyId);
/// <summary>
/// Get all deploy keys for a repository.
@@ -104,8 +104,8 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository.</param>
/// <param name="name">The name of the repository.</param>
/// <param name="number">The id of the deploy key to delete.</param>
IObservable<Unit> Delete(string owner, string name, int number);
/// <param name="deployKeyId">The id of the deploy key to delete.</param>
IObservable<Unit> Delete(string owner, string name, int deployKeyId);
/// <summary>
/// Deletes a deploy key from a repository.
@@ -114,7 +114,7 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/keys/#delete"> API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository.</param>
/// <param name="number">The id of the deploy key to delete.</param>
IObservable<Unit> Delete(long repositoryId, int number);
/// <param name="deployKeyId">The id of the deploy key to delete.</param>
IObservable<Unit> Delete(long repositoryId, int deployKeyId);
}
}
}

12
Octokit.Reactive/Clients/ObservableAssigneesClient.cs
View File

@@ -92,15 +92,15 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="assignees">List of names of assignees to add</param>
public IObservable<Issue> AddAssignees(string owner, string name, int number, AssigneesUpdate assignees)
public IObservable<Issue> AddAssignees(string owner, string name, int issueNumber, AssigneesUpdate assignees)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(assignees, nameof(assignees));
return _client.AddAssignees(owner, name, number, assignees).ToObservable();
return _client.AddAssignees(owner, name, issueNumber, assignees).ToObservable();
}
/// <summary>
@@ -108,16 +108,16 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="assignees">List of assignees to remove </param>
/// <returns></returns>
public IObservable<Issue> RemoveAssignees(string owner, string name, int number, AssigneesUpdate assignees)
public IObservable<Issue> RemoveAssignees(string owner, string name, int issueNumber, AssigneesUpdate assignees)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(assignees, nameof(assignees));
return _client.RemoveAssignees(owner, name, number, assignees).ToObservable();
return _client.RemoveAssignees(owner, name, issueNumber, assignees).ToObservable();
}
/// <summary>

62
Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs
View File

@@ -171,13 +171,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAllForIssue(owner, name, number, ApiOptions.None);
return GetAllForIssue(owner, name, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -185,10 +185,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber)
{
return GetAllForIssue(repositoryId, number, ApiOptions.None);
return GetAllForIssue(repositoryId, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -197,15 +197,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, ApiOptions options)
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return GetAllForIssue(owner, name, number, new IssueCommentRequest(), options);
return GetAllForIssue(owner, name, issueNumber, new IssueCommentRequest(), options);
}
/// <summary>
@@ -213,13 +213,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, ApiOptions options)
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return GetAllForIssue(repositoryId, number, new IssueCommentRequest(), options);
return GetAllForIssue(repositoryId, issueNumber, new IssueCommentRequest(), options);
}
/// <summary>
@@ -228,15 +228,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request)
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(request, nameof(request));
return GetAllForIssue(owner, name, number, request, ApiOptions.None);
return GetAllForIssue(owner, name, issueNumber, request, ApiOptions.None);
}
/// <summary>
@@ -244,13 +244,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request)
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request)
{
Ensure.ArgumentNotNull(request, nameof(request));
return GetAllForIssue(repositoryId, number, request, ApiOptions.None);
return GetAllForIssue(repositoryId, issueNumber, request, ApiOptions.None);
}
/// <summary>
@@ -259,17 +259,17 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request, ApiOptions options)
public IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(request, nameof(request));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name, number), request.ToParametersDictionary(), options);
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(owner, name, issueNumber), request.ToParametersDictionary(), options);
}
@@ -278,15 +278,15 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request, ApiOptions options)
public IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request, ApiOptions options)
{
Ensure.ArgumentNotNull(request, nameof(request));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(repositoryId, number), request.ToParametersDictionary(), options);
return _connection.GetAndFlattenAllPages<IssueComment>(ApiUrls.IssueComments(repositoryId, issueNumber), request.ToParametersDictionary(), options);
}
/// <summary>
@@ -295,15 +295,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="newComment">The text of the new comment</param>
public IObservable<IssueComment> Create(string owner, string name, int number, string newComment)
public IObservable<IssueComment> Create(string owner, string name, int issueNumber, string newComment)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(newComment, nameof(newComment));
return _client.Create(owner, name, number, newComment).ToObservable();
return _client.Create(owner, name, issueNumber, newComment).ToObservable();
}
/// <summary>
@@ -311,13 +311,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="newComment">The text of the new comment</param>
public IObservable<IssueComment> Create(long repositoryId, int number, string newComment)
public IObservable<IssueComment> Create(long repositoryId, int issueNumber, string newComment)
{
Ensure.ArgumentNotNull(newComment, nameof(newComment));
return _client.Create(repositoryId, number, newComment).ToObservable();
return _client.Create(repositoryId, issueNumber, newComment).ToObservable();
}
/// <summary>
@@ -377,4 +377,4 @@ namespace Octokit.Reactive
return _client.Delete(repositoryId, commentId).ToObservable();
}
}
}
}

36
Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs
View File

@@ -30,10 +30,10 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
public IObservable<Reaction> GetAll(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Reaction> GetAll(string owner, string name, int issueNumber)
{
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -42,15 +42,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<Reaction> GetAll(string owner, string name, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(owner, name, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(owner, name, issueNumber), null, options);
}
/// <summary>
@@ -58,10 +58,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
public IObservable<Reaction> GetAll(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Reaction> GetAll(long repositoryId, int issueNumber)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -69,13 +69,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<Reaction> GetAll(long repositoryId, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(repositoryId, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueReactions(repositoryId, issueNumber), null, options);
}
/// <summary>
@@ -84,15 +84,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="reaction">The reaction to create</param>
public IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction)
public IObservable<Reaction> Create(string owner, string name, int issueNumber, NewReaction reaction)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(owner, name, number, reaction).ToObservable();
return _client.Create(owner, name, issueNumber, reaction).ToObservable();
}
/// <summary>
@@ -100,13 +100,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue id</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="reaction">The reaction to create </param>
public IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction)
public IObservable<Reaction> Create(long repositoryId, int issueNumber, NewReaction reaction)
{
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(repositoryId, number, reaction).ToObservable();
return _client.Create(repositoryId, issueNumber, reaction).ToObservable();
}
/// <summary>

24
Octokit.Reactive/Clients/ObservableIssueTimelineClient.cs
View File

@@ -28,13 +28,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(repo, nameof(repo));
return GetAllForIssue(owner, repo, number, ApiOptions.None);
return GetAllForIssue(owner, repo, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -45,15 +45,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="repo">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int number, ApiOptions options)
public IObservable<TimelineEventInfo> GetAllForIssue(string owner, string repo, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(repo, nameof(repo));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<TimelineEventInfo>(ApiUrls.IssueTimeline(owner, repo, number), null, options);
return _connection.GetAndFlattenAllPages<TimelineEventInfo>(ApiUrls.IssueTimeline(owner, repo, issueNumber), null, options);
}
/// <summary>
@@ -63,10 +63,10 @@ namespace Octokit.Reactive
/// https://developer.github.com/v3/issues/timeline/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int issueNumber)
{
return GetAllForIssue(repositoryId, number, ApiOptions.None);
return GetAllForIssue(repositoryId, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -76,13 +76,13 @@ namespace Octokit.Reactive
/// https://developer.github.com/v3/issues/timeline/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int number, ApiOptions options)
public IObservable<TimelineEventInfo> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<TimelineEventInfo>(ApiUrls.IssueTimeline(repositoryId, number), null, options);
return _connection.GetAndFlattenAllPages<TimelineEventInfo>(ApiUrls.IssueTimeline(repositoryId, issueNumber), null, options);
}
}
}

34
Octokit.Reactive/Clients/ObservableIssuesClient.cs
View File

@@ -27,8 +27,8 @@ namespace Octokit.Reactive
public IObservableIssueCommentsClient Comment { get; private set; }
/// <summary>
/// Client for reading various event information associated with issues/pull requests.
/// This is useful both for display on issue/pull request information pages and also to
/// Client for reading various event information associated with issues/pull requests.
/// This is useful both for display on issue/pull request information pages and also to
/// determine who should be notified of comments.
/// </summary>
public IObservableIssuesEventsClient Events { get; private set; }
@@ -76,13 +76,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<Issue> Get(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Issue> Get(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, issueNumber).ToObservable();
}
/// <summary>
@@ -92,10 +92,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/#get-a-single-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<Issue> Get(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Issue> Get(long repositoryId, int issueNumber)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, issueNumber).ToObservable();
}
/// <summary>
@@ -128,7 +128,7 @@ namespace Octokit.Reactive
}
/// <summary>
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// member repositories, and organization repositories.
/// </summary>
/// <remarks>
@@ -143,7 +143,7 @@ namespace Octokit.Reactive
}
/// <summary>
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// Gets all issues across all the authenticated user’s visible repositories including owned repositories,
/// member repositories, and organization repositories.
/// </summary>
/// <remarks>
@@ -451,16 +451,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/#create-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="issueUpdate">An <see cref="IssueUpdate"/> instance describing the changes to make to the issue
/// </param>
public IObservable<Issue> Update(string owner, string name, int number, IssueUpdate issueUpdate)
public IObservable<Issue> Update(string owner, string name, int issueNumber, IssueUpdate issueUpdate)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(issueUpdate, nameof(issueUpdate));
return _client.Update(owner, name, number, issueUpdate).ToObservable();
return _client.Update(owner, name, issueNumber, issueUpdate).ToObservable();
}
/// <summary>
@@ -469,16 +469,16 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/#create-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="issueUpdate">An <see cref="IssueUpdate"/> instance describing the changes to make to the issue
/// </param>
public IObservable<Issue> Update(long repositoryId, int number, IssueUpdate issueUpdate)
public IObservable<Issue> Update(long repositoryId, int issueNumber, IssueUpdate issueUpdate)
{
Ensure.ArgumentNotNull(issueUpdate, nameof(issueUpdate));
return _client.Update(repositoryId, number, issueUpdate).ToObservable();
return _client.Update(repositoryId, issueNumber, issueUpdate).ToObservable();
}
}
}

26
Octokit.Reactive/Clients/ObservableIssuesEventsClient.cs
View File

@@ -31,13 +31,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<IssueEvent> GetAllForIssue(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<IssueEvent> GetAllForIssue(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAllForIssue(owner, name, number, ApiOptions.None);
return GetAllForIssue(owner, name, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -47,10 +47,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<IssueEvent> GetAllForIssue(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<IssueEvent> GetAllForIssue(long repositoryId, int issueNumber)
{
return GetAllForIssue(repositoryId, number, ApiOptions.None);
return GetAllForIssue(repositoryId, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -61,15 +61,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueEvent> GetAllForIssue(string owner, string name, int number, ApiOptions options)
public IObservable<IssueEvent> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(owner, name, number), options);
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(owner, name, issueNumber), options);
}
/// <summary>
@@ -79,13 +79,13 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/events/#list-events-for-an-issue
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<IssueEvent> GetAllForIssue(long repositoryId, int number, ApiOptions options)
public IObservable<IssueEvent> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(repositoryId, number), options);
return _connection.GetAndFlattenAllPages<IssueEvent>(ApiUrls.IssuesEvents(repositoryId, issueNumber), options);
}
/// <summary>
@@ -179,4 +179,4 @@ namespace Octokit.Reactive
return _client.Get(repositoryId, eventId).ToObservable();
}
}
}
}

96
Octokit.Reactive/Clients/ObservableIssuesLabelsClient.cs
View File

@@ -33,13 +33,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
public IObservable<Label> GetAllForIssue(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Label> GetAllForIssue(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAllForIssue(owner, name, number, ApiOptions.None);
return GetAllForIssue(owner, name, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -49,10 +49,10 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#list-labels-on-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
public IObservable<Label> GetAllForIssue(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Label> GetAllForIssue(long repositoryId, int issueNumber)
{
return GetAllForIssue(repositoryId, number, ApiOptions.None);
return GetAllForIssue(repositoryId, issueNumber, ApiOptions.None);
}
/// <summary>
@@ -63,15 +63,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Label> GetAllForIssue(string owner, string name, int number, ApiOptions options)
public IObservable<Label> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(owner, name, number), options);
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(owner, name, issueNumber), options);
}
/// <summary>
@@ -81,13 +81,13 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#list-labels-on-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Label> GetAllForIssue(long repositoryId, int number, ApiOptions options)
public IObservable<Label> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(repositoryId, number), options);
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.IssueLabels(repositoryId, issueNumber), options);
}
/// <summary>
@@ -159,13 +159,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
public IObservable<Label> GetAllForMilestone(string owner, string name, int number)
/// <param name="milestoneNumber">The number of the milestone</param>
public IObservable<Label> GetAllForMilestone(string owner, string name, int milestoneNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAllForMilestone(owner, name, number, ApiOptions.None);
return GetAllForMilestone(owner, name, milestoneNumber, ApiOptions.None);
}
/// <summary>
@@ -175,10 +175,10 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#get-labels-for-every-issue-in-a-milestone">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the milestone</param>
public IObservable<Label> GetAllForMilestone(long repositoryId, int number)
/// <param name="milestoneNumber">The number of the milestone</param>
public IObservable<Label> GetAllForMilestone(long repositoryId, int milestoneNumber)
{
return GetAllForMilestone(repositoryId, number, ApiOptions.None);
return GetAllForMilestone(repositoryId, milestoneNumber, ApiOptions.None);
}
/// <summary>
@@ -189,15 +189,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <param name="milestoneNumber">The number of the milestone</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Label> GetAllForMilestone(string owner, string name, int number, ApiOptions options)
public IObservable<Label> GetAllForMilestone(string owner, string name, int milestoneNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(owner, name, number), options);
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(owner, name, milestoneNumber), options);
}
/// <summary>
@@ -207,13 +207,13 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#get-labels-for-every-issue-in-a-milestone">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the milestone</param>
/// <param name="milestoneNumber">The number of the milestone</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Label> GetAllForMilestone(long repositoryId, int number, ApiOptions options)
public IObservable<Label> GetAllForMilestone(long repositoryId, int milestoneNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(repositoryId, number), options);
return _connection.GetAndFlattenAllPages<Label>(ApiUrls.MilestoneLabels(repositoryId, milestoneNumber), options);
}
/// <summary>
@@ -360,15 +360,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to add</param>
public IObservable<Label> AddToIssue(string owner, string name, int number, string[] labels)
public IObservable<Label> AddToIssue(string owner, string name, int issueNumber, string[] labels)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(labels, nameof(labels));
return _client.AddToIssue(owner, name, number, labels)
return _client.AddToIssue(owner, name, issueNumber, labels)
.ToObservable()
.SelectMany(x => x); // HACK: POST is not compatible with GetAndFlattenPages
}
@@ -380,13 +380,13 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#add-labels-to-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to add</param>
public IObservable<Label> AddToIssue(long repositoryId, int number, string[] labels)
public IObservable<Label> AddToIssue(long repositoryId, int issueNumber, string[] labels)
{
Ensure.ArgumentNotNull(labels, nameof(labels));
return _client.AddToIssue(repositoryId, number, labels)
return _client.AddToIssue(repositoryId, issueNumber, labels)
.ToObservable()
.SelectMany(x => x); // HACK: POST is not compatible with GetAndFlattenPages
}
@@ -399,15 +399,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labelName">The name of the label to remove</param>
public IObservable<Label> RemoveFromIssue(string owner, string name, int number, string labelName)
public IObservable<Label> RemoveFromIssue(string owner, string name, int issueNumber, string labelName)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
return _client.RemoveFromIssue(owner, name, number, labelName)
return _client.RemoveFromIssue(owner, name, issueNumber, labelName)
.ToObservable()
.SelectMany(x => x); // HACK: DELETE is not compatible with GetAndFlattenPages
}
@@ -419,13 +419,13 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#remove-a-label-from-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labelName">The name of the label to remove</param>
public IObservable<Label> RemoveFromIssue(long repositoryId, int number, string labelName)
public IObservable<Label> RemoveFromIssue(long repositoryId, int issueNumber, string labelName)
{
Ensure.ArgumentNotNullOrEmptyString(labelName, nameof(labelName));
return _client.RemoveFromIssue(repositoryId, number, labelName)
return _client.RemoveFromIssue(repositoryId, issueNumber, labelName)
.ToObservable()
.SelectMany(x => x); // HACK: DELETE is not compatible with GetAndFlattenPages
}
@@ -438,15 +438,15 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to set</param>
public IObservable<Label> ReplaceAllForIssue(string owner, string name, int number, string[] labels)
public IObservable<Label> ReplaceAllForIssue(string owner, string name, int issueNumber, string[] labels)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(labels, nameof(labels));
return _client.ReplaceAllForIssue(owner, name, number, labels)
return _client.ReplaceAllForIssue(owner, name, issueNumber, labels)
.ToObservable()
.SelectMany(x => x); // HACK: PUT is not compatible with GetAndFlattenPages
}
@@ -458,13 +458,13 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#replace-all-labels-for-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="labels">The names of the labels to set</param>
public IObservable<Label> ReplaceAllForIssue(long repositoryId, int number, string[] labels)
public IObservable<Label> ReplaceAllForIssue(long repositoryId, int issueNumber, string[] labels)
{
Ensure.ArgumentNotNull(labels, nameof(labels));
return _client.ReplaceAllForIssue(repositoryId, number, labels)
return _client.ReplaceAllForIssue(repositoryId, issueNumber, labels)
.ToObservable()
.SelectMany(x => x); // HACK: PUT is not compatible with GetAndFlattenPages
}
@@ -477,13 +477,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The number of the issue</param>
public IObservable<Unit> RemoveAllFromIssue(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Unit> RemoveAllFromIssue(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.RemoveAllFromIssue(owner, name, number).ToObservable();
return _client.RemoveAllFromIssue(owner, name, issueNumber).ToObservable();
}
/// <summary>
@@ -493,10 +493,10 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/issues/labels/#remove-all-labels-from-an-issue">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the issue</param>
public IObservable<Unit> RemoveAllFromIssue(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Unit> RemoveAllFromIssue(long repositoryId, int issueNumber)
{
return _client.RemoveAllFromIssue(repositoryId, number).ToObservable();
return _client.RemoveAllFromIssue(repositoryId, issueNumber).ToObservable();
}
}
}

24
Octokit.Reactive/Clients/ObservableLockUnlockClient.cs
View File

@@ -24,14 +24,14 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/issues/#lock-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="lockReason">The reason for locking the issue</param>
public IObservable<Unit> Lock(string owner, string name, int number, LockReason? lockReason = null)
public IObservable<Unit> Lock(string owner, string name, int issueNumber, LockReason? lockReason = null)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Lock(owner, name, number, lockReason).ToObservable();
return _client.Lock(owner, name, issueNumber, lockReason).ToObservable();
}
/// <summary>
@@ -39,11 +39,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/issues/#lock-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
/// <param name="issueNumber">The issue number</param>
/// <param name="lockReason">The reason for locking the issue</param>
public IObservable<Unit> Lock(long repositoryId, int number, LockReason? lockReason = null)
public IObservable<Unit> Lock(long repositoryId, int issueNumber, LockReason? lockReason = null)
{
return _client.Lock(repositoryId, number, lockReason).ToObservable();
return _client.Lock(repositoryId, issueNumber, lockReason).ToObservable();
}
/// <summary>
@@ -52,13 +52,13 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/issues/#unlock-an-issue</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<Unit> Unlock(string owner, string name, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Unit> Unlock(string owner, string name, int issueNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Unlock(owner, name, number).ToObservable();
return _client.Unlock(owner, name, issueNumber).ToObservable();
}
/// <summary>
@@ -66,10 +66,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/issues/#unlock-an-issue</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The issue number</param>
public IObservable<Unit> Unlock(long repositoryId, int number)
/// <param name="issueNumber">The issue number</param>
public IObservable<Unit> Unlock(long repositoryId, int issueNumber)
{
return _client.Unlock(repositoryId, number).ToObservable();
return _client.Unlock(repositoryId, issueNumber).ToObservable();
}
}
}

32
Octokit.Reactive/Clients/ObservableMilestonesClient.cs
View File

@@ -31,12 +31,12 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/milestones/#get-a-single-milestone
/// </remarks>
/// <returns></returns>
public IObservable<Milestone> Get(string owner, string name, int number)
public IObservable<Milestone> Get(string owner, string name, int milestoneNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, milestoneNumber).ToObservable();
}
/// <summary>
@@ -46,9 +46,9 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/issues/milestones/#get-a-single-milestone
/// </remarks>
/// <returns></returns>
public IObservable<Milestone> Get(long repositoryId, int number)
public IObservable<Milestone> Get(long repositoryId, int milestoneNumber)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, milestoneNumber).ToObservable();
}
/// <summary>
@@ -232,17 +232,17 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/milestones/#update-a-milestone</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <param name="milestoneUpdate">An <see cref="MilestoneUpdate"/> instance describing the changes to make to the Milestone
/// </param>
/// <returns></returns>
public IObservable<Milestone> Update(string owner, string name, int number, MilestoneUpdate milestoneUpdate)
public IObservable<Milestone> Update(string owner, string name, int milestoneNumber, MilestoneUpdate milestoneUpdate)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(milestoneUpdate, nameof(milestoneUpdate));
return _client.Update(owner, name, number, milestoneUpdate).ToObservable();
return _client.Update(owner, name, milestoneNumber, milestoneUpdate).ToObservable();
}
/// <summary>
@@ -251,15 +251,15 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/milestones/#update-a-milestone</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <param name="milestoneUpdate">An <see cref="MilestoneUpdate"/> instance describing the changes to make to the Milestone
/// </param>
/// <returns></returns>
public IObservable<Milestone> Update(long repositoryId, int number, MilestoneUpdate milestoneUpdate)
public IObservable<Milestone> Update(long repositoryId, int milestoneNumber, MilestoneUpdate milestoneUpdate)
{
Ensure.ArgumentNotNull(milestoneUpdate, nameof(milestoneUpdate));
return _client.Update(repositoryId, number, milestoneUpdate).ToObservable();
return _client.Update(repositoryId, milestoneNumber, milestoneUpdate).ToObservable();
}
/// <summary>
@@ -269,14 +269,14 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/milestones/#delete-a-milestone</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, int number)
public IObservable<Unit> Delete(string owner, string name, int milestoneNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number).ToObservable();
return _client.Delete(owner, name, milestoneNumber).ToObservable();
}
/// <summary>
@@ -285,11 +285,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/milestones/#delete-a-milestone</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The milestone number</param>
/// <param name="milestoneNumber">The Milestone number</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, int number)
public IObservable<Unit> Delete(long repositoryId, int milestoneNumber)
{
return _client.Delete(repositoryId, number).ToObservable();
return _client.Delete(repositoryId, milestoneNumber).ToObservable();
}
}
}

30
Octokit.Reactive/Clients/ObservableNotificationsClient.cs
View File

@@ -263,54 +263,54 @@ namespace Octokit.Reactive
/// <summary>
/// Retrives a single <see cref="Notification"/> by Id.
/// </summary>
/// <param name="id">The Id of the notification to retrieve.</param>
/// <param name="notificationId">The Id of the notification to retrieve.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#view-a-single-thread</remarks>
public IObservable<Notification> Get(int id)
public IObservable<Notification> Get(int notificationId)
{
return _notificationsClient.Get(id).ToObservable();
return _notificationsClient.Get(notificationId).ToObservable();
}
/// <summary>
/// Marks a single notification as read.
/// </summary>
/// <param name="id">The id of the notification.</param>
/// <param name="notificationId">The id of the notification.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#mark-a-thread-as-read</remarks>
public IObservable<Unit> MarkAsRead(int id)
public IObservable<Unit> MarkAsRead(int notificationId)
{
return _notificationsClient.MarkAsRead(id).ToObservable();
return _notificationsClient.MarkAsRead(notificationId).ToObservable();
}
/// <summary>
/// Retrives a <see cref="ThreadSubscription"/> for the provided thread id.
/// </summary>
/// <param name="id">The Id of the thread to retrieve subscription status.</param>
/// <param name="threadId">The Id of the thread to retrieve subscription status.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#get-a-thread-subscription</remarks>
public IObservable<ThreadSubscription> GetThreadSubscription(int id)
public IObservable<ThreadSubscription> GetThreadSubscription(int threadId)
{
return _notificationsClient.GetThreadSubscription(id).ToObservable();
return _notificationsClient.GetThreadSubscription(threadId).ToObservable();
}
/// <summary>
/// Sets the authenticated user's subscription settings for a given thread.
/// </summary>
/// <param name="id">The Id of the thread to update.</param>
/// <param name="threadId">The Id of the thread to update.</param>
/// <param name="threadSubscription">The subscription parameters to set.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#set-a-thread-subscription</remarks>
public IObservable<ThreadSubscription> SetThreadSubscription(int id, NewThreadSubscription threadSubscription)
public IObservable<ThreadSubscription> SetThreadSubscription(int threadId, NewThreadSubscription threadSubscription)
{
Ensure.ArgumentNotNull(threadSubscription, nameof(threadSubscription));
return _notificationsClient.SetThreadSubscription(id, threadSubscription).ToObservable();
return _notificationsClient.SetThreadSubscription(threadId, threadSubscription).ToObservable();
}
/// <summary>
/// Deletes the authenticated user's subscription to a given thread.
/// </summary>
/// <param name="id">The Id of the thread to delete subscription from.</param>
/// <param name="threadId">The Id of the thread to delete subscription from.</param>
/// <remarks>http://developer.github.com/v3/activity/notifications/#delete-a-thread-subscription</remarks>
public IObservable<Unit> DeleteThreadSubscription(int id)
public IObservable<Unit> DeleteThreadSubscription(int threadId)
{
return _notificationsClient.DeleteThreadSubscription(id).ToObservable();
return _notificationsClient.DeleteThreadSubscription(threadId).ToObservable();
}
}
}

24
Octokit.Reactive/Clients/ObservableProjectColumnsClient.cs
View File

@@ -53,10 +53,10 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#get-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
public IObservable<ProjectColumn> Get(int id)
/// <param name="columnId">The id of the column</param>
public IObservable<ProjectColumn> Get(int columnId)
{
return _client.Get(id).ToObservable();
return _client.Get(columnId).ToObservable();
}
/// <summary>
@@ -80,13 +80,13 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#update-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
/// <param name="columnId">The id of the column</param>
/// <param name="projectColumnUpdate">New values to update the column with</param>
public IObservable<ProjectColumn> Update(int id, ProjectColumnUpdate projectColumnUpdate)
public IObservable<ProjectColumn> Update(int columnId, ProjectColumnUpdate projectColumnUpdate)
{
Ensure.ArgumentNotNull(projectColumnUpdate, nameof(projectColumnUpdate));
return _client.Update(id, projectColumnUpdate).ToObservable();
return _client.Update(columnId, projectColumnUpdate).ToObservable();
}
/// <summary>
@@ -95,10 +95,10 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/projects/columns/#delete-a-project-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
public IObservable<bool> Delete(int id)
/// <param name="columnId">The id of the column</param>
public IObservable<bool> Delete(int columnId)
{
return _client.Delete(id).ToObservable();
return _client.Delete(columnId).ToObservable();
}
/// <summary>
@@ -107,13 +107,13 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#move-a-column">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The id of the column</param>
/// <param name="columnId">The id of the column</param>
/// <param name="position">The position to move the column</param>
public IObservable<bool> Move(int id, ProjectColumnMove position)
public IObservable<bool> Move(int columnId, ProjectColumnMove position)
{
Ensure.ArgumentNotNull(position, nameof(position));
return _client.Move(id, position).ToObservable();
return _client.Move(columnId, position).ToObservable();
}
}
}

12
Octokit.Reactive/Clients/ObservableProjectsClient.cs
View File

@@ -270,13 +270,13 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#update-a-project">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The Id of the project</param>
/// <param name="projectId">The Id of the project</param>
/// <param name="projectUpdate">The modified project</param>
public IObservable<Project> Update(int id, ProjectUpdate projectUpdate)
public IObservable<Project> Update(int projectId, ProjectUpdate projectUpdate)
{
Ensure.ArgumentNotNull(projectUpdate, nameof(projectUpdate));
return _client.Update(id, projectUpdate).ToObservable();
return _client.Update(projectId, projectUpdate).ToObservable();
}
/// <summary>
@@ -285,10 +285,10 @@ namespace Octokit.Reactive
/// <remarks>
/// See the <a href="https://developer.github.com/v3/repos/projects/#delete-a-project">API documentation</a> for more information.
/// </remarks>
/// <param name="id">The Id of the project</param>
public IObservable<bool> Delete(int id)
/// <param name="projectId">The Id of the project</param>
public IObservable<bool> Delete(int projectId)
{
return _client.Delete(id).ToObservable();
return _client.Delete(projectId).ToObservable();
}
/// <summary>

48
Octokit.Reactive/Clients/ObservablePullRequestReviewCommentsClient.cs
View File

@@ -30,13 +30,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestReviewComment> GetAll(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestReviewComment> GetAll(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, pullRequestNumber, ApiOptions.None);
}
/// <summary>
@@ -44,10 +44,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestReviewComment> GetAll(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestReviewComment> GetAll(long repositoryId, int pullRequestNumber)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, pullRequestNumber, ApiOptions.None);
}
/// <summary>
@@ -56,15 +56,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReviewComment> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<PullRequestReviewComment> GetAll(string owner, string name, int pullRequestNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(owner, name, number), null, options);
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(owner, name, pullRequestNumber), null, options);
}
/// <summary>
@@ -72,13 +72,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReviewComment> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<PullRequestReviewComment> GetAll(long repositoryId, int pullRequestNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, number), options);
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, pullRequestNumber), options);
}
/// <summary>
@@ -228,15 +228,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
public IObservable<PullRequestReviewComment> Create(string owner, string name, int number, PullRequestReviewCommentCreate comment)
public IObservable<PullRequestReviewComment> Create(string owner, string name, int pullRequestNumber, PullRequestReviewCommentCreate comment)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.Create(owner, name, number, comment).ToObservable();
return _client.Create(owner, name, pullRequestNumber, comment).ToObservable();
}
/// <summary>
@@ -244,13 +244,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
public IObservable<PullRequestReviewComment> Create(long repositoryId, int number, PullRequestReviewCommentCreate comment)
public IObservable<PullRequestReviewComment> Create(long repositoryId, int pullRequestNumber, PullRequestReviewCommentCreate comment)
{
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.Create(repositoryId, number, comment).ToObservable();
return _client.Create(repositoryId, pullRequestNumber, comment).ToObservable();
}
/// <summary>
@@ -259,15 +259,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
public IObservable<PullRequestReviewComment> CreateReply(string owner, string name, int number, PullRequestReviewCommentReplyCreate comment)
public IObservable<PullRequestReviewComment> CreateReply(string owner, string name, int pullRequestNumber, PullRequestReviewCommentReplyCreate comment)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.CreateReply(owner, name, number, comment).ToObservable();
return _client.CreateReply(owner, name, pullRequestNumber, comment).ToObservable();
}
/// <summary>
@@ -275,13 +275,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#create-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="comment">The comment</param>
public IObservable<PullRequestReviewComment> CreateReply(long repositoryId, int number, PullRequestReviewCommentReplyCreate comment)
public IObservable<PullRequestReviewComment> CreateReply(long repositoryId, int pullRequestNumber, PullRequestReviewCommentReplyCreate comment)
{
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.CreateReply(repositoryId, number, comment).ToObservable();
return _client.CreateReply(repositoryId, pullRequestNumber, comment).ToObservable();
}
/// <summary>

36
Octokit.Reactive/Clients/ObservablePullRequestReviewRequestsClient.cs
View File

@@ -24,13 +24,13 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#list-review-requests</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<RequestedReviews> Get(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<RequestedReviews> Get(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -38,10 +38,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#list-review-requests</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<RequestedReviews> Get(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<RequestedReviews> Get(long repositoryId, int pullRequestNumber)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -50,15 +50,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#create-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of user will be requested for review</param>
public IObservable<PullRequest> Create(string owner, string name, int number, PullRequestReviewRequest users)
public IObservable<PullRequest> Create(string owner, string name, int pullRequestNumber, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(users, nameof(users));
return _client.Create(owner, name, number, users).ToObservable();
return _client.Create(owner, name, pullRequestNumber, users).ToObservable();
}
/// <summary>
@@ -66,13 +66,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#create-a-review-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of user will be requested for review</param>
public IObservable<PullRequest> Create(long repositoryId, int number, PullRequestReviewRequest users)
public IObservable<PullRequest> Create(long repositoryId, int pullRequestNumber, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNull(users, nameof(users));
return _client.Create(repositoryId, number, users).ToObservable();
return _client.Create(repositoryId, pullRequestNumber, users).ToObservable();
}
/// <summary>
@@ -81,15 +81,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#delete-a-review-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of users that will be not longer requested for review</param>
public IObservable<Unit> Delete(string owner, string name, int number, PullRequestReviewRequest users)
public IObservable<Unit> Delete(string owner, string name, int pullRequestNumber, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(users, nameof(users));
return _client.Delete(owner, name, number, users).ToObservable();
return _client.Delete(owner, name, pullRequestNumber, users).ToObservable();
}
/// <summary>
@@ -97,13 +97,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/review_requests/#delete-a-review-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="users">List of logins of users that will be not longer requested for review</param>
public IObservable<Unit> Delete(long repositoryId, int number, PullRequestReviewRequest users)
public IObservable<Unit> Delete(long repositoryId, int pullRequestNumber, PullRequestReviewRequest users)
{
Ensure.ArgumentNotNull(users, nameof(users));
return _client.Delete(repositoryId, number, users).ToObservable();
return _client.Delete(repositoryId, pullRequestNumber, users).ToObservable();
}
}
}

108
Octokit.Reactive/Clients/ObservablePullRequestReviewsClient.cs
View File

@@ -30,14 +30,14 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="review">The review</param>
public IObservable<PullRequestReview> Create(string owner, string name, int number, PullRequestReviewCreate review)
public IObservable<PullRequestReview> Create(string owner, string name, int pullRequestNumber, PullRequestReviewCreate review)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(review, nameof(review));
return _client.Create(owner, name, number, review).ToObservable();
return _client.Create(owner, name, pullRequestNumber, review).ToObservable();
}
/// <summary>
@@ -45,13 +45,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The Pull Request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="review">The review</param>
public IObservable<PullRequestReview> Create(long repositoryId, int number, PullRequestReviewCreate review)
public IObservable<PullRequestReview> Create(long repositoryId, int pullRequestNumber, PullRequestReviewCreate review)
{
Ensure.ArgumentNotNull(review, nameof(review));
return _client.Create(repositoryId, number, review).ToObservable();
return _client.Create(repositoryId, pullRequestNumber, review).ToObservable();
}
/// <summary>
@@ -60,14 +60,14 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#delete-a-pending-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<Unit> Delete(string owner, string name, int number, long reviewId)
public IObservable<Unit> Delete(string owner, string name, int pullRequestNumber, long reviewId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number, reviewId).ToObservable();
return _client.Delete(owner, name, pullRequestNumber, reviewId).ToObservable();
}
/// <summary>
@@ -75,11 +75,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#delete-a-pending-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<Unit> Delete(long repositoryId, int number, long reviewId)
public IObservable<Unit> Delete(long repositoryId, int pullRequestNumber, long reviewId)
{
return _client.Delete(repositoryId, number, reviewId).ToObservable();
return _client.Delete(repositoryId, pullRequestNumber, reviewId).ToObservable();
}
/// <summary>
@@ -88,16 +88,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#dismiss-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="dismissMessage">The message indicating why the review was dismissed</param>
public IObservable<PullRequestReview> Dismiss(string owner, string name, int number, long reviewId, PullRequestReviewDismiss dismissMessage)
public IObservable<PullRequestReview> Dismiss(string owner, string name, int pullRequestNumber, long reviewId, PullRequestReviewDismiss dismissMessage)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(dismissMessage, nameof(dismissMessage));
return _client.Dismiss(owner, name, number, reviewId, dismissMessage).ToObservable();
return _client.Dismiss(owner, name, pullRequestNumber, reviewId, dismissMessage).ToObservable();
}
/// <summary>
@@ -105,14 +105,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#dismiss-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="dismissMessage">The message indicating why the review was dismissed</param>
public IObservable<PullRequestReview> Dismiss(long repositoryId, int number, long reviewId, PullRequestReviewDismiss dismissMessage)
public IObservable<PullRequestReview> Dismiss(long repositoryId, int pullRequestNumber, long reviewId, PullRequestReviewDismiss dismissMessage)
{
Ensure.ArgumentNotNull(dismissMessage, nameof(dismissMessage));
return GetAll(repositoryId, number);
return GetAll(repositoryId, pullRequestNumber);
}
/// <summary>
@@ -121,13 +121,13 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestReview> GetAll(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestReview> GetAll(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, pullRequestNumber, ApiOptions.None);
}
/// <summary>
@@ -135,10 +135,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestReview> GetAll(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestReview> GetAll(long repositoryId, int pullRequestNumber)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, pullRequestNumber, ApiOptions.None);
}
/// <summary>
@@ -147,15 +147,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReview> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<PullRequestReview> GetAll(string owner, string name, int pullRequestNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReview>(ApiUrls.PullRequestReviews(owner, name, number), null, null, options);
return _connection.GetAndFlattenAllPages<PullRequestReview>(ApiUrls.PullRequestReviews(owner, name, pullRequestNumber), null, null, options);
}
/// <summary>
@@ -163,13 +163,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#list-reviews-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReview> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<PullRequestReview> GetAll(long repositoryId, int pullRequestNumber, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReview>(ApiUrls.PullRequestReviews(repositoryId, number), null, null, options);
return _connection.GetAndFlattenAllPages<PullRequestReview>(ApiUrls.PullRequestReviews(repositoryId, pullRequestNumber), null, null, options);
}
/// <summary>
@@ -178,14 +178,14 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<PullRequestReview> Get(string owner, string name, int number, long reviewId)
public IObservable<PullRequestReview> Get(string owner, string name, int pullRequestNumber, long reviewId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number, reviewId).ToObservable();
return _client.Get(owner, name, pullRequestNumber, reviewId).ToObservable();
}
/// <summary>
@@ -193,11 +193,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<PullRequestReview> Get(long repositoryId, int number, long reviewId)
public IObservable<PullRequestReview> Get(long repositoryId, int pullRequestNumber, long reviewId)
{
return _client.Get(repositoryId, number, reviewId).ToObservable();
return _client.Get(repositoryId, pullRequestNumber, reviewId).ToObservable();
}
/// <summary>
@@ -206,16 +206,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#submit-a-pull-request-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="submitMessage">The message and event being submitted for the review</param>
public IObservable<PullRequestReview> Submit(string owner, string name, int number, long reviewId, PullRequestReviewSubmit submitMessage)
public IObservable<PullRequestReview> Submit(string owner, string name, int pullRequestNumber, long reviewId, PullRequestReviewSubmit submitMessage)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(submitMessage, nameof(submitMessage));
return _client.Submit(owner, name, number, reviewId, submitMessage).ToObservable();
return _client.Submit(owner, name, pullRequestNumber, reviewId, submitMessage).ToObservable();
}
/// <summary>
@@ -223,14 +223,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#submit-a-pull-request-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="submitMessage">The message and event being submitted for the review</param>
public IObservable<PullRequestReview> Submit(long repositoryId, int number, long reviewId, PullRequestReviewSubmit submitMessage)
public IObservable<PullRequestReview> Submit(long repositoryId, int pullRequestNumber, long reviewId, PullRequestReviewSubmit submitMessage)
{
Ensure.ArgumentNotNull(submitMessage, nameof(submitMessage));
return _client.Submit(repositoryId, number, reviewId, submitMessage).ToObservable();
return _client.Submit(repositoryId, pullRequestNumber, reviewId, submitMessage).ToObservable();
}
/// <summary>
@@ -239,11 +239,11 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int number, long reviewId)
public IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int pullRequestNumber, long reviewId)
{
return GetAllComments(owner, name, number, reviewId, ApiOptions.None);
return GetAllComments(owner, name, pullRequestNumber, reviewId, ApiOptions.None);
}
/// <summary>
@@ -251,11 +251,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
public IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int number, long reviewId)
public IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int pullRequestNumber, long reviewId)
{
return GetAllComments(repositoryId, number, reviewId, ApiOptions.None);
return GetAllComments(repositoryId, pullRequestNumber, reviewId, ApiOptions.None);
}
/// <summary>
@@ -264,16 +264,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int number, long reviewId, ApiOptions options)
public IObservable<PullRequestReviewComment> GetAllComments(string owner, string name, int pullRequestNumber, long reviewId, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(owner, name, number, reviewId), options);
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(owner, name, pullRequestNumber, reviewId), options);
}
/// <summary>
@@ -281,14 +281,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/reviews/#get-comments-for-a-single-review</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="reviewId">The pull request review number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int number, long reviewId, ApiOptions options)
public IObservable<PullRequestReviewComment> GetAllComments(long repositoryId, int pullRequestNumber, long reviewId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, number, reviewId), options);
return _connection.GetAndFlattenAllPages<PullRequestReviewComment>(ApiUrls.PullRequestReviewComments(repositoryId, pullRequestNumber, reviewId), options);
}
}
}

82
Octokit.Reactive/Clients/ObservablePullRequestsClient.cs
View File

@@ -53,12 +53,12 @@ namespace Octokit.Reactive
/// <remarks>
/// http://developer.github.com/v3/pulls/#get-a-single-pull-request
/// </remarks>
public IObservable<PullRequest> Get(string owner, string name, int number)
public IObservable<PullRequest> Get(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -68,10 +68,10 @@ namespace Octokit.Reactive
/// http://developer.github.com/v3/pulls/#get-a-single-pull-request
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The number of the pull request</param>
public IObservable<PullRequest> Get(long repositoryId, int number)
/// <param name="pullRequestNumber">The number of the pull request</param>
public IObservable<PullRequest> Get(long repositoryId, int pullRequestNumber)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -242,16 +242,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#update-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The PullRequest number</param>
/// <param name="pullRequestNumber">The PullRequest number</param>
/// <param name="pullRequestUpdate">An <see cref="PullRequestUpdate"/> instance describing the changes to make to the PullRequest
/// </param>
public IObservable<PullRequest> Update(string owner, string name, int number, PullRequestUpdate pullRequestUpdate)
public IObservable<PullRequest> Update(string owner, string name, int pullRequestNumber, PullRequestUpdate pullRequestUpdate)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(pullRequestUpdate, nameof(pullRequestUpdate));
return _client.Update(owner, name, number, pullRequestUpdate).ToObservable();
return _client.Update(owner, name, pullRequestNumber, pullRequestUpdate).ToObservable();
}
/// <summary>
@@ -259,14 +259,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#update-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The PullRequest number</param>
/// <param name="pullRequestNumber">The PullRequest number</param>
/// <param name="pullRequestUpdate">An <see cref="PullRequestUpdate"/> instance describing the changes to make to the PullRequest
/// </param>
public IObservable<PullRequest> Update(long repositoryId, int number, PullRequestUpdate pullRequestUpdate)
public IObservable<PullRequest> Update(long repositoryId, int pullRequestNumber, PullRequestUpdate pullRequestUpdate)
{
Ensure.ArgumentNotNull(pullRequestUpdate, nameof(pullRequestUpdate));
return _client.Update(repositoryId, number, pullRequestUpdate).ToObservable();
return _client.Update(repositoryId, pullRequestNumber, pullRequestUpdate).ToObservable();
}
/// <summary>
@@ -275,15 +275,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#merge-a-pull-request-merge-buttontrade</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="mergePullRequest">A <see cref="MergePullRequest"/> instance describing a pull request merge</param>
public IObservable<PullRequestMerge> Merge(string owner, string name, int number, MergePullRequest mergePullRequest)
public IObservable<PullRequestMerge> Merge(string owner, string name, int pullRequestNumber, MergePullRequest mergePullRequest)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(mergePullRequest, nameof(mergePullRequest));
return _client.Merge(owner, name, number, mergePullRequest).ToObservable();
return _client.Merge(owner, name, pullRequestNumber, mergePullRequest).ToObservable();
}
/// <summary>
@@ -291,13 +291,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#merge-a-pull-request-merge-buttontrade</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="mergePullRequest">A <see cref="MergePullRequest"/> instance describing a pull request merge</param>
public IObservable<PullRequestMerge> Merge(long repositoryId, int number, MergePullRequest mergePullRequest)
public IObservable<PullRequestMerge> Merge(long repositoryId, int pullRequestNumber, MergePullRequest mergePullRequest)
{
Ensure.ArgumentNotNull(mergePullRequest, nameof(mergePullRequest));
return _client.Merge(repositoryId, number, mergePullRequest).ToObservable();
return _client.Merge(repositoryId, pullRequestNumber, mergePullRequest).ToObservable();
}
/// <summary>
@@ -306,13 +306,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<bool> Merged(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<bool> Merged(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Merged(owner, name, number).ToObservable();
return _client.Merged(owner, name, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -320,10 +320,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<bool> Merged(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<bool> Merged(long repositoryId, int pullRequestNumber)
{
return _client.Merged(repositoryId, number).ToObservable();
return _client.Merged(repositoryId, pullRequestNumber).ToObservable();
}
/// <summary>
@@ -332,13 +332,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/#list-commits-on-a-pull-request</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestCommit> Commits(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestCommit> Commits(string owner, string name, int pullRequestNumber)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _connection.GetAndFlattenAllPages<PullRequestCommit>(ApiUrls.PullRequestCommits(owner, name, number));
return _connection.GetAndFlattenAllPages<PullRequestCommit>(ApiUrls.PullRequestCommits(owner, name, pullRequestNumber));
}
/// <summary>
@@ -346,10 +346,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/#list-commits-on-a-pull-request</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestCommit> Commits(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestCommit> Commits(long repositoryId, int pullRequestNumber)
{
return _connection.GetAndFlattenAllPages<PullRequestCommit>(ApiUrls.PullRequestCommits(repositoryId, number));
return _connection.GetAndFlattenAllPages<PullRequestCommit>(ApiUrls.PullRequestCommits(repositoryId, pullRequestNumber));
}
/// <summary>
@@ -358,14 +358,14 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestFile> Files(string owner, string name, int number, ApiOptions options)
public IObservable<PullRequestFile> Files(string owner, string name, int pullRequestNumber, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _connection.GetAndFlattenAllPages<PullRequestFile>(ApiUrls.PullRequestFiles(owner, name, number), options);
return _connection.GetAndFlattenAllPages<PullRequestFile>(ApiUrls.PullRequestFiles(owner, name, pullRequestNumber), options);
}
/// <summary>
@@ -374,10 +374,10 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestFile> Files(string owner, string name, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestFile> Files(string owner, string name, int pullRequestNumber)
{
return Files(owner, name, number, ApiOptions.None);
return Files(owner, name, pullRequestNumber, ApiOptions.None);
}
/// <summary>
@@ -385,11 +385,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
/// <param name="pullRequestNumber">The pull request number</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<PullRequestFile> Files(long repositoryId, int number, ApiOptions options)
public IObservable<PullRequestFile> Files(long repositoryId, int pullRequestNumber, ApiOptions options)
{
return _connection.GetAndFlattenAllPages<PullRequestFile>(ApiUrls.PullRequestFiles(repositoryId, number), options);
return _connection.GetAndFlattenAllPages<PullRequestFile>(ApiUrls.PullRequestFiles(repositoryId, pullRequestNumber), options);
}
/// <summary>
@@ -397,10 +397,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/pulls/#list-pull-requests-files</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request number</param>
public IObservable<PullRequestFile> Files(long repositoryId, int number)
/// <param name="pullRequestNumber">The pull request number</param>
public IObservable<PullRequestFile> Files(long repositoryId, int pullRequestNumber)
{
return Files(repositoryId, number, ApiOptions.None);
return Files(repositoryId, pullRequestNumber, ApiOptions.None);
}
}
}

12
Octokit.Reactive/Clients/ObservableReleasesClient.cs
View File

@@ -489,13 +489,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The repository's owner</param>
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the <see cref="ReleaseAsset"/>.</param>
public IObservable<Unit> DeleteAsset(string owner, string name, int id)
/// <param name="assetId">The id of the <see cref="ReleaseAsset"/>.</param>
public IObservable<Unit> DeleteAsset(string owner, string name, int assetId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.DeleteAsset(owner, name, id).ToObservable();
return _client.DeleteAsset(owner, name, assetId).ToObservable();
}
/// <summary>
@@ -505,10 +505,10 @@ namespace Octokit.Reactive
/// See the <a href="http://developer.github.com/v3/repos/releases/#delete-a-release-asset">API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the <see cref="ReleaseAsset"/>.</param>
public IObservable<Unit> DeleteAsset(long repositoryId, int id)
/// <param name="assetId">The id of the <see cref="ReleaseAsset"/>.</param>
public IObservable<Unit> DeleteAsset(long repositoryId, int assetId)
{
return _client.DeleteAsset(repositoryId, id).ToObservable();
return _client.DeleteAsset(repositoryId, assetId).ToObservable();
}
}
}

26
Octokit.Reactive/Clients/ObservableRepositoryDeployKeysClient.cs
View File

@@ -32,13 +32,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository.</param>
/// <param name="name">The name of the repository.</param>
/// <param name="number">The id of the deploy key.</param>
public IObservable<DeployKey> Get(string owner, string name, int number)
/// <param name="deployKeyId">The id of the deploy key.</param>
public IObservable<DeployKey> Get(string owner, string name, int deployKeyId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, deployKeyId).ToObservable();
}
/// <summary>
@@ -48,10 +48,10 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/keys/#get"> API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository.</param>
/// <param name="number">The id of the deploy key.</param>
public IObservable<DeployKey> Get(long repositoryId, int number)
/// <param name="deployKeyId">The id of the deploy key.</param>
public IObservable<DeployKey> Get(long repositoryId, int deployKeyId)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, deployKeyId).ToObservable();
}
/// <summary>
@@ -170,13 +170,13 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="owner">The owner of the repository.</param>
/// <param name="name">The name of the repository.</param>
/// <param name="number">The id of the deploy key to delete.</param>
public IObservable<Unit> Delete(string owner, string name, int number)
/// <param name="deployKeyId">The id of the deploy key to delete.</param>
public IObservable<Unit> Delete(string owner, string name, int deployKeyId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number).ToObservable();
return _client.Delete(owner, name, deployKeyId).ToObservable();
}
/// <summary>
@@ -186,10 +186,10 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/keys/#delete"> API documentation</a> for more information.
/// </remarks>
/// <param name="repositoryId">The Id of the repository.</param>
/// <param name="number">The id of the deploy key to delete.</param>
public IObservable<Unit> Delete(long repositoryId, int number)
/// <param name="deployKeyId">The id of the deploy key to delete.</param>
public IObservable<Unit> Delete(long repositoryId, int deployKeyId)
{
return _client.Delete(repositoryId, number).ToObservable();
return _client.Delete(repositoryId, deployKeyId).ToObservable();
}
}
}
}