mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-04 19:26:51 +00:00
[FIX]: reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs. (#2948)
* reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs. * updates interfaces and implementations for id naming * updates reactive to match sync SDKs
This commit is contained in:
@@ -107,16 +107,16 @@ namespace Octokit.Reactive
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="owner">The owner of the repository</param>
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number);
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
/// </summary>
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="repositoryId">The Id of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number);
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
@@ -124,18 +124,18 @@ namespace Octokit.Reactive
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="owner">The owner of the repository</param>
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="options">Options for changing the API response</param>
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, ApiOptions options);
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, ApiOptions options);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
/// </summary>
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="repositoryId">The Id of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="options">Options for changing the API response</param>
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, ApiOptions options);
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, ApiOptions options);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
@@ -143,18 +143,18 @@ namespace Octokit.Reactive
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="owner">The owner of the repository</param>
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request);
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
/// </summary>
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="repositoryId">The Id of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request);
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
@@ -162,20 +162,20 @@ namespace Octokit.Reactive
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="owner">The owner of the repository</param>
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
|
||||
/// <param name="options">Options for changing the API response</param>
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int number, IssueCommentRequest request, ApiOptions options);
|
||||
IObservable<IssueComment> GetAllForIssue(string owner, string name, int issueNumber, IssueCommentRequest request, ApiOptions options);
|
||||
|
||||
/// <summary>
|
||||
/// Gets Issue Comments for a specified Issue.
|
||||
/// </summary>
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue</remarks>
|
||||
/// <param name="repositoryId">The Id of the repository</param>
|
||||
/// <param name="number">The issue number</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="request">The sorting <see cref="IssueCommentRequest">parameters</see></param>
|
||||
/// <param name="options">Options for changing the API response</param>
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int number, IssueCommentRequest request, ApiOptions options);
|
||||
IObservable<IssueComment> GetAllForIssue(long repositoryId, int issueNumber, IssueCommentRequest request, ApiOptions options);
|
||||
|
||||
/// <summary>
|
||||
/// Creates a new Issue Comment for a specified Issue.
|
||||
@@ -183,18 +183,18 @@ namespace Octokit.Reactive
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
|
||||
/// <param name="owner">The owner of the repository</param>
|
||||
/// <param name="name">The name of the repository</param>
|
||||
/// <param name="number">The number of the issue</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="newComment">The text of the new comment</param>
|
||||
IObservable<IssueComment> Create(string owner, string name, int number, string newComment);
|
||||
IObservable<IssueComment> Create(string owner, string name, int issueNumber, string newComment);
|
||||
|
||||
/// <summary>
|
||||
/// Creates a new Issue Comment for a specified Issue.
|
||||
/// </summary>
|
||||
/// <remarks>http://developer.github.com/v3/issues/comments/#create-a-comment</remarks>
|
||||
/// <param name="repositoryId">The Id of the repository</param>
|
||||
/// <param name="number">The number of the issue</param>
|
||||
/// <param name="issueNumber">The issue number</param>
|
||||
/// <param name="newComment">The text of the new comment</param>
|
||||
IObservable<IssueComment> Create(long repositoryId, int number, string newComment);
|
||||
IObservable<IssueComment> Create(long repositoryId, int issueNumber, string newComment);
|
||||
|
||||
/// <summary>
|
||||
/// Updates a specified Issue Comment.
|
||||
|
||||
Reference in New Issue
Block a user