zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-05 23:06:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: comment id model update to long instead of int

Browse Source 
* #2927: comment id model update to long instead of int

* #2927: code review fixes (1)

* #2927: code review fixes (2)

* #2927: comment id model update to long instead of int: unit tests fix

* #2927: code review fixes

* Fixed most names of parameters

---------

Co-authored-by: Victor Vorobyev <victor@myrtle-sa.com>
Co-authored-by: Brian C. Arnold <brian.arnold@spiderrock.net>
This commit is contained in:
Victor
2024-06-10 16:12:08 +03:00
committed by GitHub
parent f5ee959c5c
commit 6c43183837
59 changed files with 942 additions and 942 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs
View File

@@ -17,20 +17,20 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
/// <returns></returns>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
/// <summary>
/// Creates a reaction for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
/// <returns></returns>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
/// <summary>
/// List reactions for a specified Commit Comment
@@ -38,9 +38,9 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
IObservable<Reaction> GetAll(string owner, string name, int number);
IObservable<Reaction> GetAll(string owner, string name, long commentId);
/// <summary>
/// List reactions for a specified Commit Comment
@@ -48,29 +48,29 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
IObservable<Reaction> GetAll(long repositoryId, int number);
IObservable<Reaction> GetAll(long repositoryId, long commentId);
/// <summary>
/// List reactions for a specified Commit Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
/// <summary>
/// Deletes a reaction for a specified Commit Comment
@@ -81,7 +81,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
/// <summary>
/// Deletes a reaction for a specified Commit Comment
@@ -91,6 +91,6 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
}
}

6
Octokit.Reactive/Clients/IObservableGistCommentsClient.cs
View File

@@ -15,7 +15,7 @@ namespace Octokit.Reactive
/// <returns>IObservable{GistComment}.</returns>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<GistComment> Get(string gistId, int commentId);
IObservable<GistComment> Get(string gistId, long commentId);
/// <summary>
/// Gets all comments for the gist with the specified id.
@@ -51,7 +51,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The id of the comment</param>
/// <param name="comment">The updated body of the comment</param>
/// <returns>IObservable{GistComment}.</returns>
IObservable<GistComment> Update(string gistId, int commentId, string comment);
IObservable<GistComment> Update(string gistId, long commentId, string comment);
/// <summary>
/// Deletes the comment with the specified gist- and comment id.
@@ -60,6 +60,6 @@ namespace Octokit.Reactive
/// <param name="gistId">The id of the gist</param>
/// <param name="commentId">The id of the comment</param>
/// <returns>IObservable{Unit}.</returns>
IObservable<Unit> Delete(string gistId, int commentId);
IObservable<Unit> Delete(string gistId, long commentId);
}
}

28
Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs
View File

@@ -17,18 +17,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
/// <summary>
/// Creates a reaction for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
/// <summary>
/// List reactions for a specified Issue Comment
@@ -36,8 +36,8 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, long commentId);
/// <summary>
/// List reactions for a specified Issue Comment
@@ -45,26 +45,26 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, long commentId);
/// <summary>
/// List reactions for a specified Issue Comment
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
/// <summary>
/// Deletes a reaction for a specified Issue Comment
@@ -75,7 +75,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
/// <summary>
/// Deletes a reaction for a specified Commit Comment
@@ -85,6 +85,6 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
}
}

24
Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs
View File

@@ -18,20 +18,20 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The issue comment id</param>
/// <param name="commentId">The issue comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueComment> Get(string owner, string name, int id);
IObservable<IssueComment> Get(string owner, string name, long commentId);
/// <summary>
/// Gets a single Issue Comment by id.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The issue comment id</param>
/// <param name="commentId">The issue comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<IssueComment> Get(long repositoryId, int id);
IObservable<IssueComment> Get(long repositoryId, long commentId);
/// <summary>
/// Gets Issue Comments for a repository.
@@ -202,18 +202,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<IssueComment> Update(string owner, string name, int id, string commentUpdate);
IObservable<IssueComment> Update(string owner, string name, long commentId, string commentUpdate);
/// <summary>
/// Updates a specified Issue Comment.
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<IssueComment> Update(long repositoryId, int id, string commentUpdate);
IObservable<IssueComment> Update(long repositoryId, long commentId, string commentUpdate);
/// <summary>
/// Deletes the specified Issue Comment
@@ -221,15 +221,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
IObservable<Unit> Delete(string owner, string name, int id);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(string owner, string name, long commentId);
/// <summary>
/// Deletes the specified Issue Comment
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
IObservable<Unit> Delete(long repositoryId, int id);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(long repositoryId, long commentId);
}
}

4
Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs
View File

@@ -75,7 +75,7 @@ namespace Octokit.Reactive
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int issueNumber, int reactionId);
IObservable<Unit> Delete(string owner, string name, int issueNumber, long reactionId);
/// <summary>
/// Deletes a reaction for a specified Issue
@@ -85,6 +85,6 @@ namespace Octokit.Reactive
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int issueNumber, int reactionId);
IObservable<Unit> Delete(long repositoryId, int issueNumber, long reactionId);
}
}

28
Octokit.Reactive/Clients/IObservablePullRequestReviewCommentReactionsClient.cs
View File

@@ -17,8 +17,8 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(string owner, string name, long commentId);
/// <summary>
/// Get all reactions for a specified Pull Request Review Comment.
@@ -26,26 +26,26 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
/// <summary>
/// Get all reactions for a specified Pull Request Review Comment.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, int number);
/// <param name="commentId">The comment id</param>
IObservable<Reaction> GetAll(long repositoryId, long commentId);
/// <summary>
/// Get all reactions for a specified Pull Request Review Comment.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
/// <summary>
/// Creates a reaction for a specified Pull Request Review Comment.
@@ -53,18 +53,18 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-pull-request-review-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create</param>
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
/// <summary>
/// Creates a reaction for a specified Pull Request Review Comment.
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create</param>
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
/// <summary>
/// Deletes a reaction for a specified Pull Request comment
@@ -75,7 +75,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
/// <summary>
/// Deletes a reaction for a specified Pull Request comment
@@ -85,6 +85,6 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
}
}

24
Octokit.Reactive/Clients/IObservablePullRequestReviewCommentsClient.cs
View File

@@ -121,16 +121,16 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#get-a-single-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
IObservable<PullRequestReviewComment> GetComment(string owner, string name, int number);
/// <param name="commentId">The pull request review comment id</param>
IObservable<PullRequestReviewComment> GetComment(string owner, string name, long commentId);
/// <summary>
/// Gets a single pull request review comment by number.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#get-a-single-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
IObservable<PullRequestReviewComment> GetComment(long repositoryId, int number);
/// <param name="commentId">The pull request review comment id</param>
IObservable<PullRequestReviewComment> GetComment(long repositoryId, long commentId);
/// <summary>
/// Creates a comment on a pull request review.
@@ -176,18 +176,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#edit-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="commentId">The pull request review comment id</param>
/// <param name="comment">The edited comment</param>
IObservable<PullRequestReviewComment> Edit(string owner, string name, int number, PullRequestReviewCommentEdit comment);
IObservable<PullRequestReviewComment> Edit(string owner, string name, long commentId, PullRequestReviewCommentEdit comment);
/// <summary>
/// Edits a comment on a pull request review.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#edit-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="commentId">The pull request review comment id</param>
/// <param name="comment">The edited comment</param>
IObservable<PullRequestReviewComment> Edit(long repositoryId, int number, PullRequestReviewCommentEdit comment);
IObservable<PullRequestReviewComment> Edit(long repositoryId, long commentId, PullRequestReviewCommentEdit comment);
/// <summary>
/// Deletes a comment on a pull request review.
@@ -195,15 +195,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#delete-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
IObservable<Unit> Delete(string owner, string name, int number);
/// <param name="commentId">The pull request review comment id</param>
IObservable<Unit> Delete(string owner, string name, long commentId);
/// <summary>
/// Deletes a comment on a pull request review.
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#delete-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
IObservable<Unit> Delete(long repositoryId, int number);
/// <param name="commentId">The pull request review comment id</param>
IObservable<Unit> Delete(long repositoryId, long commentId);
}
}

24
Octokit.Reactive/Clients/IObservableRepositoryCommentsClient.cs
View File

@@ -18,20 +18,20 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/repos/comments/#get-a-single-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<CommitComment> Get(string owner, string name, int number);
IObservable<CommitComment> Get(string owner, string name, long commentId);
/// <summary>
/// Gets a single Repository Comment by number.
/// </summary>
/// <remarks>http://developer.github.com/v3/repos/comments/#get-a-single-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
Justification = "Method makes a network request")]
IObservable<CommitComment> Get(long repositoryId, int number);
IObservable<CommitComment> Get(long repositoryId, long commentId);
/// <summary>
/// Gets Commit Comments for a repository.
@@ -126,18 +126,18 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/repos/comments/#update-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment number</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<CommitComment> Update(string owner, string name, int number, string commentUpdate);
IObservable<CommitComment> Update(string owner, string name, long commentId, string commentUpdate);
/// <summary>
/// Updates a specified Commit Comment.
/// </summary>
/// <remarks>http://developer.github.com/v3/repos/comments/#update-a-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment number</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
IObservable<CommitComment> Update(long repositoryId, int number, string commentUpdate);
IObservable<CommitComment> Update(long repositoryId, long commentId, string commentUpdate);
/// <summary>
/// Deletes the specified Commit Comment
@@ -145,15 +145,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/repos/comments/#delete-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Unit> Delete(string owner, string name, int number);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(string owner, string name, long commentId);
/// <summary>
/// Deletes the specified Commit Comment
/// </summary>
/// <remarks>http://developer.github.com/v3/repos/comments/#delete-a-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
IObservable<Unit> Delete(long repositoryId, int number);
/// <param name="commentId">The comment id</param>
IObservable<Unit> Delete(long repositoryId, long commentId);
}
}

46
Octokit.Reactive/Clients/ObservableCommitCommentReactionsClient.cs
View File

@@ -30,16 +30,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create</param>
/// <returns></returns>
public IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction)
public IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(owner, name, number, reaction).ToObservable();
return _client.Create(owner, name, commentId, reaction).ToObservable();
}
/// <summary>
@@ -47,14 +47,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
/// <returns></returns>
public IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction)
public IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(repositoryId, number, reaction).ToObservable();
return _client.Create(repositoryId, commentId, reaction).ToObservable();
}
/// <summary>
@@ -63,11 +63,11 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
public IObservable<Reaction> GetAll(string owner, string name, int number)
public IObservable<Reaction> GetAll(string owner, string name, long commentId)
{
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, commentId, ApiOptions.None);
}
/// <summary>
@@ -76,16 +76,16 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
public IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.CommitCommentReactions(owner, name, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.CommitCommentReactions(owner, name, commentId), null, options);
}
/// <summary>
@@ -93,11 +93,11 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <returns></returns>
public IObservable<Reaction> GetAll(long repositoryId, int number)
public IObservable<Reaction> GetAll(long repositoryId, long commentId)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, commentId, ApiOptions.None);
}
/// <summary>
@@ -105,14 +105,14 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
/// <returns></returns>
public IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.CommitCommentReactions(repositoryId, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.CommitCommentReactions(repositoryId, commentId), null, options);
}
/// <summary>
@@ -124,7 +124,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId)
public IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
@@ -139,13 +139,13 @@ namespace Octokit.Reactive
/// <remarks>https://docs.github.com/rest/reactions#delete-a-commit-comment-reaction</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="commentId">The comment id</param>
/// <param name="reactionid">The reaction id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, int commentId, int reactionid)
public IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId)
{
Ensure.ArgumentNotNull(reactionid, nameof(reactionid));
Ensure.ArgumentNotNull(reactionId, nameof(reactionId));
return _client.Delete(repositoryId, commentId, reactionid).ToObservable();
return _client.Delete(repositoryId, commentId, reactionId).ToObservable();
}
}
}

6
Octokit.Reactive/Clients/ObservableGistCommentsClient.cs
View File

@@ -25,7 +25,7 @@ namespace Octokit.Reactive
/// <param name="gistId">The id of the gist</param>
/// <param name="commentId">The id of the comment</param>
/// <returns>IObservable{GistComment}.</returns>
public IObservable<GistComment> Get(string gistId, int commentId)
public IObservable<GistComment> Get(string gistId, long commentId)
{
return _client.Get(gistId, commentId).ToObservable();
}
@@ -80,7 +80,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The id of the comment</param>
/// <param name="comment">The updated body of the comment</param>
/// <returns>IObservable{GistComment}.</returns>
public IObservable<GistComment> Update(string gistId, int commentId, string comment)
public IObservable<GistComment> Update(string gistId, long commentId, string comment)
{
Ensure.ArgumentNotNullOrEmptyString(comment, nameof(comment));
@@ -94,7 +94,7 @@ namespace Octokit.Reactive
/// <param name="gistId">The id of the gist</param>
/// <param name="commentId">The id of the comment</param>
/// <returns>IObservable{Unit}.</returns>
public IObservable<Unit> Delete(string gistId, int commentId)
public IObservable<Unit> Delete(string gistId, long commentId)
{
return _client.Delete(gistId, commentId).ToObservable();
}

40
Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs
View File

@@ -30,15 +30,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
public IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction)
public IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(owner, name, number, reaction).ToObservable();
return _client.Create(owner, name, commentId, reaction).ToObservable();
}
/// <summary>
@@ -46,13 +46,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create </param>
public IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction)
public IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(repositoryId, number, reaction).ToObservable();
return _client.Create(repositoryId, commentId, reaction).ToObservable();
}
/// <summary>
@@ -61,13 +61,13 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
public IObservable<Reaction> GetAll(string owner, string name, int number)
/// <param name="commentId">The comment id</param>
public IObservable<Reaction> GetAll(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, commentId, ApiOptions.None);
}
/// <summary>
@@ -76,15 +76,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueCommentReactions(owner, name, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueCommentReactions(owner, name, commentId), null, options);
}
/// <summary>
@@ -92,10 +92,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
public IObservable<Reaction> GetAll(long repositoryId, int number)
/// <param name="commentId">The comment id</param>
public IObservable<Reaction> GetAll(long repositoryId, long commentId)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, commentId, ApiOptions.None);
}
/// <summary>
@@ -103,13 +103,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueCommentReactions(repositoryId, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.IssueCommentReactions(repositoryId, commentId), null, options);
}
/// <summary>
@@ -121,7 +121,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId)
public IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
@@ -138,7 +138,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId)
public IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId)
{
Ensure.ArgumentNotNull(reactionId, nameof(reactionId));

36
Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs
View File

@@ -30,13 +30,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The issue comment id</param>
public IObservable<IssueComment> Get(string owner, string name, int id)
/// <param name="commentId">The issue comment id</param>
public IObservable<IssueComment> Get(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, id).ToObservable();
return _client.Get(owner, name, commentId).ToObservable();
}
/// <summary>
@@ -44,10 +44,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The issue comment id</param>
public IObservable<IssueComment> Get(long repositoryId, int id)
/// <param name="commentId">The issue comment id</param>
public IObservable<IssueComment> Get(long repositoryId, long commentId)
{
return _client.Get(repositoryId, id).ToObservable();
return _client.Get(repositoryId, commentId).ToObservable();
}
/// <summary>
@@ -326,15 +326,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
public IObservable<IssueComment> Update(string owner, string name, int id, string commentUpdate)
public IObservable<IssueComment> Update(string owner, string name, long commentId, string commentUpdate)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(commentUpdate, nameof(commentUpdate));
return _client.Update(owner, name, id, commentUpdate).ToObservable();
return _client.Update(owner, name, commentId, commentUpdate).ToObservable();
}
/// <summary>
@@ -342,13 +342,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
public IObservable<IssueComment> Update(long repositoryId, int id, string commentUpdate)
public IObservable<IssueComment> Update(long repositoryId, long commentId, string commentUpdate)
{
Ensure.ArgumentNotNull(commentUpdate, nameof(commentUpdate));
return _client.Update(repositoryId, id, commentUpdate).ToObservable();
return _client.Update(repositoryId, commentId, commentUpdate).ToObservable();
}
/// <summary>
@@ -357,13 +357,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="id">The comment id</param>
public IObservable<Unit> Delete(string owner, string name, int id)
/// <param name="commentId">The comment id</param>
public IObservable<Unit> Delete(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, id).ToObservable();
return _client.Delete(owner, name, commentId).ToObservable();
}
/// <summary>
@@ -371,10 +371,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The comment id</param>
public IObservable<Unit> Delete(long repositoryId, int id)
/// <param name="commentId">The comment id</param>
public IObservable<Unit> Delete(long repositoryId, long commentId)
{
return _client.Delete(repositoryId, id).ToObservable();
return _client.Delete(repositoryId, commentId).ToObservable();
}
}
}

4
Octokit.Reactive/Clients/ObservableIssueReactionsClient.cs
View File

@@ -118,7 +118,7 @@ namespace Octokit.Reactive
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, int issueNumber, int reactionId)
public IObservable<Unit> Delete(string owner, string name, int issueNumber, long reactionId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
@@ -135,7 +135,7 @@ namespace Octokit.Reactive
/// <param name="issueNumber">The issue number</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, int issueNumber, int reactionId)
public IObservable<Unit> Delete(long repositoryId, int issueNumber, long reactionId)
{
Ensure.ArgumentNotNull(reactionId, nameof(reactionId));

38
Octokit.Reactive/Clients/ObservablePullRequestReviewCommentReactionsClient.cs
View File

@@ -30,19 +30,19 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
public IObservable<Reaction> GetAll(string owner, string name, int number)
/// <param name="commentId">The comment id</param>
public IObservable<Reaction> GetAll(string owner, string name, long commentId)
{
return GetAll(owner, name, number, ApiOptions.None);
return GetAll(owner, name, commentId, ApiOptions.None);
}
public IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options)
public IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.PullRequestReviewCommentReactions(owner, name, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.PullRequestReviewCommentReactions(owner, name, commentId), null, options);
}
/// <summary>
@@ -50,10 +50,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
public IObservable<Reaction> GetAll(long repositoryId, int number)
/// <param name="commentId">The comment id</param>
public IObservable<Reaction> GetAll(long repositoryId, long commentId)
{
return GetAll(repositoryId, number, ApiOptions.None);
return GetAll(repositoryId, commentId, ApiOptions.None);
}
/// <summary>
@@ -61,13 +61,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="options">Options for changing the API response</param>
public IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options)
public IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.PullRequestReviewCommentReactions(repositoryId, number), null, options);
return _connection.GetAndFlattenAllPages<Reaction>(ApiUrls.PullRequestReviewCommentReactions(repositoryId, commentId), null, options);
}
/// <summary>
@@ -76,15 +76,15 @@ namespace Octokit.Reactive
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-pull-request-review-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create</param>
public IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction)
public IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(owner, name, number, reaction).ToObservable();
return _client.Create(owner, name, commentId, reaction).ToObservable();
}
/// <summary>
@@ -92,13 +92,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-pull-request-review-comment</remarks>
/// <param name="repositoryId">The owner of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <param name="reaction">The reaction to create</param>
public IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction)
public IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction)
{
Ensure.ArgumentNotNull(reaction, nameof(reaction));
return _client.Create(repositoryId, number, reaction).ToObservable();
return _client.Create(repositoryId, commentId, reaction).ToObservable();
}
/// <summary>
@@ -110,7 +110,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId)
public IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
@@ -127,7 +127,7 @@ namespace Octokit.Reactive
/// <param name="commentId">The comment id</param>
/// <param name="reactionId">The reaction id</param>
/// <returns></returns>
public IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId)
public IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId)
{
Ensure.ArgumentNotNull(reactionId, nameof(reactionId));

36
Octokit.Reactive/Clients/ObservablePullRequestReviewCommentsClient.cs
View File

@@ -202,13 +202,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#get-a-single-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
public IObservable<PullRequestReviewComment> GetComment(string owner, string name, int number)
/// <param name="commentId">The pull request review comment id</param>
public IObservable<PullRequestReviewComment> GetComment(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.GetComment(owner, name, number).ToObservable();
return _client.GetComment(owner, name, commentId).ToObservable();
}
/// <summary>
@@ -216,10 +216,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#get-a-single-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
public IObservable<PullRequestReviewComment> GetComment(long repositoryId, int number)
/// <param name="commentId">The pull request review comment id</param>
public IObservable<PullRequestReviewComment> GetComment(long repositoryId, long commentId)
{
return _client.GetComment(repositoryId, number).ToObservable();
return _client.GetComment(repositoryId, commentId).ToObservable();
}
/// <summary>
@@ -290,15 +290,15 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#edit-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="commentId">The pull request review comment id</param>
/// <param name="comment">The edited comment</param>
public IObservable<PullRequestReviewComment> Edit(string owner, string name, int number, PullRequestReviewCommentEdit comment)
public IObservable<PullRequestReviewComment> Edit(string owner, string name, long commentId, PullRequestReviewCommentEdit comment)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.Edit(owner, name, number, comment).ToObservable();
return _client.Edit(owner, name, commentId, comment).ToObservable();
}
/// <summary>
@@ -306,13 +306,13 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#edit-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
/// <param name="commentId">The pull request review comment id</param>
/// <param name="comment">The edited comment</param>
public IObservable<PullRequestReviewComment> Edit(long repositoryId, int number, PullRequestReviewCommentEdit comment)
public IObservable<PullRequestReviewComment> Edit(long repositoryId, long commentId, PullRequestReviewCommentEdit comment)
{
Ensure.ArgumentNotNull(comment, nameof(comment));
return _client.Edit(repositoryId, number, comment).ToObservable();
return _client.Edit(repositoryId, commentId, comment).ToObservable();
}
/// <summary>
@@ -321,13 +321,13 @@ namespace Octokit.Reactive
/// <remarks>http://developer.github.com/v3/pulls/comments/#delete-a-comment</remarks>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The pull request review comment number</param>
public IObservable<Unit> Delete(string owner, string name, int number)
/// <param name="commentId">The pull request review comment id</param>
public IObservable<Unit> Delete(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number).ToObservable();
return _client.Delete(owner, name, commentId).ToObservable();
}
/// <summary>
@@ -335,10 +335,10 @@ namespace Octokit.Reactive
/// </summary>
/// <remarks>http://developer.github.com/v3/pulls/comments/#delete-a-comment</remarks>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The pull request review comment number</param>
public IObservable<Unit> Delete(long repositoryId, int number)
/// <param name="commentId">The pull request review comment id</param>
public IObservable<Unit> Delete(long repositoryId, long commentId)
{
return _client.Delete(repositoryId, number).ToObservable();
return _client.Delete(repositoryId, commentId).ToObservable();
}
}
}

36
Octokit.Reactive/Clients/ObservableRepositoryCommentsClient.cs
View File

@@ -29,25 +29,25 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#get-a-single-commit-comment</remarks>
public IObservable<CommitComment> Get(string owner, string name, int number)
public IObservable<CommitComment> Get(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Get(owner, name, number).ToObservable();
return _client.Get(owner, name, commentId).ToObservable();
}
/// <summary>
/// Gets a single Repository Comment by number.
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#get-a-single-commit-comment</remarks>
public IObservable<CommitComment> Get(long repositoryId, int number)
public IObservable<CommitComment> Get(long repositoryId, long commentId)
{
return _client.Get(repositoryId, number).ToObservable();
return _client.Get(repositoryId, commentId).ToObservable();
}
/// <summary>
@@ -203,30 +203,30 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment number</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#update-a-commit-comment</remarks>
public IObservable<CommitComment> Update(string owner, string name, int number, string commentUpdate)
public IObservable<CommitComment> Update(string owner, string name, long commentId, string commentUpdate)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Ensure.ArgumentNotNull(commentUpdate, nameof(commentUpdate));
return _client.Update(owner, name, number, commentUpdate).ToObservable();
return _client.Update(owner, name, commentId, commentUpdate).ToObservable();
}
/// <summary>
/// Updates a specified Commit Comment.
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment number</param>
/// <param name="commentId">The comment id</param>
/// <param name="commentUpdate">The modified comment</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#update-a-commit-comment</remarks>
public IObservable<CommitComment> Update(long repositoryId, int number, string commentUpdate)
public IObservable<CommitComment> Update(long repositoryId, long commentId, string commentUpdate)
{
Ensure.ArgumentNotNull(commentUpdate, nameof(commentUpdate));
return _client.Update(repositoryId, number, commentUpdate).ToObservable();
return _client.Update(repositoryId, commentId, commentUpdate).ToObservable();
}
/// <summary>
@@ -234,25 +234,25 @@ namespace Octokit.Reactive
/// </summary>
/// <param name="owner">The owner of the repository</param>
/// <param name="name">The name of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#delete-a-commit-comment</remarks>
public IObservable<Unit> Delete(string owner, string name, int number)
public IObservable<Unit> Delete(string owner, string name, long commentId)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
return _client.Delete(owner, name, number).ToObservable();
return _client.Delete(owner, name, commentId).ToObservable();
}
/// <summary>
/// Deletes the specified Commit Comment
/// </summary>
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="number">The comment id</param>
/// <param name="commentId">The comment id</param>
/// <remarks>http://developer.github.com/v3/repos/comments/#delete-a-commit-comment</remarks>
public IObservable<Unit> Delete(long repositoryId, int number)
public IObservable<Unit> Delete(long repositoryId, long commentId)
{
return _client.Delete(repositoryId, number).ToObservable();
return _client.Delete(repositoryId, commentId).ToObservable();
}
}
}