From 6d1634c843df9e2853e12b32d6b3b888b500d173 Mon Sep 17 00:00:00 2001 From: Roger Tinsley Date: Thu, 17 Mar 2016 08:35:39 +0000 Subject: [PATCH] Updated test to compare sha1 from reference with the GetSha1 method - CreateTheWorld now returns a Task - This reference is compared with client.GetSha1 --- .../Clients/RepositoryCommitsClientTests.cs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs b/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs index bac6865b..74c4e43e 100644 --- a/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs @@ -169,15 +169,14 @@ public class RepositoryCommitsClientTests [IntegrationTest] public async Task GetSha1FromRepository() { - await CreateTheWorld(); + var reference = await CreateTheWorld(); - var firstSha1 = await _fixture.GetSha1(Helper.UserName, _context.RepositoryName, "master"); - var secondSha1 = await _fixture.GetSha1(Helper.UserName, _context.RepositoryName, "master"); + var sha1 = await _fixture.GetSha1(Helper.UserName, _context.RepositoryName, "master"); - Assert.Equal(firstSha1, secondSha1); + Assert.Equal(reference.Object.Sha, sha1); } - async Task CreateTheWorld() + async Task CreateTheWorld() { var master = await _github.Git.Reference.Get(Helper.UserName, _context.RepositoryName, "heads/master"); @@ -193,7 +192,7 @@ public class RepositoryCommitsClientTests var newFeature = await CreateCommit("this is the commit to merge into the pull request", featureBranchTree.Sha, newMaster.Sha); // create branch - await _github.Git.Reference.Create(Helper.UserName, _context.RepositoryName, new NewReference("refs/heads/my-branch", newFeature.Sha)); + return await _github.Git.Reference.Create(Helper.UserName, _context.RepositoryName, new NewReference("refs/heads/my-branch", newFeature.Sha)); } async Task CreateTree(IDictionary treeContents)