From 705b93913ec9845c65844bc8379110fe90d654aa Mon Sep 17 00:00:00 2001 From: Roger Tinsley Date: Thu, 17 Mar 2016 07:48:33 +0000 Subject: [PATCH] Fixed wording & split out unit tests - One unit test for NonNullArguments - Another unit test for NonEMptyArguments --- .../Clients/RepositoriesClientTests.cs | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/Octokit.Tests/Clients/RepositoriesClientTests.cs b/Octokit.Tests/Clients/RepositoriesClientTests.cs index 52e325c7..417c3a56 100644 --- a/Octokit.Tests/Clients/RepositoriesClientTests.cs +++ b/Octokit.Tests/Clients/RepositoriesClientTests.cs @@ -794,18 +794,24 @@ namespace Octokit.Tests.Clients public class TheSha1Method { [Fact] - public async Task EnsureNonNullArguments() + public async void EnsuresNonNullArguments() + { + var client = new RepositoryCommitsClient(Substitute.For()); + + await Assert.ThrowsAsync(() => client.GetSha1("", "name", "reference")); + await Assert.ThrowsAsync(() => client.GetSha1("owner", "", "reference")); + await Assert.ThrowsAsync(() => client.GetSha1("owner", "name", "")); + + } + + [Fact] + public async Task EnsuresNonEmptyArguments() { var client = new RepositoryCommitsClient(Substitute.For()); await Assert.ThrowsAsync(() => client.GetSha1(null, "name", "reference")); - await Assert.ThrowsAsync(() => client.GetSha1("", "name", "reference")); - await Assert.ThrowsAsync(() => client.GetSha1("owner", null, "reference")); - await Assert.ThrowsAsync(() => client.GetSha1("owner", "", "reference")); - await Assert.ThrowsAsync(() => client.GetSha1("owner", "name", null)); - await Assert.ThrowsAsync(() => client.GetSha1("owner", "name", "")); } [Fact]