zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-02 19:00:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change response models 'Url' properties from Uri to string (#1585)

Browse Source 
* Add convention test to ensure 'Url' properties are of type string

Closes #1582

* Change 'Url' properties from Uri to string

Global Find/Replace FTW!

* fix compilation errors in the integration tests project

* Extend 'Url' properties type check to request models

* Stick to convention tests naming convention

* Remove unused using directives in models

Changing from `Uri` to `string` means the `using System;`
directive was not needed anymore in some files

* Update exception message wording

* empty commit to trigger a new build - hopefully Travis passes

* add convention test to ensure request models have Uri 'Url' properties

* make request models 'Url' properties Uri

fix typo in convention test name

* revert some request models 'Url' properties as `string`

see https://github.com/octokit/octokit.net/pull/1585#issuecomment-297186728

* Change test so that all model types must have 'Url' properties of type string

 - Filter test input to only get types which have 'Url' properties
 - Merge response and request model types tests into one
 - Unparameterize the exception since we only check for the string type now

* Fix string.Format tokens

If this PR doesn't get rebased, it'll be my wall of shame FOREVER!

* and then it's even more embarrassing when the commit message says rebased but you really meant squashed

* Remove exclusion of `Release` from request models
This commit is contained in:
Mickaël Derriey
2017-04-30 22:19:39 +10:00
committed by Ryan Gribble
parent eb10aae74f
commit 73feecefb3
40 changed files with 171 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit/Models/Response/CommitComment.cs
+3 -3
View File
@@ -9,7 +9,7 @@ namespace Octokit
{
public CommitComment() { }
public CommitComment(int id, Uri url, Uri htmlUrl, string body, string path, int position, int? line, string commitId, User user, DateTimeOffset createdAt, DateTimeOffset? updatedAt)
public CommitComment(int id, string url, string htmlUrl, string body, string path, int position, int? line, string commitId, User user, DateTimeOffset createdAt, DateTimeOffset? updatedAt)
{
Id = id;
Url = url;
@@ -32,12 +32,12 @@ namespace Octokit
/// <summary>
/// The URL for this repository comment.
/// </summary>
public Uri Url { get; protected set; }
public string Url { get; protected set; }
/// <summary>
/// The html URL for this repository comment.
/// </summary>
public Uri HtmlUrl { get; protected set; }
public string HtmlUrl { get; protected set; }
/// <summary>
/// Details about the repository comment.