From 786c7e50f3c2098ff8a21d6a010b8c6e7bf1b1b9 Mon Sep 17 00:00:00 2001
From: Kristian Hellang <kristian@hellang.com>
Date: Mon, 25 Nov 2013 16:14:04 +0100
Subject: [PATCH] Renamed GetAll with sub-namespace to GetAllForSubNamespace
 and added test for the regular GetAll

---
 .../Clients/ReferencesClientTests.cs          | 35 ++++++++++++++++---
 Octokit/Clients/IReferencesClient.cs          |  2 +-
 Octokit/Clients/ReferencesClient.cs           |  2 +-
 3 files changed, 32 insertions(+), 7 deletions(-)

diff --git a/Octokit.Tests/Clients/ReferencesClientTests.cs b/Octokit.Tests/Clients/ReferencesClientTests.cs
index bd914aea..cf7e7de0 100644
--- a/Octokit.Tests/Clients/ReferencesClientTests.cs
+++ b/Octokit.Tests/Clients/ReferencesClientTests.cs
@@ -54,10 +54,10 @@ namespace Octokit.Tests.Clients
             {
                 var client = new ReferencesClient(Substitute.For<IApiConnection>());
 
-                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll(null, "name", "heads"));
-                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll("owner", null, "heads"));
-                await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("", "name", "heads"));
-                await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("owner", "", "heads"));
+                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll(null, "name"));
+                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAll("owner", null));
+                await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("", "name"));
+                await AssertEx.Throws<ArgumentException>(async () => await client.GetAll("owner", ""));
             }
 
             [Fact]
@@ -66,7 +66,32 @@ namespace Octokit.Tests.Clients
                 var connection = Substitute.For<IApiConnection>();
                 var client = new ReferencesClient(connection);
 
-                await client.GetAll("owner", "repo", "heads");
+                await client.GetAll("owner", "repo");
+
+                connection.Received().GetAll<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs"));
+            }
+        }
+
+        public class TheGetAllForSubNamespaceMethod
+        {
+            [Fact]
+            public async Task EnsuresNonNullArguments()
+            {
+                var client = new ReferencesClient(Substitute.For<IApiConnection>());
+
+                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAllForSubNamespace(null, "name", "heads"));
+                await AssertEx.Throws<ArgumentNullException>(async () => await client.GetAllForSubNamespace("owner", null, "heads"));
+                await AssertEx.Throws<ArgumentException>(async () => await client.GetAllForSubNamespace("", "name", "heads"));
+                await AssertEx.Throws<ArgumentException>(async () => await client.GetAllForSubNamespace("owner", "", "heads"));
+            }
+
+            [Fact]
+            public async Task RequestsCorrectUrl()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new ReferencesClient(connection);
+
+                await client.GetAllForSubNamespace("owner", "repo", "heads");
 
                 connection.Received().GetAll<Reference>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/repo/git/refs/heads"));
             }
diff --git a/Octokit/Clients/IReferencesClient.cs b/Octokit/Clients/IReferencesClient.cs
index a609b021..06aecfb8 100644
--- a/Octokit/Clients/IReferencesClient.cs
+++ b/Octokit/Clients/IReferencesClient.cs
@@ -41,7 +41,7 @@ namespace Octokit
         /// <param name="name">The name of the repository</param>
         /// <param name="subNamespace">The sub-namespace to get references for</param>
         /// <returns></returns>
-        Task<IReadOnlyList<Reference>> GetAll(string owner, string name, string subNamespace);
+        Task<IReadOnlyList<Reference>> GetAllForSubNamespace(string owner, string name, string subNamespace);
 
         /// <summary>
         /// Creates a reference for a given repository
diff --git a/Octokit/Clients/ReferencesClient.cs b/Octokit/Clients/ReferencesClient.cs
index d4102ed0..c7cb657d 100644
--- a/Octokit/Clients/ReferencesClient.cs
+++ b/Octokit/Clients/ReferencesClient.cs
@@ -56,7 +56,7 @@ namespace Octokit
         /// <param name="name">The name of the repository</param>
         /// <param name="subNamespace">The sub-namespace to get references for</param>
         /// <returns></returns>
-        public Task<IReadOnlyList<Reference>> GetAll(string owner, string name, string subNamespace)
+        public Task<IReadOnlyList<Reference>> GetAllForSubNamespace(string owner, string name, string subNamespace)
         {
             Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
             Ensure.ArgumentNotNullOrEmptyString(name, "name");