diff --git a/Octokit.Tests.Integration/Clients/UsersClientTests.cs b/Octokit.Tests.Integration/Clients/UsersClientTests.cs index 69d7c8ac..89bb766e 100644 --- a/Octokit.Tests.Integration/Clients/UsersClientTests.cs +++ b/Octokit.Tests.Integration/Clients/UsersClientTests.cs @@ -102,6 +102,7 @@ public class UsersClientTests public class TheGetEmailsMethod { + [IntegrationTest] public async Task RetrievesEmailsForUser() { var github = new GitHubClient(new ProductHeaderValue("OctokitTests")) @@ -111,10 +112,10 @@ public class UsersClientTests var emails = await github.User.GetEmails(); - Assert.Equal(1, emails.Count()); - Assert.Equal("test-octowin@example.com", emails.First().Email); - Assert.True(emails.First().Primary); - Assert.False(emails.First().Verified); + Assert.NotEmpty(emails); + var email = emails.First(); + Assert.True(email.Primary); + Assert.False(email.Verified); } } } diff --git a/Octokit/SimpleJson.cs b/Octokit/SimpleJson.cs index 7588a721..36d7a65d 100644 --- a/Octokit/SimpleJson.cs +++ b/Octokit/SimpleJson.cs @@ -1638,7 +1638,7 @@ namespace Octokit Type genericDefinition = type.GetGenericTypeDefinition(); - return (genericDefinition == typeof(IList<>) || genericDefinition == typeof(ICollection<>) || genericDefinition == typeof(IEnumerable<>)); + return genericDefinition == typeof(IList<>) || genericDefinition == typeof(ICollection<>) || genericDefinition == typeof(IEnumerable<>) || genericDefinition == typeof(IReadOnlyCollection<>); } public static bool IsAssignableFrom(Type type1, Type type2)