diff --git a/Octokit.Tests/Reactive/ObservablePullRequestReviewCommentsClientTests.cs b/Octokit.Tests/Reactive/ObservablePullRequestReviewCommentsClientTests.cs index f1628e2c..600653c4 100644 --- a/Octokit.Tests/Reactive/ObservablePullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservablePullRequestReviewCommentsClientTests.cs @@ -5,6 +5,7 @@ using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; using Octokit.Reactive; +using System.Reactive.Threading.Tasks; using Octokit.Tests.Helpers; using Xunit; @@ -81,12 +82,12 @@ namespace Octokit.Tests.Reactive var gitHubClient = Substitute.For(); var client = new ObservablePullRequestReviewCommentsClient(gitHubClient); - await AssertEx.Throws(async () => await client.GetAll(null, "name", 1)); - await AssertEx.Throws(async () => await client.GetAll("", "name", 1)); - await AssertEx.Throws(async () => await client.GetAll("owner", null, 1)); - await AssertEx.Throws(async () => await client.GetAll("owner", "", 1)); - await AssertEx.Throws(async () => await client.GetAll(null, null, 1)); - await AssertEx.Throws(async () => await client.GetAll("", "", 1)); + await Assert.ThrowsAsync(() => client.GetAll(null, "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetAll("", "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetAll("owner", null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetAll("owner", "", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetAll(null, null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetAll("", "", 1).ToTask()); } } @@ -232,11 +233,11 @@ namespace Octokit.Tests.Reactive var request = new PullRequestReviewCommentRequest(); - await AssertEx.Throws(async () => await client.GetAllForRepository(null, "name", request)); - await AssertEx.Throws(async () => await client.GetAllForRepository("", "name", request)); - await AssertEx.Throws(async () => await client.GetAllForRepository("owner", null, request)); - await AssertEx.Throws(async () => await client.GetAllForRepository("owner", "", request)); - await AssertEx.Throws(async () => await client.GetAllForRepository("owner", "name", null)); + await Assert.ThrowsAsync(() => client.GetAllForRepository(null, "name", request).ToTask()); + await Assert.ThrowsAsync(() => client.GetAllForRepository("", "name", request).ToTask()); + await Assert.ThrowsAsync(() => client.GetAllForRepository("owner", null, request).ToTask()); + await Assert.ThrowsAsync(() => client.GetAllForRepository("owner", "", request).ToTask()); + await Assert.ThrowsAsync(() => client.GetAllForRepository("owner", "name", null).ToTask()); } } @@ -258,12 +259,12 @@ namespace Octokit.Tests.Reactive { var client = new ObservablePullRequestReviewCommentsClient(Substitute.For()); - await AssertEx.Throws(async () => await client.GetComment(null, "name", 1)); - await AssertEx.Throws(async () => await client.GetComment("", "name", 1)); - await AssertEx.Throws(async () => await client.GetComment("owner", null, 1)); - await AssertEx.Throws(async () => await client.GetComment("owner", "", 1)); - await AssertEx.Throws(async () => await client.GetComment(null, null, 1)); - await AssertEx.Throws(async () => await client.GetComment("", "", 1)); + await Assert.ThrowsAsync(() => client.GetComment(null, "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetComment("", "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetComment("owner", null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetComment("owner", "", 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetComment(null, null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.GetComment("", "", 1).ToTask()); } } @@ -295,11 +296,11 @@ namespace Octokit.Tests.Reactive var comment = new PullRequestReviewCommentCreate(body, commitId, path, position); - await AssertEx.Throws(async () => await client.Create(null, "name", 1, comment)); - await AssertEx.Throws(async () => await client.Create("", "name", 1, comment)); - await AssertEx.Throws(async () => await client.Create("owner", null, 1, comment)); - await AssertEx.Throws(async () => await client.Create("owner", "", 1, comment)); - await AssertEx.Throws(async () => await client.Create("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.Create(null, "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Create("", "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Create("owner", null, 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Create("owner", "", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Create("owner", "name", 1, null).ToTask()); } } @@ -329,11 +330,11 @@ namespace Octokit.Tests.Reactive var comment = new PullRequestReviewCommentReplyCreate(body, inReplyTo); - await AssertEx.Throws(async () => await client.CreateReply(null, "name", 1, comment)); - await AssertEx.Throws(async () => await client.CreateReply("", "name", 1, comment)); - await AssertEx.Throws(async () => await client.CreateReply("owner", null, 1, comment)); - await AssertEx.Throws(async () => await client.CreateReply("owner", "", 1, comment)); - await AssertEx.Throws(async () => await client.CreateReply("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.CreateReply(null, "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.CreateReply("", "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.CreateReply("owner", null, 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.CreateReply("owner", "", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.CreateReply("owner", "name", 1, null).ToTask()); } } @@ -362,11 +363,11 @@ namespace Octokit.Tests.Reactive var comment = new PullRequestReviewCommentEdit(body); - await AssertEx.Throws(async () => await client.Edit(null, "name", 1, comment)); - await AssertEx.Throws(async () => await client.Edit("", "name", 1, comment)); - await AssertEx.Throws(async () => await client.Edit("owner", null, 1, comment)); - await AssertEx.Throws(async () => await client.Edit("owner", "", 1, comment)); - await AssertEx.Throws(async () => await client.Edit("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.Edit(null, "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Edit("", "name", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Edit("owner", null, 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Edit("owner", "", 1, comment).ToTask()); + await Assert.ThrowsAsync(() => client.Edit("owner", "name", 1, null).ToTask()); } } @@ -389,10 +390,10 @@ namespace Octokit.Tests.Reactive var gitHubClient = Substitute.For(); var client = new ObservablePullRequestReviewCommentsClient(gitHubClient); - await AssertEx.Throws(async () => await client.Delete(null, "name", 1)); - await AssertEx.Throws(async () => await client.Delete("", "name", 1)); - await AssertEx.Throws(async () => await client.Delete("owner", null, 1)); - await AssertEx.Throws(async () => await client.Delete("owner", "", 1)); + await Assert.ThrowsAsync(() => client.Delete(null, "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.Delete("", "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.Delete("owner", null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.Delete("owner", "", 1).ToTask()); } } } diff --git a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs index e4a2c010..68626854 100644 --- a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs @@ -2,6 +2,7 @@ using System.Collections.Generic; using System.Linq; using System.Reactive.Linq; +using System.Reactive.Threading.Tasks; using System.Threading.Tasks; using NSubstitute; using Octokit.Internal; @@ -31,10 +32,10 @@ namespace Octokit.Tests.Reactive { var client = new ObservablePullRequestsClient(Substitute.For()); - await AssertEx.Throws(async () => await client.Get(null, "name", 1)); - await AssertEx.Throws(async () => await client.Get("owner", null, 1)); - await AssertEx.Throws(async () => await client.Get(null, "", 1)); - await AssertEx.Throws(async () => await client.Get("", null, 1)); + await Assert.ThrowsAsync(() => client.Get(null, "name", 1).ToTask()); + await Assert.ThrowsAsync(() => client.Get("owner", null, 1).ToTask()); + await Assert.ThrowsAsync(() => client.Get(null, "", 1).ToTask()); + await Assert.ThrowsAsync(() => client.Get("", null, 1).ToTask()); } } @@ -173,16 +174,16 @@ namespace Octokit.Tests.Reactive var gitHubClient = Substitute.For(); var client = new ObservablePullRequestsClient(gitHubClient); - await AssertEx.Throws(async () => await - client.Create(null, "name", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("", "name", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", null, new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", "", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", "name", null)); + await Assert.ThrowsAsync(() => + client.Create(null, "name", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("", "name", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", null, new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", "", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", "name", null).ToTask()); } } @@ -206,16 +207,16 @@ namespace Octokit.Tests.Reactive var gitHubClient = Substitute.For(); var client = new ObservablePullRequestsClient(gitHubClient); - await AssertEx.Throws(async () => await - client.Create(null, "name", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("", "name", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", null, new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", "", new NewPullRequest("title", "ref", "ref2"))); - await AssertEx.Throws(async () => await - client.Create("owner", "name", null)); + await Assert.ThrowsAsync(() => + client.Create(null, "name", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("", "name", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", null, new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", "", new NewPullRequest("title", "ref", "ref2")).ToTask()); + await Assert.ThrowsAsync(() => + client.Create("owner", "name", null).ToTask()); } } @@ -239,11 +240,11 @@ namespace Octokit.Tests.Reactive var connection = Substitute.For(); var client = new PullRequestsClient(connection); - await AssertEx.Throws(async () => await + await Assert.ThrowsAsync(() => client.Merge(null, "name", 42, new MergePullRequest { Message = "message" })); - await AssertEx.Throws(async () => await + await Assert.ThrowsAsync(() => client.Merge("owner", null, 42, new MergePullRequest { Message = "message" })); - await AssertEx.Throws(async () => await + await Assert.ThrowsAsync(() => client.Merge("owner", "name", 42, null)); } } @@ -267,10 +268,10 @@ namespace Octokit.Tests.Reactive var connection = Substitute.For(); var client = new PullRequestsClient(connection); - await AssertEx.Throws(async () => await client.Merged(null, "name", 1)); - await AssertEx.Throws(async () => await client.Merged("owner", null, 1)); - await AssertEx.Throws(async () => await client.Merged(null, "", 1)); - await AssertEx.Throws(async () => await client.Merged("", null, 1)); + await Assert.ThrowsAsync(() => client.Merged(null, "name", 1)); + await Assert.ThrowsAsync(() => client.Merged("owner", null, 1)); + await Assert.ThrowsAsync(() => client.Merged(null, "", 1)); + await Assert.ThrowsAsync(() => client.Merged("", null, 1)); } } @@ -306,10 +307,10 @@ namespace Octokit.Tests.Reactive var connection = Substitute.For(); var client = new PullRequestsClient(connection); - await AssertEx.Throws(async () => await client.Commits(null, "name", 1)); - await AssertEx.Throws(async () => await client.Commits("owner", null, 1)); - await AssertEx.Throws(async () => await client.Commits(null, "", 1)); - await AssertEx.Throws(async () => await client.Commits("", null, 1)); + await Assert.ThrowsAsync(() => client.Commits(null, "name", 1)); + await Assert.ThrowsAsync(() => client.Commits("owner", null, 1)); + await Assert.ThrowsAsync(() => client.Commits(null, "", 1)); + await Assert.ThrowsAsync(() => client.Commits("", null, 1)); } } @@ -345,10 +346,10 @@ namespace Octokit.Tests.Reactive var connection = Substitute.For(); var client = new PullRequestsClient(connection); - await AssertEx.Throws(async () => await client.Files(null, "name", 1)); - await AssertEx.Throws(async () => await client.Files("owner", null, 1)); - await AssertEx.Throws(async () => await client.Files("", "name", 1)); - await AssertEx.Throws(async () => await client.Files("owner", "", 1)); + await Assert.ThrowsAsync(() => client.Files(null, "name", 1)); + await Assert.ThrowsAsync(() => client.Files("owner", null, 1)); + await Assert.ThrowsAsync(() => client.Files("", "name", 1)); + await Assert.ThrowsAsync(() => client.Files("owner", "", 1)); } } public class TheCtor