diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs index da4ff427..aaf735aa 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs @@ -102,7 +102,7 @@ public class PullRequestReviewCommentsClientTests : IDisposable await CreateComments(commentsToCreate, position, pullRequest.RepoName, pullRequest.PullRequestCommitId, pullRequest.PullRequestNumber); - var pullRequestComments = await _client.GetForPullRequest(Helper.UserName, pullRequest.RepoName, pullRequest.PullRequestNumber); + var pullRequestComments = await _client.GetAll(Helper.UserName, pullRequest.RepoName, pullRequest.PullRequestNumber); AssertComments(pullRequestComments, commentsToCreate, position); } diff --git a/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs b/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs index 3fd0480e..70d38c37 100644 --- a/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests/Clients/PullRequestReviewCommentsClientTests.cs @@ -89,7 +89,7 @@ public class PullRequestReviewCommentsClientTests var connection = Substitute.For(); var client = new PullRequestReviewCommentsClient(connection); - client.GetForPullRequest("fakeOwner", "fakeRepoName", 7); + client.GetAll("fakeOwner", "fakeRepoName", 7); connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fakeOwner/fakeRepoName/pulls/7/comments")); } @@ -100,10 +100,10 @@ public class PullRequestReviewCommentsClientTests var connection = Substitute.For(); var client = new PullRequestReviewCommentsClient(connection); - await AssertEx.Throws(async () => await client.GetForPullRequest(null, "name", 1)); - await AssertEx.Throws(async () => await client.GetForPullRequest("", "name", 1)); - await AssertEx.Throws(async () => await client.GetForPullRequest("owner", null, 1)); - await AssertEx.Throws(async () => await client.GetForPullRequest("owner", "", 1)); + await AssertEx.Throws(async () => await client.GetAll(null, "name", 1)); + await AssertEx.Throws(async () => await client.GetAll("", "name", 1)); + await AssertEx.Throws(async () => await client.GetAll("owner", null, 1)); + await AssertEx.Throws(async () => await client.GetAll("owner", "", 1)); } } diff --git a/Octokit/Clients/IPullRequestReviewCommentsClient.cs b/Octokit/Clients/IPullRequestReviewCommentsClient.cs index 37cd15b4..e749effe 100644 --- a/Octokit/Clients/IPullRequestReviewCommentsClient.cs +++ b/Octokit/Clients/IPullRequestReviewCommentsClient.cs @@ -13,7 +13,7 @@ namespace Octokit /// The name of the repository /// The pull request number /// The list of s for the specified pull request - Task> GetForPullRequest(string owner, string name, int number); + Task> GetAll(string owner, string name, int number); /// /// Gets a list of the pull request review comments in a specified repository. diff --git a/Octokit/Clients/PullRequestReviewCommentsClient.cs b/Octokit/Clients/PullRequestReviewCommentsClient.cs index 517afbc5..fee2143c 100644 --- a/Octokit/Clients/PullRequestReviewCommentsClient.cs +++ b/Octokit/Clients/PullRequestReviewCommentsClient.cs @@ -19,7 +19,7 @@ namespace Octokit /// The name of the repository /// The pull request number /// The list of s for the specified pull request - public Task> GetForPullRequest(string owner, string name, int number) + public Task> GetAll(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name");