From 83bb3e37eb7ef93cc29365fa2579fa5dd7d8483f Mon Sep 17 00:00:00 2001 From: Ryan Gribble Date: Tue, 22 Mar 2016 00:25:12 +1000 Subject: [PATCH] Fix "repositories" Uri's by removing leading slash - this caused the base address to have the /api/v3/ removed when talking to GHE??? --- Octokit.Tests/Clients/RepositoriesClientTests.cs | 6 +++--- Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs | 2 +- Octokit/Helpers/ApiUrls.cs | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Octokit.Tests/Clients/RepositoriesClientTests.cs b/Octokit.Tests/Clients/RepositoriesClientTests.cs index f0f77b7d..4e8bd182 100644 --- a/Octokit.Tests/Clients/RepositoriesClientTests.cs +++ b/Octokit.Tests/Clients/RepositoriesClientTests.cs @@ -269,7 +269,7 @@ namespace Octokit.Tests.Clients client.GetAllPublic(); connection.Received() - .GetAll(Arg.Is(u => u.ToString() == "/repositories")); + .GetAll(Arg.Is(u => u.ToString() == "repositories")); } } @@ -285,7 +285,7 @@ namespace Octokit.Tests.Clients client.GetAllPublic(new PublicRepositoryRequest(364)); connection.Received() - .GetAll(Arg.Is(u => u.ToString() == "/repositories?since=364")); + .GetAll(Arg.Is(u => u.ToString() == "repositories?since=364")); } [Fact] @@ -297,7 +297,7 @@ namespace Octokit.Tests.Clients client.GetAllPublic(new PublicRepositoryRequest(364)); connection.Received() - .GetAll(Arg.Is(u => u.ToString() == "/repositories?since=364")); + .GetAll(Arg.Is(u => u.ToString() == "repositories?since=364")); } } diff --git a/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs index b0d25729..a2f0e31f 100644 --- a/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs @@ -163,7 +163,7 @@ namespace Octokit.Tests.Reactive [Fact] public async Task ReturnsEveryPageOfRepositories() { - var firstPageUrl = new Uri("/repositories?since=364", UriKind.Relative); + var firstPageUrl = new Uri("repositories?since=364", UriKind.Relative); var secondPageUrl = new Uri("https://example.com/page/2"); var firstPageLinks = new Dictionary { { "next", secondPageUrl } }; IApiResponse> firstPageResponse = new ApiResponse>( diff --git a/Octokit/Helpers/ApiUrls.cs b/Octokit/Helpers/ApiUrls.cs index 54d6edaa..b59cb950 100644 --- a/Octokit/Helpers/ApiUrls.cs +++ b/Octokit/Helpers/ApiUrls.cs @@ -25,7 +25,7 @@ namespace Octokit /// public static Uri AllPublicRepositories() { - return "/repositories".FormatUri(); + return "repositories".FormatUri(); } /// @@ -35,7 +35,7 @@ namespace Octokit /// The integer ID of the last Repository that you’ve seen. public static Uri AllPublicRepositories(long since) { - return "/repositories?since={0}".FormatUri(since); + return "repositories?since={0}".FormatUri(since); } ///