zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-08 12:42:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename Message to CommitMessage

Browse Source 
According to the docs
(https://developer.github.com/v3/pulls/#merge-a-pull-request-merge-button),
this should be sent as "commit_message" thus we need to name it
`CommitMessage`
Fixes #913
This commit is contained in:
Haacked
2015-09-27 14:45:11 -07:00
parent 504bad7690
commit 870a4e817a
4 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs
+3 -3
View File
@@ -225,7 +225,7 @@ namespace Octokit.Tests.Reactive
[Fact]
public void MergesPullRequest()
{
var mergePullRequest = new MergePullRequest { Message = "fake commit message" };
var mergePullRequest = new MergePullRequest { CommitMessage = "fake commit message" };
var gitHubClient = Substitute.For<IGitHubClient>();
var client = new ObservablePullRequestsClient(gitHubClient);
@@ -241,9 +241,9 @@ namespace Octokit.Tests.Reactive
var client = new PullRequestsClient(connection);
await Assert.ThrowsAsync<ArgumentNullException>(() =>
client.Merge(null, "name", 42, new MergePullRequest { Message = "message" }));
client.Merge(null, "name", 42, new MergePullRequest { CommitMessage = "message" }));
await Assert.ThrowsAsync<ArgumentNullException>(() =>
client.Merge("owner", null, 42, new MergePullRequest { Message = "message" }));
client.Merge("owner", null, 42, new MergePullRequest { CommitMessage = "message" }));
await Assert.ThrowsAsync<ArgumentNullException>(() =>
client.Merge("owner", "name", 42, null));
}