zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-08 20:45:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

throw more detailed exceptions for type not found and interface mismatches

Browse Source
This commit is contained in:
Brendan Forster
2014-02-20 22:11:02 +11:00
parent 14de4a6edf
commit 87638fc41d
6 changed files with 96 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests.Conventions/SyncObservableClients.cs
+17 -10
View File
@@ -13,23 +13,30 @@ namespace Octokit.Tests.Conventions
{
public class SyncObservableClients
{
[Fact]
private void CheckObservableClientExample()
{
CheckObservableClients(typeof(ISearchClient));
}
[Theory]
[ClassData(typeof(ClientInterfaces))]
private void CheckObservableClients(Type clientInterface)
public void CheckObservableClients(Type clientInterface)
{
var observableClient = clientInterface.GetObservableClientInterface();
var mainMethods = clientInterface.GetMethodsOrdered();
var observableMethods = observableClient.GetMethodsOrdered();
var mainNames = Array.ConvertAll(mainMethods, m => m.Name);
var observableNames = Array.ConvertAll(observableMethods, m => m.Name);
AssertEx.Empty(observableNames.Except(mainNames), "Extra observable methods");
AssertEx.Empty(mainNames.Except(observableNames), "Missing observable methods");
var methodsMissingOnReactiveClient = mainNames.Except(observableNames);
if (methodsMissingOnReactiveClient.Any())
{
throw new InterfaceMissingMethodsException(observableClient, methodsMissingOnReactiveClient);
}
var additionalMethodsOnReactiveClient = observableNames.Except(mainNames);
if (additionalMethodsOnReactiveClient.Any())
{
throw new InterfaceHasAdditionalMethodsException(observableClient, additionalMethodsOnReactiveClient);
}
int index = 0;
foreach(var mainMethod in mainMethods)
{
@@ -88,7 +95,7 @@ namespace Octokit.Tests.Conventions
{
var observableParameter = observableParameters[index];
Assert.Equal(mainParameter.Name, observableParameter.Name);
var mainType = mainParameter.ParameterType;
var mainType = mainParameter.ParameterType;
var typeInfo = mainType.GetTypeInfo();
var expectedType = GetObservableExpectedType(mainType);
Assert.Equal(expectedType, observableParameter.ParameterType);