From 93b8b27a0b23d952d799845dc4a71e118d899ef7 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Tue, 18 Feb 2014 19:48:51 +1100 Subject: [PATCH] updated docs --- .../Clients/IObservablePullRequestsClient.cs | 18 +++++++++--------- .../Clients/ObservablePullRequestsClient.cs | 16 ++++++++-------- Octokit/Clients/IPullRequestsClient.cs | 4 ++-- Octokit/Clients/PullRequestsClient.cs | 4 ++-- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservablePullRequestsClient.cs b/Octokit.Reactive/Clients/IObservablePullRequestsClient.cs index 0e608964..4d49adbd 100644 --- a/Octokit.Reactive/Clients/IObservablePullRequestsClient.cs +++ b/Octokit.Reactive/Clients/IObservablePullRequestsClient.cs @@ -11,7 +11,7 @@ namespace Octokit.Reactive /// /// http://developer.github.com/v3/pulls/#get-a-single-pull-request /// - /// + /// A result [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] IObservable Get(string owner, string name, int number); @@ -24,11 +24,11 @@ namespace Octokit.Reactive /// /// The owner of the repository /// The name of the repository - /// + /// A collection of results IObservable GetForRepository(string owner, string name); /// - /// Gets all open pull requests for the repository. + /// Query pull requests for the repository based on criteria /// /// /// http://developer.github.com/v3/pulls/#list-pull-requests @@ -36,7 +36,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// Used to filter and sort the list of pull requests returned - /// + /// A collection of results IObservable GetForRepository(string owner, string name, PullRequestRequest request); /// @@ -46,7 +46,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// A instance describing the new PullRequest to create - /// + /// A created result IObservable Create(string owner, string name, NewPullRequest newPullRequest); /// @@ -58,7 +58,7 @@ namespace Octokit.Reactive /// The PullRequest number /// An instance describing the changes to make to the PullRequest /// - /// + /// An updated result IObservable Update(string owner, string name, int number, PullRequestUpdate pullRequestUpdate); /// @@ -69,7 +69,7 @@ namespace Octokit.Reactive /// The name of the repository /// The pull request number /// A instance describing a pull request merge - /// + /// A result IObservable Merge(string owner, string name, int number, MergePullRequest mergePullRequest); /// @@ -79,7 +79,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The pull request number - /// + /// A result - true if the pull request has been merged, false otherwise IObservable Merged(string owner, string name, int number); /// @@ -89,7 +89,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The pull request number - /// + /// A collection of results IObservable Commits(string owner, string name, int number); } } diff --git a/Octokit.Reactive/Clients/ObservablePullRequestsClient.cs b/Octokit.Reactive/Clients/ObservablePullRequestsClient.cs index 6065825c..343a70a6 100644 --- a/Octokit.Reactive/Clients/ObservablePullRequestsClient.cs +++ b/Octokit.Reactive/Clients/ObservablePullRequestsClient.cs @@ -23,7 +23,7 @@ namespace Octokit.Reactive /// /// http://developer.github.com/v3/pulls/#get-a-single-pull-request /// - /// + /// A result public IObservable Get(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -40,7 +40,7 @@ namespace Octokit.Reactive /// /// The owner of the repository /// The name of the repository - /// + /// A collection of results public IObservable GetForRepository(string owner, string name) { return _connection.GetAndFlattenAllPages(ApiUrls.PullRequests(owner, name)); @@ -55,7 +55,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// Used to filter the list of Pull Requests returned - /// + /// A collection of results public IObservable GetForRepository(string owner, string name, PullRequestRequest request) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -73,7 +73,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// A instance describing the new PullRequest to create - /// + /// A created result public IObservable Create(string owner, string name, NewPullRequest newPullRequest) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -92,7 +92,7 @@ namespace Octokit.Reactive /// The PullRequest number /// An instance describing the changes to make to the PullRequest /// - /// + /// An updated result public IObservable Update(string owner, string name, int number, PullRequestUpdate pullRequestUpdate) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -110,7 +110,7 @@ namespace Octokit.Reactive /// The name of the repository /// The pull request number /// A instance describing a pull request merge - /// + /// A result public IObservable Merge(string owner, string name, int number, MergePullRequest mergePullRequest) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -127,7 +127,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The pull request number - /// + /// A result - true if the pull request has been merged, false otherwise public IObservable Merged(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -143,7 +143,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The pull request number - /// + /// A collection of results public IObservable Commits(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); diff --git a/Octokit/Clients/IPullRequestsClient.cs b/Octokit/Clients/IPullRequestsClient.cs index d64dfd2b..29211f06 100644 --- a/Octokit/Clients/IPullRequestsClient.cs +++ b/Octokit/Clients/IPullRequestsClient.cs @@ -12,7 +12,7 @@ namespace Octokit /// /// http://developer.github.com/v3/pulls/#get-a-single-pull-request /// - /// + /// A result [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] Task Get(string owner, string name, int number); @@ -29,7 +29,7 @@ namespace Octokit Task> GetForRepository(string owner, string name); /// - /// Get pull requests for the repository based on a given criteria + /// Query pull requests for the repository based on criteria /// /// /// http://developer.github.com/v3/pulls/#list-pull-requests diff --git a/Octokit/Clients/PullRequestsClient.cs b/Octokit/Clients/PullRequestsClient.cs index a616b992..1fc23ed6 100644 --- a/Octokit/Clients/PullRequestsClient.cs +++ b/Octokit/Clients/PullRequestsClient.cs @@ -17,7 +17,7 @@ namespace Octokit /// /// http://developer.github.com/v3/pulls/#get-a-single-pull-request /// - /// + /// A result public Task Get(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -41,7 +41,7 @@ namespace Octokit } /// - /// Get pull requests for the repository based on a given criteria + /// Query pull requests for the repository based on criteria /// /// /// http://developer.github.com/v3/pulls/#list-pull-requests