From a12e52891c8dccadcb2edb6d0296de02a7c2d032 Mon Sep 17 00:00:00 2001 From: Ryan Gribble Date: Wed, 30 Mar 2016 22:29:39 +1000 Subject: [PATCH] Rename NotLabels to ExcludeLabels --- Octokit.Tests/Models/SearchIssuesRequestTests.cs | 4 ++-- Octokit/Models/Request/SearchIssuesRequest.cs | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Octokit.Tests/Models/SearchIssuesRequestTests.cs b/Octokit.Tests/Models/SearchIssuesRequestTests.cs index 4371859e..b5ea4507 100644 --- a/Octokit.Tests/Models/SearchIssuesRequestTests.cs +++ b/Octokit.Tests/Models/SearchIssuesRequestTests.cs @@ -117,12 +117,12 @@ public class SearchIssuesRequestTests } [Fact] - public void HandlesNotLabelsAttributeCorrectly() + public void HandlesExcludeLabelsAttributeCorrectly() { var request = new SearchIssuesRequest("test"); Assert.False(request.MergedQualifiers().Any(x => x.Contains("-label:"))); - request.NotLabels = new List { "label1", "label2" }; + request.ExcludeLabels = new List { "label1", "label2" }; Assert.True(request.MergedQualifiers().Contains("-label:label1")); Assert.True(request.MergedQualifiers().Contains("-label:label2")); } diff --git a/Octokit/Models/Request/SearchIssuesRequest.cs b/Octokit/Models/Request/SearchIssuesRequest.cs index b5307d88..7593f371 100644 --- a/Octokit/Models/Request/SearchIssuesRequest.cs +++ b/Octokit/Models/Request/SearchIssuesRequest.cs @@ -161,21 +161,21 @@ namespace Octokit } } - private IEnumerable _notLabels; + private IEnumerable _excludeLabels; /// /// Filters issues based on the labels NOT assigned. /// /// /// https://help.github.com/articles/searching-issues/#search-by-the-labels-on-an-issue /// - public IEnumerable NotLabels + public IEnumerable ExcludeLabels { - get { return _notLabels; } + get { return _excludeLabels; } set { if (value != null && value.Any()) { - _notLabels = value.Distinct().ToList(); + _excludeLabels = value.Distinct().ToList(); } } } @@ -347,9 +347,9 @@ namespace Octokit parameters.AddRange(Labels.Select(label => string.Format(CultureInfo.InvariantCulture, "label:{0}", label))); } - if (NotLabels != null) + if (ExcludeLabels != null) { - parameters.AddRange(NotLabels.Select(label => string.Format(CultureInfo.InvariantCulture, "-label:{0}", label))); + parameters.AddRange(ExcludeLabels.Select(label => string.Format(CultureInfo.InvariantCulture, "-label:{0}", label))); } if (No.HasValue)