From 7bbbc7e74b2c2e25f8ad90a22dd11d136bba1687 Mon Sep 17 00:00:00 2001 From: Alexander Efremov Date: Sun, 12 Jun 2016 14:27:23 +0700 Subject: [PATCH 1/6] added new overloads modified XML docs a little bit --- .../Clients/IObservableTreesClient.cs | 40 ++++++++++++++ .../Clients/ObservableTreesClient.cs | 54 +++++++++++++++++++ Octokit/Clients/ITreesClient.cs | 34 ++++++++++++ Octokit/Clients/TreesClient.cs | 53 ++++++++++++++++++ 4 files changed, 181 insertions(+) diff --git a/Octokit.Reactive/Clients/IObservableTreesClient.cs b/Octokit.Reactive/Clients/IObservableTreesClient.cs index ac10689a..696df956 100644 --- a/Octokit.Reactive/Clients/IObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/IObservableTreesClient.cs @@ -2,6 +2,12 @@ using System; namespace Octokit.Reactive { + /// + /// A client for GitHub's Git Trees API. + /// + /// + /// See the Git Trees API documentation for more information. + /// public interface IObservableTreesClient { /// @@ -17,6 +23,18 @@ namespace Octokit.Reactive [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] IObservable Get(string owner, string name, string reference); + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// http://developer.github.com/v3/git/trees/#get-a-tree + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] + IObservable Get(int repositoryId, string reference); + /// /// Gets a Tree Response for a given SHA. /// @@ -29,6 +47,17 @@ namespace Octokit.Reactive /// The for the specified Tree. IObservable GetRecursive(string owner, string name, string reference); + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// https://developer.github.com/v3/git/trees/#get-a-tree-recursively + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + IObservable GetRecursive(int repositoryId, string reference); + /// /// Creates a new Tree in the specified repo /// @@ -40,5 +69,16 @@ namespace Octokit.Reactive /// The value of the new tree /// The that was just created. IObservable Create(string owner, string name, NewTree newTree); + + /// + /// Creates a new Tree in the specified repo + /// + /// + /// http://developer.github.com/v3/git/trees/#create-a-tree + /// + /// The ID of the repository + /// The value of the new tree + /// The that was just created. + IObservable Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit.Reactive/Clients/ObservableTreesClient.cs b/Octokit.Reactive/Clients/ObservableTreesClient.cs index e018b10d..bfe13b16 100644 --- a/Octokit.Reactive/Clients/ObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/ObservableTreesClient.cs @@ -3,6 +3,12 @@ using System.Reactive.Threading.Tasks; namespace Octokit.Reactive { + /// + /// A client for GitHub's Git Trees API. + /// + /// + /// See the Git Trees API documentation for more information. + /// public class ObservableTreesClient : IObservableTreesClient { readonly ITreesClient _client; @@ -33,6 +39,22 @@ namespace Octokit.Reactive return _client.Get(owner, name, reference).ToObservable(); } + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// http://developer.github.com/v3/git/trees/#get-a-tree + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + public IObservable Get(int repositoryId, string reference) + { + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + + return _client.Get(repositoryId, reference).ToObservable(); + } + /// /// Gets a Tree Response for a given SHA. /// @@ -52,6 +74,22 @@ namespace Octokit.Reactive return _client.GetRecursive(owner, name, reference).ToObservable(); } + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// https://developer.github.com/v3/git/trees/#get-a-tree-recursively + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + public IObservable GetRecursive(int repositoryId, string reference) + { + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + + return _client.GetRecursive(repositoryId, reference).ToObservable(); + } + /// /// Creates a new Tree in the specified repo /// @@ -70,5 +108,21 @@ namespace Octokit.Reactive return _client.Create(owner, name, newTree).ToObservable(); } + + /// + /// Creates a new Tree in the specified repo + /// + /// + /// http://developer.github.com/v3/git/trees/#create-a-tree + /// + /// The ID of the repository + /// The value of the new tree + /// The that was just created. + public IObservable Create(int repositoryId, NewTree newTree) + { + Ensure.ArgumentNotNull(newTree, "newTree"); + + return _client.Create(repositoryId, newTree).ToObservable(); + } } } diff --git a/Octokit/Clients/ITreesClient.cs b/Octokit/Clients/ITreesClient.cs index 549621a4..fe74e1eb 100644 --- a/Octokit/Clients/ITreesClient.cs +++ b/Octokit/Clients/ITreesClient.cs @@ -23,6 +23,18 @@ namespace Octokit [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] Task Get(string owner, string name, string reference); + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// http://developer.github.com/v3/git/trees/#get-a-tree + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] + Task Get(int repositoryId, string reference); + /// /// Gets a Tree Response for a given SHA. /// @@ -35,6 +47,17 @@ namespace Octokit /// The for the specified Tree. Task GetRecursive(string owner, string name, string reference); + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// https://developer.github.com/v3/git/trees/#get-a-tree-recursively + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + Task GetRecursive(int repositoryId, string reference); + /// /// Creates a new Tree in the specified repo /// @@ -46,5 +69,16 @@ namespace Octokit /// The value of the new tree /// The that was just created. Task Create(string owner, string name, NewTree newTree); + + /// + /// Creates a new Tree in the specified repo + /// + /// + /// http://developer.github.com/v3/git/trees/#create-a-tree + /// + /// The ID of the repository + /// The value of the new tree + /// The that was just created. + Task Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit/Clients/TreesClient.cs b/Octokit/Clients/TreesClient.cs index 5ac64675..829014c6 100644 --- a/Octokit/Clients/TreesClient.cs +++ b/Octokit/Clients/TreesClient.cs @@ -40,6 +40,22 @@ namespace Octokit return ApiConnection.Get(ApiUrls.Tree(owner, name, reference)); } + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// http://developer.github.com/v3/git/trees/#get-a-tree + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + public Task Get(int repositoryId, string reference) + { + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + + return ApiConnection.Get(ApiUrls.Tree(repositoryId, reference)); + } + /// /// Gets a Tree Response for a given SHA. /// @@ -59,6 +75,22 @@ namespace Octokit return ApiConnection.Get(ApiUrls.TreeRecursive(owner, name, reference)); } + /// + /// Gets a Tree Response for a given SHA. + /// + /// + /// https://developer.github.com/v3/git/trees/#get-a-tree-recursively + /// + /// The ID of the repository + /// The SHA that references the tree + /// The for the specified Tree. + public Task GetRecursive(int repositoryId, string reference) + { + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + + return ApiConnection.Get(ApiUrls.TreeRecursive(repositoryId, reference)); + } + /// /// Creates a new Tree in the specified repo /// @@ -82,5 +114,26 @@ namespace Octokit return ApiConnection.Post(ApiUrls.Tree(owner, name), newTree); } + + /// + /// Creates a new Tree in the specified repo + /// + /// + /// http://developer.github.com/v3/git/trees/#create-a-tree + /// + /// The ID of the repository + /// The value of the new tree + /// The that was just created. + public Task Create(int repositoryId, NewTree newTree) + { + Ensure.ArgumentNotNull(newTree, "newTree"); + + if (newTree.Tree.Any(t => string.IsNullOrWhiteSpace(t.Mode))) + { + throw new ArgumentException("You have specified items in the tree which do not have a Mode value set."); + } + + return ApiConnection.Post(ApiUrls.Tree(repositoryId), newTree); + } } } From 23e734de8925b9dd3b623c5e5a65c2080737fc4e Mon Sep 17 00:00:00 2001 From: Alexander Efremov Date: Sun, 12 Jun 2016 14:39:43 +0700 Subject: [PATCH 2/6] added new unit tests --- Octokit.Tests/Clients/TreesClientTests.cs | 81 +++++++++++++++--- .../Reactive/ObservableTreesClientTests.cs | 82 +++++++++++++++---- 2 files changed, 135 insertions(+), 28 deletions(-) diff --git a/Octokit.Tests/Clients/TreesClientTests.cs b/Octokit.Tests/Clients/TreesClientTests.cs index 458f9a14..b876eeab 100644 --- a/Octokit.Tests/Clients/TreesClientTests.cs +++ b/Octokit.Tests/Clients/TreesClientTests.cs @@ -13,54 +13,86 @@ namespace Octokit.Tests public class TheGetMethod { [Fact] - public void RequestsCorrectUrl() + public async Task RequestsCorrectUrl() { var connection = Substitute.For(); var client = new TreesClient(connection); - client.Get("fake", "repo", "123456ABCD"); + await client.Get("fake", "repo", "123456ABCD"); connection.Received().Get(Arg.Is(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD")); } + [Fact] + public async Task RequestsCorrectUrlWithRepositoryId() + { + var connection = Substitute.For(); + var client = new TreesClient(connection); + + await client.Get(1, "123456ABCD"); + + connection.Received().Get(Arg.Is(u => u.ToString() == "repositories/1/git/trees/123456ABCD")); + } + [Fact] public async Task EnsuresNonNullArguments() { var client = new TreesClient(Substitute.For()); await Assert.ThrowsAsync(() => client.Get(null, "name", "123456ABCD")); - await Assert.ThrowsAsync(() => client.Get("", "name", "123456ABCD")); await Assert.ThrowsAsync(() => client.Get("owner", null, "123456ABCD")); - await Assert.ThrowsAsync(() => client.Get("owner", "", "123456ABCD")); await Assert.ThrowsAsync(() => client.Get("owner", "name", null)); + + await Assert.ThrowsAsync(() => client.Get(1, null)); + + await Assert.ThrowsAsync(() => client.Get("owner", "", "123456ABCD")); + await Assert.ThrowsAsync(() => client.Get("", "name", "123456ABCD")); await Assert.ThrowsAsync(() => client.Get("owner", "name", "")); + + await Assert.ThrowsAsync(() => client.Get(1, "")); } } public class TheGetRecursiveMethod { [Fact] - public void RequestsCorrectUrl() + public async Task RequestsCorrectUrl() { var connection = Substitute.For(); var client = new TreesClient(connection); - client.GetRecursive("fake", "repo", "123456ABCD"); + await client.GetRecursive("fake", "repo", "123456ABCD"); connection.Received().Get(Arg.Is(u => u.ToString() == "repos/fake/repo/git/trees/123456ABCD?recursive=1")); } + [Fact] + public async Task RequestsCorrectUrlWithRepositoryId() + { + var connection = Substitute.For(); + var client = new TreesClient(connection); + + await client.GetRecursive(1, "123456ABCD"); + + connection.Received().Get(Arg.Is(u => u.ToString() == "repositories/1/git/trees/123456ABCD?recursive=1")); + } + [Fact] public async Task EnsuresNonNullArguments() { var client = new TreesClient(Substitute.For()); await Assert.ThrowsAsync(() => client.GetRecursive(null, "name", "123456ABCD")); - await Assert.ThrowsAsync(() => client.GetRecursive("", "name", "123456ABCD")); await Assert.ThrowsAsync(() => client.GetRecursive("owner", null, "123456ABCD")); - await Assert.ThrowsAsync(() => client.GetRecursive("owner", "", "123456ABCD")); await Assert.ThrowsAsync(() => client.GetRecursive("owner", "name", null)); + + await Assert.ThrowsAsync(() => client.GetRecursive(1, null)); + + await Assert.ThrowsAsync(() => client.GetRecursive("", "name", "123456ABCD")); + await Assert.ThrowsAsync(() => client.GetRecursive("owner", "", "123456ABCD")); await Assert.ThrowsAsync(() => client.GetRecursive("owner", "name", "")); + + await Assert.ThrowsAsync(() => client.GetRecursive(1, "")); } } @@ -79,14 +111,30 @@ namespace Octokit.Tests } [Fact] - public async Task EnsuresArgumentsNotNull() + public void PostsToCorrectUrlWithRepositoryId() + { + var newTree = new NewTree(); + var connection = Substitute.For(); + var client = new TreesClient(connection); + + client.Create(1, newTree); + + connection.Received().Post(Arg.Is(u => u.ToString() == "repositories/1/git/trees"), newTree); + } + + [Fact] + public async Task EnsuresNonNullArguments() { var connection = Substitute.For(); var client = new TreesClient(connection); await Assert.ThrowsAsync(() => client.Create(null, "name", new NewTree())); - await Assert.ThrowsAsync(() => client.Create("", "name", new NewTree())); await Assert.ThrowsAsync(() => client.Create("owner", null, new NewTree())); + await Assert.ThrowsAsync(() => client.Create("owner", "name", null)); + + await Assert.ThrowsAsync(() => client.Create(1, null)); + + await Assert.ThrowsAsync(() => client.Create("", "name", new NewTree())); await Assert.ThrowsAsync(() => client.Create("owner", "", new NewTree())); } @@ -102,6 +150,19 @@ namespace Octokit.Tests await Assert.ThrowsAsync( () => client.Create("fake", "repo", newTree)); } + + [Fact] + public async Task EnsureExceptionIsThrownWhenModeIsNotProvidedWithRepositoryId() + { + var newTree = new NewTree(); + newTree.Tree.Add(new NewTreeItem { Path = "README.md", Type = TreeType.Blob, Sha = "2e1a73d60f004fd842d4bad28aa42392d4f35d28" }); + + var connection = Substitute.For(); + var client = new TreesClient(connection); + + await Assert.ThrowsAsync( + () => client.Create(1, newTree)); + } } public class TheCtor diff --git a/Octokit.Tests/Reactive/ObservableTreesClientTests.cs b/Octokit.Tests/Reactive/ObservableTreesClientTests.cs index d2e0920c..b94e211d 100644 --- a/Octokit.Tests/Reactive/ObservableTreesClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableTreesClientTests.cs @@ -21,7 +21,7 @@ namespace Octokit.Tests public class TheGetMethod { [Fact] - public void GetsFromClientIssueIssue() + public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); var client = new ObservableTreesClient(gitHubClient); @@ -31,24 +31,40 @@ namespace Octokit.Tests gitHubClient.Git.Tree.Received().Get("fake", "repo", "123456ABCD"); } + [Fact] + public void RequestsCorrectUrlWithRepositoryId() + { + var gitHubClient = Substitute.For(); + var client = new ObservableTreesClient(gitHubClient); + + client.Get(1, "123456ABCD"); + + gitHubClient.Git.Tree.Received().Get(1, "123456ABCD"); + } + [Fact] public async Task EnsuresNonNullArguments() { var client = new ObservableTreesClient(Substitute.For()); - await Assert.ThrowsAsync(() => client.Get(null, "name", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.Get("", "name", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.Get("owner", null, "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.Get("owner", "", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.Get("owner", "name", null).ToTask()); - await Assert.ThrowsAsync(() => client.Get("owner", "name", "").ToTask()); + Assert.Throws(() => client.Get(null, "name", "123456ABCD")); + Assert.Throws(() => client.Get("owner", null, "123456ABCD")); + Assert.Throws(() => client.Get("owner", "name", null)); + + Assert.Throws(() => client.Get(1, null)); + + Assert.Throws(() => client.Get("", "name", "123456ABCD")); + Assert.Throws(() => client.Get("owner", "", "123456ABCD")); + Assert.Throws(() => client.Get("owner", "name", "")); + + Assert.Throws(() => client.Get(1, "")); } } public class TheGetRecursiveMethod { [Fact] - public void GetsFromClientIssueIssue() + public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); var client = new ObservableTreesClient(gitHubClient); @@ -58,24 +74,40 @@ namespace Octokit.Tests gitHubClient.Git.Tree.Received().GetRecursive("fake", "repo", "123456ABCD"); } + [Fact] + public void RequestsCorrectUrlWithRepositoryId() + { + var gitHubClient = Substitute.For(); + var client = new ObservableTreesClient(gitHubClient); + + client.GetRecursive(1, "123456ABCD"); + + gitHubClient.Git.Tree.Received().GetRecursive(1, "123456ABCD"); + } + [Fact] public async Task EnsuresNonNullArguments() { var client = new ObservableTreesClient(Substitute.For()); - await Assert.ThrowsAsync(() => client.GetRecursive(null, "name", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.GetRecursive("", "name", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.GetRecursive("owner", null, "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.GetRecursive("owner", "", "123456ABCD").ToTask()); - await Assert.ThrowsAsync(() => client.GetRecursive("owner", "name", null).ToTask()); - await Assert.ThrowsAsync(() => client.GetRecursive("owner", "name", "").ToTask()); + Assert.Throws(() => client.GetRecursive(null, "name", "123456ABCD")); + Assert.Throws(() => client.GetRecursive("owner", null, "123456ABCD")); + Assert.Throws(() => client.GetRecursive("owner", "name", null)); + + Assert.Throws(() => client.GetRecursive(1, null)); + + Assert.Throws(() => client.GetRecursive("", "name", "123456ABCD")); + Assert.Throws(() => client.GetRecursive("owner", "", "123456ABCD")); + Assert.Throws(() => client.GetRecursive("owner", "name", "")); + + Assert.Throws(() => client.GetRecursive(1, "")); } } public class TheCreateMethod { [Fact] - public void CreatesFromClientIssueIssue() + public void RequestsCorrectUrl() { var newTree = new NewTree(); var gitHubClient = Substitute.For(); @@ -87,16 +119,30 @@ namespace Octokit.Tests } [Fact] - public async Task EnsuresArgumentsNotNull() + public void RequestsCorrectUrlWithRepositoryId() { + var newTree = new NewTree(); var gitHubClient = Substitute.For(); var client = new ObservableTreesClient(gitHubClient); + client.Create(1, newTree); + + gitHubClient.Git.Tree.Received().Create(1, newTree); + } + + [Fact] + public async Task EnsuresNonNullArguments() + { + var client = new ObservableTreesClient(Substitute.For()); + Assert.Throws(() => client.Create(null, "name", new NewTree())); - Assert.Throws(() => client.Create("", "name", new NewTree())); Assert.Throws(() => client.Create("owner", null, new NewTree())); - Assert.Throws(() => client.Create("owner", "", new NewTree())); Assert.Throws(() => client.Create("owner", "name", null)); + + Assert.Throws(() => client.Create(1, null)); + + Assert.Throws(() => client.Create("", "name", new NewTree())); + Assert.Throws(() => client.Create("owner", "", new NewTree())); } } } From b13422f64bd8f4fd9157fcc5906e5bb894f9712d Mon Sep 17 00:00:00 2001 From: Alexander Efremov Date: Sun, 12 Jun 2016 15:25:35 +0700 Subject: [PATCH 3/6] added integration tests --- .../Clients/TreeClientTests.cs | 64 ++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/Octokit.Tests.Integration/Clients/TreeClientTests.cs b/Octokit.Tests.Integration/Clients/TreeClientTests.cs index 4522efc5..ea7d2b7e 100644 --- a/Octokit.Tests.Integration/Clients/TreeClientTests.cs +++ b/Octokit.Tests.Integration/Clients/TreeClientTests.cs @@ -2,8 +2,8 @@ using System.Threading.Tasks; using Octokit; using Octokit.Tests.Integration; -using Xunit; using Octokit.Tests.Integration.Helpers; +using Xunit; public class TreeClientTests : IDisposable { @@ -45,6 +45,31 @@ public class TreeClientTests : IDisposable Assert.NotNull(result); } + [IntegrationTest] + public async Task CanCreateATreeWithRepositoryId() + { + var blob = new NewBlob + { + Content = "Hello World!", + Encoding = EncodingType.Utf8 + }; + + var createdBlob = await _github.Git.Blob.Create(_context.RepositoryOwner, _context.RepositoryName, blob); + + var newTree = new NewTree(); + newTree.Tree.Add(new NewTreeItem + { + Type = TreeType.Blob, + Path = "README.md", + Sha = createdBlob.Sha, + Mode = FileMode.File + }); + + var result = await _fixture.Create(_context.Repository.Id, newTree); + + Assert.NotNull(result); + } + [IntegrationTest] public async Task CanGetATree() { @@ -54,6 +79,15 @@ public class TreeClientTests : IDisposable Assert.NotEmpty(result.Tree); } + [IntegrationTest] + public async Task CanGetATreeWithRepositoryId() + { + var result = await _fixture.Get(1, "master"); + + Assert.NotNull(result); + Assert.NotEmpty(result.Tree); + } + [IntegrationTest] public async Task CanGetACreatedTree() { @@ -82,6 +116,34 @@ public class TreeClientTests : IDisposable Assert.Equal(1, result.Tree.Count); } + [IntegrationTest] + public async Task CanGetACreatedTreeWithRepositoryId() + { + var blob = new NewBlob + { + Content = "Hello World!", + Encoding = EncodingType.Utf8 + }; + + var blobResult = await _github.Git.Blob.Create(_context.RepositoryOwner, _context.RepositoryName, blob); + + var newTree = new NewTree(); + newTree.Tree.Add(new NewTreeItem + { + Type = TreeType.Blob, + Path = "README.md", + Sha = blobResult.Sha, + Mode = FileMode.File + }); + + var tree = await _fixture.Create(_context.Repository.Id, newTree); + + var result = await _fixture.Get(_context.Repository.Id, tree.Sha); + + Assert.NotNull(result); + Assert.Equal(1, result.Tree.Count); + } + public void Dispose() { _context.Dispose(); From eb0817174f80c1796e105e9407b0e490954a7a75 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Tue, 14 Jun 2016 10:24:29 +1000 Subject: [PATCH 4/6] lock to an earlier version of mono (#1376) --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 5acd1c06..1244d3eb 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,4 +1,6 @@ language: csharp +mono: + - 4.2.3 sudo: false # use the new container-based Travis infrastructure os: From b198b472542ee997e787a219a7c8b69c8ddca58a Mon Sep 17 00:00:00 2001 From: Alexander Efremov Date: Fri, 17 Jun 2016 05:41:03 +0700 Subject: [PATCH 5/6] cleared tags --- Octokit.Reactive/Clients/IObservableTreesClient.cs | 12 ++++++------ Octokit.Reactive/Clients/ObservableTreesClient.cs | 12 ++++++------ Octokit/Clients/ITreesClient.cs | 12 ++++++------ Octokit/Clients/TreesClient.cs | 12 ++++++------ 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableTreesClient.cs b/Octokit.Reactive/Clients/IObservableTreesClient.cs index 696df956..4a1d8cb9 100644 --- a/Octokit.Reactive/Clients/IObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/IObservableTreesClient.cs @@ -19,7 +19,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] IObservable Get(string owner, string name, string reference); @@ -31,7 +31,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] IObservable Get(int repositoryId, string reference); @@ -44,7 +44,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// IObservable GetRecursive(string owner, string name, string reference); /// @@ -55,7 +55,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// IObservable GetRecursive(int repositoryId, string reference); /// @@ -67,7 +67,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The value of the new tree - /// The that was just created. + /// IObservable Create(string owner, string name, NewTree newTree); /// @@ -78,7 +78,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The value of the new tree - /// The that was just created. + /// IObservable Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit.Reactive/Clients/ObservableTreesClient.cs b/Octokit.Reactive/Clients/ObservableTreesClient.cs index bfe13b16..a0212f03 100644 --- a/Octokit.Reactive/Clients/ObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/ObservableTreesClient.cs @@ -29,7 +29,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public IObservable Get(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -47,7 +47,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public IObservable Get(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -64,7 +64,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public IObservable GetRecursive(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -82,7 +82,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public IObservable GetRecursive(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -99,7 +99,7 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The value of the new tree - /// The that was just created. + /// public IObservable Create(string owner, string name, NewTree newTree) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -117,7 +117,7 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The value of the new tree - /// The that was just created. + /// public IObservable Create(int repositoryId, NewTree newTree) { Ensure.ArgumentNotNull(newTree, "newTree"); diff --git a/Octokit/Clients/ITreesClient.cs b/Octokit/Clients/ITreesClient.cs index fe74e1eb..85590f54 100644 --- a/Octokit/Clients/ITreesClient.cs +++ b/Octokit/Clients/ITreesClient.cs @@ -19,7 +19,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] Task Get(string owner, string name, string reference); @@ -31,7 +31,7 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] Task Get(int repositoryId, string reference); @@ -44,7 +44,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// Task GetRecursive(string owner, string name, string reference); /// @@ -55,7 +55,7 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// Task GetRecursive(int repositoryId, string reference); /// @@ -67,7 +67,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The value of the new tree - /// The that was just created. + /// Task Create(string owner, string name, NewTree newTree); /// @@ -78,7 +78,7 @@ namespace Octokit /// /// The ID of the repository /// The value of the new tree - /// The that was just created. + /// Task Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit/Clients/TreesClient.cs b/Octokit/Clients/TreesClient.cs index 829014c6..b24f15e7 100644 --- a/Octokit/Clients/TreesClient.cs +++ b/Octokit/Clients/TreesClient.cs @@ -30,7 +30,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public Task Get(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -48,7 +48,7 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public Task Get(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -65,7 +65,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public Task GetRecursive(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -83,7 +83,7 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// The for the specified Tree. + /// public Task GetRecursive(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -100,7 +100,7 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The value of the new tree - /// The that was just created. + /// public Task Create(string owner, string name, NewTree newTree) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -123,7 +123,7 @@ namespace Octokit /// /// The ID of the repository /// The value of the new tree - /// The that was just created. + /// public Task Create(int repositoryId, NewTree newTree) { Ensure.ArgumentNotNull(newTree, "newTree"); From 36c20079a70255a182c567ba0df19c02604a88d0 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Thu, 7 Jul 2016 03:10:31 +0700 Subject: [PATCH 6/6] removed tags --- Octokit.Reactive/Clients/IObservableTreesClient.cs | 6 ------ Octokit.Reactive/Clients/ObservableTreesClient.cs | 6 ------ Octokit/Clients/ITreesClient.cs | 6 ------ Octokit/Clients/TreesClient.cs | 6 ------ 4 files changed, 24 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableTreesClient.cs b/Octokit.Reactive/Clients/IObservableTreesClient.cs index 4a1d8cb9..5bcdf476 100644 --- a/Octokit.Reactive/Clients/IObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/IObservableTreesClient.cs @@ -19,7 +19,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] IObservable Get(string owner, string name, string reference); @@ -31,7 +30,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] IObservable Get(int repositoryId, string reference); @@ -44,7 +42,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// IObservable GetRecursive(string owner, string name, string reference); /// @@ -55,7 +52,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// IObservable GetRecursive(int repositoryId, string reference); /// @@ -67,7 +63,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The value of the new tree - /// IObservable Create(string owner, string name, NewTree newTree); /// @@ -78,7 +73,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The value of the new tree - /// IObservable Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit.Reactive/Clients/ObservableTreesClient.cs b/Octokit.Reactive/Clients/ObservableTreesClient.cs index a0212f03..400c6d64 100644 --- a/Octokit.Reactive/Clients/ObservableTreesClient.cs +++ b/Octokit.Reactive/Clients/ObservableTreesClient.cs @@ -29,7 +29,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// public IObservable Get(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -47,7 +46,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// public IObservable Get(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -64,7 +62,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// public IObservable GetRecursive(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -82,7 +79,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The SHA that references the tree - /// public IObservable GetRecursive(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -99,7 +95,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The value of the new tree - /// public IObservable Create(string owner, string name, NewTree newTree) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -117,7 +112,6 @@ namespace Octokit.Reactive /// /// The ID of the repository /// The value of the new tree - /// public IObservable Create(int repositoryId, NewTree newTree) { Ensure.ArgumentNotNull(newTree, "newTree"); diff --git a/Octokit/Clients/ITreesClient.cs b/Octokit/Clients/ITreesClient.cs index 85590f54..b4835661 100644 --- a/Octokit/Clients/ITreesClient.cs +++ b/Octokit/Clients/ITreesClient.cs @@ -19,7 +19,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] Task Get(string owner, string name, string reference); @@ -31,7 +30,6 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get")] Task Get(int repositoryId, string reference); @@ -44,7 +42,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// Task GetRecursive(string owner, string name, string reference); /// @@ -55,7 +52,6 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// Task GetRecursive(int repositoryId, string reference); /// @@ -67,7 +63,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The value of the new tree - /// Task Create(string owner, string name, NewTree newTree); /// @@ -78,7 +73,6 @@ namespace Octokit /// /// The ID of the repository /// The value of the new tree - /// Task Create(int repositoryId, NewTree newTree); } } \ No newline at end of file diff --git a/Octokit/Clients/TreesClient.cs b/Octokit/Clients/TreesClient.cs index b24f15e7..4552b4f6 100644 --- a/Octokit/Clients/TreesClient.cs +++ b/Octokit/Clients/TreesClient.cs @@ -30,7 +30,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// public Task Get(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -48,7 +47,6 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// public Task Get(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -65,7 +63,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The SHA that references the tree - /// public Task GetRecursive(string owner, string name, string reference) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -83,7 +80,6 @@ namespace Octokit /// /// The ID of the repository /// The SHA that references the tree - /// public Task GetRecursive(int repositoryId, string reference) { Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); @@ -100,7 +96,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The value of the new tree - /// public Task Create(string owner, string name, NewTree newTree) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -123,7 +118,6 @@ namespace Octokit /// /// The ID of the repository /// The value of the new tree - /// public Task Create(int repositoryId, NewTree newTree) { Ensure.ArgumentNotNull(newTree, "newTree");