From a936184cff860c36e8d4a27507b64cb9fba2c70c Mon Sep 17 00:00:00 2001 From: Ryan Gribble Date: Thu, 16 Mar 2017 06:42:54 +1000 Subject: [PATCH] response enums can be camelcase as underscores are removed in the deserializer --- .../Clients/IssueTimelineClientTests.cs | 2 +- Octokit/Models/Response/EventInfo.cs | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/IssueTimelineClientTests.cs b/Octokit.Tests.Integration/Clients/IssueTimelineClientTests.cs index 355dd951..f7576fcf 100644 --- a/Octokit.Tests.Integration/Clients/IssueTimelineClientTests.cs +++ b/Octokit.Tests.Integration/Clients/IssueTimelineClientTests.cs @@ -82,7 +82,7 @@ namespace Octokit.Tests.Integration.Clients { var timelineEventInfos = await _issueTimelineClient.GetAllForIssue("microsoft", "vscode", issue.Number); - Assert.NotNull(timelineEventInfos); + Assert.NotEmpty(timelineEventInfos); } } diff --git a/Octokit/Models/Response/EventInfo.cs b/Octokit/Models/Response/EventInfo.cs index b15f1c2a..cda75079 100644 --- a/Octokit/Models/Response/EventInfo.cs +++ b/Octokit/Models/Response/EventInfo.cs @@ -214,13 +214,11 @@ namespace Octokit /// /// A line comment was made. /// - [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Linecommented")] - Linecommented, + LineCommented, /// /// A commit comment was made. /// - [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Commitcommented")] - Commitcommented + CommitCommented } }