From a9514e30b8bcd35d641017fe69cc2b85ea517900 Mon Sep 17 00:00:00 2001 From: Haacked Date: Mon, 4 Nov 2013 13:16:50 -0800 Subject: [PATCH] Add code analysis to Release build This should make it so code analysis build runs on the CI server. Previously, it was only set for Debug builds. --- Octokit.Reactive/Octokit.Reactive.csproj | 4 +++- Octokit.Reactive/Properties/AssemblyInfo.cs | 4 +++- Octokit/Octokit-netcore45.csproj | 4 ++++ Octokit/Octokit.csproj | 4 +++- Octokit/Properties/AssemblyInfo.cs | 2 ++ SolutionInfo.cs | 8 +++++--- 6 files changed, 20 insertions(+), 6 deletions(-) diff --git a/Octokit.Reactive/Octokit.Reactive.csproj b/Octokit.Reactive/Octokit.Reactive.csproj index e52fe16b..cb921381 100644 --- a/Octokit.Reactive/Octokit.Reactive.csproj +++ b/Octokit.Reactive/Octokit.Reactive.csproj @@ -36,6 +36,8 @@ prompt 4 false + true + ..\Octokit.ruleset @@ -131,4 +133,4 @@ --> - + \ No newline at end of file diff --git a/Octokit.Reactive/Properties/AssemblyInfo.cs b/Octokit.Reactive/Properties/AssemblyInfo.cs index 364f327f..ca0dff58 100644 --- a/Octokit.Reactive/Properties/AssemblyInfo.cs +++ b/Octokit.Reactive/Properties/AssemblyInfo.cs @@ -1,4 +1,6 @@ using System.Reflection; +using System.Runtime.InteropServices; [assembly: AssemblyTitle("Octokit.Reactive")] -[assembly: AssemblyDescription("An IObservable based GitHub API client library for .NET using Reactive Extensions")] \ No newline at end of file +[assembly: AssemblyDescription("An IObservable based GitHub API client library for .NET using Reactive Extensions")] +[assembly: ComVisible(false)] \ No newline at end of file diff --git a/Octokit/Octokit-netcore45.csproj b/Octokit/Octokit-netcore45.csproj index e50d4fbd..afaef826 100644 --- a/Octokit/Octokit-netcore45.csproj +++ b/Octokit/Octokit-netcore45.csproj @@ -24,6 +24,8 @@ prompt 4 true + true + ..\Octokit.ruleset pdbonly @@ -33,6 +35,8 @@ TRACE;NETFX_CORE;CODE_ANALYSIS;SIMPLE_JSON_OBJARRAYINTERNAL;SIMPLE_JSON_INTERNAL;NET_45 prompt 4 + true + ..\Octokit.ruleset diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj index 86090de0..ebf27466 100644 --- a/Octokit/Octokit.csproj +++ b/Octokit/Octokit.csproj @@ -37,6 +37,8 @@ prompt 4 false + true + ..\Octokit.ruleset @@ -210,4 +212,4 @@ --> - + \ No newline at end of file diff --git a/Octokit/Properties/AssemblyInfo.cs b/Octokit/Properties/AssemblyInfo.cs index 95d2ea00..4e4691d0 100644 --- a/Octokit/Properties/AssemblyInfo.cs +++ b/Octokit/Properties/AssemblyInfo.cs @@ -1,7 +1,9 @@ using System.Reflection; using System.Runtime.CompilerServices; +using System.Runtime.InteropServices; [assembly: AssemblyTitle("Octokit")] [assembly: AssemblyDescription("An async-based GitHub API client library for .NET")] +[assembly: ComVisible(false)] [assembly: InternalsVisibleTo("Octokit.Tests")] [assembly: InternalsVisibleTo("Octokit.Tests-NetCore45")] \ No newline at end of file diff --git a/SolutionInfo.cs b/SolutionInfo.cs index 79e54730..30e43382 100644 --- a/SolutionInfo.cs +++ b/SolutionInfo.cs @@ -4,6 +4,8 @@ using System.Reflection; [assembly: AssemblyProductAttribute("Octokit")] [assembly: AssemblyVersionAttribute("0.1.2")] [assembly: AssemblyFileVersionAttribute("0.1.2")] - -class AssemblyVersionInformation { public const string Version = "0.1.2"; } - +namespace System { + internal static class AssemblyVersionInformation { + internal const string Version = "0.1.2"; + } +}