From a988ad166a7684cfdb0d8426984a6f366ac3b19d Mon Sep 17 00:00:00 2001 From: Abdelkhalek Oussama Elhamer Date: Wed, 23 Mar 2016 18:59:18 +0100 Subject: [PATCH] Add GetAll with options overload to IObservableCommitStatusClient + Implementation --- .../Clients/IObservableCommitStatusClient.cs | 12 ++++++++++ .../Clients/ObservableCommitStatusClient.cs | 24 +++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/Octokit.Reactive/Clients/IObservableCommitStatusClient.cs b/Octokit.Reactive/Clients/IObservableCommitStatusClient.cs index d2168f80..b1a970fb 100644 --- a/Octokit.Reactive/Clients/IObservableCommitStatusClient.cs +++ b/Octokit.Reactive/Clients/IObservableCommitStatusClient.cs @@ -15,6 +15,18 @@ namespace Octokit.Reactive /// IObservable GetAll(string owner, string name, string reference); + /// + /// Retrieves commit statuses for the specified reference. A reference can be a commit SHA, a branch name, or + /// a tag name. + /// + /// Only users with pull access can see this. + /// The owner of the repository + /// The name of the repository + /// The reference (SHA, branch name, or tag name) to list commits for + /// Options for changing the API response + /// + IObservable GetAll(string owner, string name, string reference, ApiOptions options); + /// /// Retrieves a combined view of statuses for the specified reference. A reference can be a commit SHA, a branch name, or /// a tag name. diff --git a/Octokit.Reactive/Clients/ObservableCommitStatusClient.cs b/Octokit.Reactive/Clients/ObservableCommitStatusClient.cs index b6390bc1..bf4b092f 100644 --- a/Octokit.Reactive/Clients/ObservableCommitStatusClient.cs +++ b/Octokit.Reactive/Clients/ObservableCommitStatusClient.cs @@ -28,9 +28,33 @@ namespace Octokit.Reactive /// public IObservable GetAll(string owner, string name, string reference) { + Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + return _connection.GetAndFlattenAllPages(ApiUrls.CommitStatuses(owner, name, reference)); } + /// + /// Retrieves commit statuses for the specified reference. A reference can be a commit SHA, a branch name, or + /// a tag name. + /// + /// Only users with pull access can see this. + /// The owner of the repository + /// The name of the repository + /// The reference (SHA, branch name, or tag name) to list commits for + /// Options for changing the API response + /// + public IObservable GetAll(string owner, string name, string reference, ApiOptions options) + { + Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); + Ensure.ArgumentNotNullOrEmptyString(name, "name"); + Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); + Ensure.ArgumentNotNull(options, "options"); + + return _connection.GetAndFlattenAllPages(ApiUrls.CommitStatuses(owner, name, reference),options); + } + /// /// Retrieves a combined view of statuses for the specified reference. A reference can be a commit SHA, a branch name, or /// a tag name.