Merge pull request #1079 from octokit/obsolete-revoke-authorization

Revoke All Authentications no longer supported by the API
This commit is contained in:
Brendan Forster
2016-02-02 18:16:36 +10:30
5 changed files with 7 additions and 1 deletions
@@ -209,6 +209,7 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="clientId">ClientID of the OAuth application for the token</param>
/// <returns></returns>
[Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
IObservable<Unit> RevokeAllApplicationAuthentications(string clientId);
/// <summary>
@@ -294,6 +294,7 @@ namespace Octokit.Reactive
/// </remarks>
/// <param name="clientId">ClientID of the OAuth application for the token</param>
/// <returns></returns>
[Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
public IObservable<Unit> RevokeAllApplicationAuthentications(string clientId)
{
Ensure.ArgumentNotNullOrEmptyString("clientId", clientId);
@@ -204,7 +204,7 @@ namespace Octokit.Tests.Integration.Clients
Assert.ThrowsAsync<NotFoundException>(() => github.Authorization.Get(created.Id));
}
[BasicAuthenticationTest]
[BasicAuthenticationTest(Skip = "See https://github.com/octokit/octokit.net/issues/1078 for explanation of why this is now obsolete")]
public async Task CanRevokeAllApplicationAuthentications()
{
var github = Helper.GetBasicAuthClient();
+2
View File
@@ -1,4 +1,5 @@
using System.Threading.Tasks;
using System;
#if NET_45
using System.Collections.Generic;
#endif
@@ -380,6 +381,7 @@ namespace Octokit
/// </remarks>
/// <param name="clientId">ClientID of the OAuth application for the token</param>
/// <returns>A <see cref="Task"/> for the request's execution.</returns>
[Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
public Task RevokeAllApplicationAuthentications(string clientId)
{
Ensure.ArgumentNotNullOrEmptyString(clientId, "clientId");
+2
View File
@@ -1,5 +1,6 @@
using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
using System;
#if NET_45
using System.Collections.Generic;
#endif
@@ -229,6 +230,7 @@ namespace Octokit
/// </remarks>
/// <param name="clientId">ClientID of the OAuth application for the token</param>
/// <returns>A <see cref="Task"/> for the request's execution.</returns>
[Obsolete("This feature is no longer supported in the GitHub API and will be removed in a future release")]
Task RevokeAllApplicationAuthentications(string clientId);
/// <summary>