diff --git a/Octokit.Tests/Clients/TeamsClientTests.cs b/Octokit.Tests/Clients/TeamsClientTests.cs index a99513e0..3ca76d5f 100644 --- a/Octokit.Tests/Clients/TeamsClientTests.cs +++ b/Octokit.Tests/Clients/TeamsClientTests.cs @@ -165,7 +165,7 @@ namespace Octokit.Tests.Clients connection.Received().Put>( Arg.Is(u => u.ToString() == "teams/1/memberships/user"), - Arg.Is(u => u == ApiConnection.EmptyBody)); + Arg.Is(u => u == RequestBody.Empty)); } [Fact] diff --git a/Octokit.Tests/Http/ConnectionTests.cs b/Octokit.Tests/Http/ConnectionTests.cs index 64fae48a..eebc34d8 100644 --- a/Octokit.Tests/Http/ConnectionTests.cs +++ b/Octokit.Tests/Http/ConnectionTests.cs @@ -371,7 +371,7 @@ namespace Octokit.Tests.Http [Fact] public async Task MakesPutRequestWithNoData() { - var body = ApiConnection.EmptyBody; + var body = RequestBody.Empty; var expectedBody = SimpleJson.SerializeObject(body); var httpClient = Substitute.For(); IResponse response = new Response(); @@ -421,7 +421,7 @@ namespace Octokit.Tests.Http [Fact] public async Task MakesPutRequestWithNoDataAndTwoFactor() { - var body = ApiConnection.EmptyBody ; + var body = RequestBody.Empty; var expectedBody = SimpleJson.SerializeObject(body); var httpClient = Substitute.For(); IResponse response = new Response(); diff --git a/Octokit/Clients/TeamsClient.cs b/Octokit/Clients/TeamsClient.cs index d2a5288c..00235814 100644 --- a/Octokit/Clients/TeamsClient.cs +++ b/Octokit/Clients/TeamsClient.cs @@ -164,7 +164,7 @@ namespace Octokit try { - response = await ApiConnection.Put>(endpoint, Octokit.ApiConnection.EmptyBody); + response = await ApiConnection.Put>(endpoint, RequestBody.Empty); } catch (NotFoundException) { diff --git a/Octokit/Http/ApiConnection.cs b/Octokit/Http/ApiConnection.cs index b9db71d3..9b1656f5 100644 --- a/Octokit/Http/ApiConnection.cs +++ b/Octokit/Http/ApiConnection.cs @@ -15,9 +15,6 @@ namespace Octokit { readonly IApiPagination _pagination; - [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA2211:NonConstantFieldsShouldNotBeVisible")] - public static object EmptyBody = new object(); - /// /// Initializes a new instance of the class. /// diff --git a/Octokit/Http/RequestBody.cs b/Octokit/Http/RequestBody.cs new file mode 100644 index 00000000..346e71d1 --- /dev/null +++ b/Octokit/Http/RequestBody.cs @@ -0,0 +1,12 @@ +namespace Octokit +{ + /// + /// Container for the static method that represents an + /// intentional empty request body to avoid overloading null. + /// + public static class RequestBody + { + [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Usage", "CA2211:NonConstantFieldsShouldNotBeVisible")] + public static object Empty = new object(); + } +} \ No newline at end of file diff --git a/Octokit/Octokit-Mono.csproj b/Octokit/Octokit-Mono.csproj index 64daa005..8b5eedac 100644 --- a/Octokit/Octokit-Mono.csproj +++ b/Octokit/Octokit-Mono.csproj @@ -399,6 +399,7 @@ + \ No newline at end of file diff --git a/Octokit/Octokit-MonoAndroid.csproj b/Octokit/Octokit-MonoAndroid.csproj index 9002587a..a34a7b1e 100644 --- a/Octokit/Octokit-MonoAndroid.csproj +++ b/Octokit/Octokit-MonoAndroid.csproj @@ -415,6 +415,7 @@ + \ No newline at end of file diff --git a/Octokit/Octokit-Monotouch.csproj b/Octokit/Octokit-Monotouch.csproj index 607ec595..3f4b6f9c 100644 --- a/Octokit/Octokit-Monotouch.csproj +++ b/Octokit/Octokit-Monotouch.csproj @@ -408,6 +408,7 @@ + diff --git a/Octokit/Octokit-Portable.csproj b/Octokit/Octokit-Portable.csproj index 74f211df..36e840bd 100644 --- a/Octokit/Octokit-Portable.csproj +++ b/Octokit/Octokit-Portable.csproj @@ -398,6 +398,7 @@ + diff --git a/Octokit/Octokit-netcore45.csproj b/Octokit/Octokit-netcore45.csproj index 944bb681..17d8bae8 100644 --- a/Octokit/Octokit-netcore45.csproj +++ b/Octokit/Octokit-netcore45.csproj @@ -402,6 +402,7 @@ + diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj index 60a9607f..760b5bfe 100644 --- a/Octokit/Octokit.csproj +++ b/Octokit/Octokit.csproj @@ -85,6 +85,7 @@ +