zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-20 14:15:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix convention errors

Browse Source
This commit is contained in:
Mordechai Zuber
2016-01-21 07:31:32 +02:00
parent e690e22637
commit c113292f5b
8 changed files with 40 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Octokit.Reactive/Clients/IObservableRepositoryPagesClient.cs
View File

@@ -25,7 +25,7 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/pages/#list-pages-builds">API documentation</a> for more information.
/// </remarks>
/// <returns></returns>
IObservable<PagesBuild> GetBuilds(string owner, string repositoryName);
IObservable<PagesBuild> GetAllBuilds(string owner, string repositoryName);
/// <summary>
/// Gets the build metadata for the last build for a given repository
/// </summary>

2
Octokit.Reactive/Clients/ObservableRepositoryPagesClient.cs
View File

@@ -45,7 +45,7 @@ namespace Octokit.Reactive
/// See the <a href="https://developer.github.com/v3/repos/pages/#list-pages-builds">API documentation</a> for more information.
/// </remarks>
/// <returns></returns>
public IObservable<PagesBuild> GetBuilds(string owner, string repositoryName)
public IObservable<PagesBuild> GetAllBuilds(string owner, string repositoryName)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");

2
Octokit.Tests/Clients/RepositoryPagesClientTests.cs
View File

@@ -39,7 +39,7 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>();
var client = new RepositoryPagesClient(connection);
client.GetBuilds("fake", "repo");
client.GetAllBuilds("fake", "repo");
connection.Received().GetAll<PagesBuild>(Arg.Is<Uri>(u => u.ToString() == "repos/fake/repo/pages/builds"));
}

2
Octokit/Clients/IRepositoryPagesClient.cs
View File

@@ -32,7 +32,7 @@ namespace Octokit
/// See the <a href="https://developer.github.com/v3/repos/pages/#list-pages-builds">API documentation</a> for more information.
/// </remarks>
/// <returns></returns>
Task<IReadOnlyList<PagesBuild>> GetBuilds(string owner, string repositoryName);
Task<IReadOnlyList<PagesBuild>> GetAllBuilds(string owner, string repositoryName);
/// <summary>
/// Gets the build metadata for the last build for a given repository
/// </summary>

2
Octokit/Clients/RepositoryPagesClient.cs
View File

@@ -46,7 +46,7 @@ namespace Octokit
/// See the <a href="https://developer.github.com/v3/repos/pages/#list-pages-builds">API documentation</a> for more information.
/// </remarks>
/// <returns></returns>
public Task<IReadOnlyList<PagesBuild>> GetBuilds(string owner, string repositoryName)
public Task<IReadOnlyList<PagesBuild>> GetAllBuilds(string owner, string repositoryName)
{
Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(repositoryName, "repositoryName");

11
Octokit/Models/Response/ApiError.cs
View File

@@ -1,5 +1,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Globalization;
namespace Octokit
{
@@ -9,6 +11,7 @@ namespace Octokit
#if !NETFX_CORE
[Serializable]
#endif
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class ApiError
{
public ApiError() { }
@@ -39,5 +42,13 @@ namespace Octokit
/// Additional details about the error
/// </summary>
public IReadOnlyList<ApiErrorDetail> Errors { get; protected set; }
internal string DebuggerDisplay
{
get
{
return string.Format(CultureInfo.InvariantCulture, "Message: {0}", Message);
}
}
}
}

11
Octokit/Models/Response/ApiErrorDetail.cs
View File

@@ -1,10 +1,13 @@
using System;
using System.Diagnostics;
using System.Globalization;
namespace Octokit
{
#if !NETFX_CORE
[Serializable]
#endif
[DebuggerDisplay("{DebuggerDisplay,nq}")]
public class ApiErrorDetail
{
public ApiErrorDetail() { }
@@ -24,5 +27,13 @@ namespace Octokit
public string Field { get; protected set; }
public string Resource { get; protected set; }
internal string DebuggerDisplay
{
get
{
return string.Format(CultureInfo.InvariantCulture, "Message: {0}, Code: {1}, Field: {2}", Message, Code, Field);
}
}
}
}

14
Octokit/Models/Response/PagesBuild.cs
View File

@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
using System.Globalization;
namespace Octokit
{
@@ -31,7 +32,10 @@ namespace Octokit
/// The status of the build.
/// </summary>
public PagesBuildStatus Status { get; protected set; }
public ApiError Error { get; set; }
/// <summary>
///
/// </summary>
public ApiError Error { get; protected set; }
/// <summary>
/// The user whose commit intiated the build.
/// </summary>
@@ -46,5 +50,13 @@ namespace Octokit
public TimeSpan Duration { get; protected set; }
public DateTime CreatedAt { get; protected set; }
public DateTime UpdatedAt { get; protected set; }
internal string DebuggerDisplay
{
get
{
return string.Format(CultureInfo.InvariantCulture, "Pusher: {0}, Status: {1}, Duration: {2}", Pusher.Name, Status.ToString(), Duration.TotalMilliseconds);
}
}
}
}