Revert "removed GetAllPublic overload due to paging issue and parameters clobbering"

This reverts commit 26a8bf0e81.

Octokit.Reactive/Clients/IObservableRepositoriesClient.cs

@@ -50,6 +50,18 @@ namespace Octokit.Reactive
             Justification = "Makes a network request")]
         IObservable<Repository> GetAllPublic();
 
+        /// <summary>
+        /// Retrieves every public <see cref="Repository"/> since the last repository seen.
+        /// </summary>
+        /// <remarks>
+        /// The default page size on GitHub.com is 30.
+        /// </remarks>
+        /// <param name="request">Search parameters of the last repository seen</param>
+        /// <returns>A <see cref="IReadOnlyPagedCollection{Repository}"/> of <see cref="Repository"/>.</returns>
+        [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate",
+            Justification = "Makes a network request")]
+        IObservable<Repository> GetAllPublic(PublicRepositoryRequest request);
+
         /// <summary>
         /// Retrieves every <see cref="Repository"/> that belongs to the current user.
         /// </summary>

Octokit.Reactive/Clients/ObservableRepositoriesClient.cs

@@ -102,6 +102,21 @@ namespace Octokit.Reactive
             return _connection.GetAndFlattenAllPages<Repository>(ApiUrls.AllPublicRepositories());
         }
 
+        /// <summary>
+        /// Retrieves every public <see cref="Repository"/> since the last repository seen.
+        /// </summary>
+        /// <remarks>
+        /// The default page size on GitHub.com is 30.
+        /// </remarks>
+        /// <param name="request">Search parameters of the last repository seen</param>
+        /// <returns>A <see cref="IReadOnlyPagedCollection{Repository}"/> of <see cref="Repository"/>.</returns>
+        public IObservable<Repository> GetAllPublic(PublicRepositoryRequest request)
+        {
+            Ensure.ArgumentNotNull(request, "request");
+
+            return _connection.GetAndFlattenAllPages<Repository>(ApiUrls.AllPublicRepositories(), request.ToParametersDictionary());
+        }
+
         /// <summary>
         /// Retrieves every <see cref="Repository"/> that belongs to the current user.
         /// </summary>

Octokit.Tests.Integration/Clients/RepositoriesClientTests.cs

@@ -553,20 +553,20 @@ public class RepositoriesClientTests
             Assert.True(repositories.Count > 80);
         }
 
-        //[IntegrationTest]
+        [IntegrationTest]
-        //public async Task ReturnsAllPublicRepositoriesSinceLastSeen()
+        public async Task ReturnsAllPublicRepositoriesSinceLastSeen()
-        //{
+        {
-        //    var github = Helper.GetAuthenticatedClient();
+            var github = Helper.GetAuthenticatedClient();
 
-        //    var request = new PublicRepositoryRequest(32732250);
+            var request = new PublicRepositoryRequest(32732250);
-        //    var repositories = await github.Repository.GetAllPublic(request);
+            var repositories = await github.Repository.GetAllPublic(request);
 
-        //    Assert.NotNull(repositories);
+            Assert.NotNull(repositories);
-        //    Assert.True(repositories.Any());
+            Assert.True(repositories.Any());
-        //    Assert.Equal(32732252, repositories[0].Id);
+            Assert.Equal(32732252, repositories[0].Id);
-        //    Assert.False(repositories[0].Private);
+            Assert.False(repositories[0].Private);
-        //    Assert.Equal("zad19", repositories[0].Name);
+            Assert.Equal("zad19", repositories[0].Name);
-        //}
+        }
     }
 
     public class TheGetAllForOrgMethod

Octokit.Tests.Integration/Reactive/ObservableRepositoriesClientTests.cs

@@ -28,5 +28,22 @@ namespace Octokit.Tests.Integration
                 Assert.False(repository2.Fork);
             }
         }
+
+        public class TheGetAllPublicSinceMethod
+        {
+            [IntegrationTest(Skip = "This will take a very long time to return, so will skip it for now.")]
+            public async Task ReturnsAllPublicReposSinceLastSeen()
+            {
+                var github = Helper.GetAuthenticatedClient();
+
+                var client = new ObservableRepositoriesClient(github);
+                var request = new PublicRepositoryRequest(32732250);
+                var repositories = await client.GetAllPublic(request).ToArray();
+                Assert.NotEmpty(repositories);
+                Assert.Equal(32732252, repositories[0].Id);
+                Assert.False(repositories[0].Private);
+                Assert.Equal("zad19", repositories[0].Name);
+            }
+        }
     }
 }

Octokit.Tests/Clients/RepositoriesClientTests.cs

@@ -273,6 +273,37 @@ namespace Octokit.Tests.Clients
             } 
         }
 
+
+        public class TheGetAllPublicSinceMethod
+        {
+            [Fact]
+            public void RequestsTheCorrectUrl()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new RepositoriesClient(connection);
+
+                client.GetAllPublic(new PublicRepositoryRequest(364));
+
+                connection.Received()
+                    .GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),
+                        Arg.Any<Dictionary<string, string>>());
+            }
+
+            [Fact]
+            public void SendsTheCorrectParameter()
+            {
+                var connection = Substitute.For<IApiConnection>();
+                var client = new RepositoriesClient(connection);
+
+                client.GetAllPublic(new PublicRepositoryRequest(364));
+
+                connection.Received()
+                    .GetAll<Repository>(Arg.Is<Uri>(u => u.ToString() == "/repositories"),
+                        Arg.Is<Dictionary<string, string>>(d => d.Count == 1
+                            && d["since"] == "364"));
+            }
+        }
+
         public class TheGetAllForCurrentMethod
         {
             [Fact]

Octokit.Tests/Reactive/ObservableRepositoriesClientTests.cs

@@ -158,6 +158,65 @@ namespace Octokit.Tests.Reactive
             }
         }
 
+        public class TheGetAllPublicRepositoriesSinceMethod
+        {
+            [Fact]
+            public async Task ReturnsEveryPageOfRepositories()
+            {
+                var firstPageUrl = new Uri("/repositories", UriKind.Relative);
+                var secondPageUrl = new Uri("https://example.com/page/2");
+                var firstPageLinks = new Dictionary<string, Uri> { { "next", secondPageUrl } };
+                IApiResponse<List<Repository>> firstPageResponse = new ApiResponse<List<Repository>>(
+                    CreateResponseWithApiInfo(firstPageLinks),
+                    new List<Repository>
+                    {
+                        new Repository(364),
+                        new Repository(365),
+                        new Repository(366)
+                    });
+                
+                var thirdPageUrl = new Uri("https://example.com/page/3");
+                var secondPageLinks = new Dictionary<string, Uri> { { "next", thirdPageUrl } };
+                IApiResponse<List<Repository>> secondPageResponse = new ApiResponse<List<Repository>>
+                (
+                    CreateResponseWithApiInfo(secondPageLinks),
+                    new List<Repository>
+                    {
+                        new Repository(367),
+                        new Repository(368),
+                        new Repository(369)
+                    });
+
+                IApiResponse<List<Repository>> lastPageResponse = new ApiResponse<List<Repository>>(
+                    new Response(),
+                    new List<Repository>
+                    {
+                        new Repository(370)
+                    });
+
+                var gitHubClient = Substitute.For<IGitHubClient>();
+                gitHubClient.Connection.Get<List<Repository>>(firstPageUrl,
+                    Arg.Is<Dictionary<string, string>>(d => d.Count == 1
+                        && d["since"] == "364"), null)
+                    .Returns(Task.FromResult(firstPageResponse));
+                gitHubClient.Connection.Get<List<Repository>>(secondPageUrl, null, null)
+                    .Returns(Task.FromResult(secondPageResponse));
+                gitHubClient.Connection.Get<List<Repository>>(thirdPageUrl, null, null)
+                    .Returns(Task.FromResult(lastPageResponse));
+
+                var repositoriesClient = new ObservableRepositoriesClient(gitHubClient);
+
+                var results = await repositoriesClient.GetAllPublic(new PublicRepositoryRequest(364)).ToArray();
+
+                Assert.Equal(7, results.Length);
+                gitHubClient.Connection.Received(1).Get<List<Repository>>(firstPageUrl, 
+                    Arg.Is<Dictionary<string, string>>(d=>d.Count == 1
+                    && d["since"] == "364"), null);
+                gitHubClient.Connection.Received(1).Get<List<Repository>>(secondPageUrl, null, null);
+                gitHubClient.Connection.Received(1).Get<List<Repository>>(thirdPageUrl, null, null);
+            }
+        }
+
         public class TheGetAllBranchesMethod
         {
             [Fact]

Octokit/Clients/IRepositoriesClient.cs

@@ -109,6 +109,20 @@ namespace Octokit
             Justification = "Makes a network request")]
         Task<IReadOnlyList<Repository>> GetAllPublic();
 
+
+        /// <summary>
+        /// Gets all public repositories since the integer ID of the last Repository that you've seen.
+        /// </summary>
+        /// <remarks>
+        /// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.
+        /// The default page size on GitHub.com is 30.
+        /// </remarks>
+        /// <param name="request">Search parameters of the last repository seen</param>
+        /// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
+        /// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
+        /// <returns>A <see cref="IReadOnlyPagedCollection{Repository}"/> of <see cref="Repository"/>.</returns>
+        Task<IReadOnlyList<Repository>> GetAllPublic(PublicRepositoryRequest request);
+
         /// <summary>
         /// Gets all repositories owned by the current user.
         /// </summary>

Octokit/Clients/RepositoriesClient.cs

@@ -188,6 +188,24 @@ namespace Octokit
             return ApiConnection.GetAll<Repository>(ApiUrls.AllPublicRepositories());
         }
 
+        /// <summary>
+        /// Gets all public repositories since the integer ID of the last Repository that you've seen.
+        /// </summary>
+        /// <remarks>
+        /// See the <a href="https://developer.github.com/v3/repos/#list-all-public-repositories">API documentation</a> for more information.
+        /// The default page size on GitHub.com is 30.
+        /// </remarks>
+        /// <param name="request">Search parameters of the last repository seen</param>
+        /// <exception cref="AuthorizationException">Thrown if the client is not authenticated.</exception>
+        /// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
+        /// <returns>A <see cref="IReadOnlyPagedCollection{Repository}"/> of <see cref="Repository"/>.</returns>
+        public Task<IReadOnlyList<Repository>> GetAllPublic(PublicRepositoryRequest request)
+        {
+            Ensure.ArgumentNotNull(request, "request");
+
+            return ApiConnection.GetAll<Repository>(ApiUrls.AllPublicRepositories(), request.ToParametersDictionary());
+        }
+
         /// <summary>
         /// Gets all repositories owned by the current user.
         /// </summary>