From c5600ce37b4ab7693e3f1f8cc91bf4880537cebb Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Wed, 6 Apr 2016 20:10:20 -0400 Subject: [PATCH] and a couple more awaits for necessary internals --- Octokit/Helpers/ReferenceExtensions.cs | 6 +++--- Octokit/Http/ApiConnection.cs | 2 +- Octokit/Http/HttpClientAdapter.cs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Octokit/Helpers/ReferenceExtensions.cs b/Octokit/Helpers/ReferenceExtensions.cs index 93bd4f70..1c79f503 100644 --- a/Octokit/Helpers/ReferenceExtensions.cs +++ b/Octokit/Helpers/ReferenceExtensions.cs @@ -29,7 +29,7 @@ namespace Octokit.Helpers throw new ArgumentException(String.Format(CultureInfo.InvariantCulture, "The specified branch name '{0}' appears to be a ref name and not a branch name because it starts with the string 'refs/heads'. Either specify just the branch name or use the Create method if you need to specify the full ref name", branchName), "branchName"); } - return await referencesClient.Create(owner, name, new NewReference("refs/heads/" + branchName, baseReference.Object.Sha)); + return await referencesClient.Create(owner, name, new NewReference("refs/heads/" + branchName, baseReference.Object.Sha)).ConfigureAwait(false); } /// @@ -50,8 +50,8 @@ namespace Octokit.Helpers throw new ArgumentException(String.Format(CultureInfo.InvariantCulture, "The specified branch name '{0}' appears to be a ref name and not a branch name because it starts with the string 'refs/heads'. Either specify just the branch name or use the Create method if you need to specify the full ref name", branchName), "branchName"); } - var baseBranch = await referencesClient.Get(owner, name, "heads/master"); - return await referencesClient.Create(owner, name, new NewReference("refs/heads/" + branchName, baseBranch.Object.Sha)); + var baseBranch = await referencesClient.Get(owner, name, "heads/master").ConfigureAwait(false); + return await referencesClient.Create(owner, name, new NewReference("refs/heads/" + branchName, baseBranch.Object.Sha)).ConfigureAwait(false); } } } diff --git a/Octokit/Http/ApiConnection.cs b/Octokit/Http/ApiConnection.cs index a08a8aeb..b4b1192c 100644 --- a/Octokit/Http/ApiConnection.cs +++ b/Octokit/Http/ApiConnection.cs @@ -494,7 +494,7 @@ namespace Octokit public async Task GetRedirect(Uri uri) { Ensure.ArgumentNotNull(uri, "uri"); - var response = await Connection.GetRedirect(uri); + var response = await Connection.GetRedirect(uri).ConfigureAwait(false); if (response.HttpResponse.StatusCode == HttpStatusCode.Redirect) { diff --git a/Octokit/Http/HttpClientAdapter.cs b/Octokit/Http/HttpClientAdapter.cs index 1c6a65a5..bbc9ca80 100644 --- a/Octokit/Http/HttpClientAdapter.cs +++ b/Octokit/Http/HttpClientAdapter.cs @@ -178,7 +178,7 @@ namespace Octokit.Internal protected override async Task SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) { - var response = await base.SendAsync(request, cancellationToken); + var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false); // Can't redirect without somewhere to redirect too. Throw? if (response.Headers.Location == null) return response;