diff --git a/Octokit/Exceptions/InvalidGitignoreTemplateException.cs b/Octokit/Exceptions/InvalidGitignoreTemplateException.cs index f8016962..5919cfd1 100644 --- a/Octokit/Exceptions/InvalidGitignoreTemplateException.cs +++ b/Octokit/Exceptions/InvalidGitignoreTemplateException.cs @@ -22,7 +22,6 @@ namespace Octokit /// Constructs an instance of ApiValidationException /// public InvalidGitIgnoreTemplateException() - : base() { } /// diff --git a/Octokit/Helpers/CollectionExtensions.cs b/Octokit/Helpers/CollectionExtensions.cs index 336d337a..74548d98 100644 --- a/Octokit/Helpers/CollectionExtensions.cs +++ b/Octokit/Helpers/CollectionExtensions.cs @@ -16,34 +16,18 @@ namespace Octokit public static IList Clone(this IReadOnlyList input) { - List output = null; if (input == null) - return output; + return null; - output = new List(); - - foreach (var item in input) - { - output.Add(new String(item.ToCharArray())); - } - - return output; + return input.Select(item => new String(item.ToCharArray())).ToList(); } public static IDictionary Clone(this IReadOnlyDictionary input) { - Dictionary output = null; if (input == null) - return output; + return null; - output = new Dictionary(); - - foreach (var item in input) - { - output.Add(new String(item.Key.ToCharArray()), new Uri(item.Value.ToString())); - } - - return output; + return input.ToDictionary(item => new String(item.Key.ToCharArray()), item => new Uri(item.Value.ToString())); } } } diff --git a/Octokit/Helpers/StringExtensions.cs b/Octokit/Helpers/StringExtensions.cs index f195d405..fd2d9175 100644 --- a/Octokit/Helpers/StringExtensions.cs +++ b/Octokit/Helpers/StringExtensions.cs @@ -51,7 +51,7 @@ namespace Octokit if (optionalQueryStringMatch.Success) { var expansion = string.Empty; - var parameters = optionalQueryStringMatch.Groups[1].Value.Split(new char[] { ',' }); + var parameters = optionalQueryStringMatch.Groups[1].Value.Split(','); foreach (var parameter in parameters) { diff --git a/Octokit/Http/ApiInfo.cs b/Octokit/Http/ApiInfo.cs index b053b3fc..505a5752 100644 --- a/Octokit/Http/ApiInfo.cs +++ b/Octokit/Http/ApiInfo.cs @@ -60,14 +60,14 @@ namespace Octokit { // Seem to have to do this to pass a whole bunch of tests (for example Octokit.Tests.Clients.EventsClientTests.DeserializesCommitCommentEventCorrectly) // I believe this has something to do with the Mocking framework. - if (this.Links == null || this.OauthScopes == null || this.RateLimit == null || this.Etag == null) + if (Links == null || OauthScopes == null || RateLimit == null || Etag == null) return null; - return new ApiInfo(this.Links.Clone(), - this.OauthScopes.Clone(), - this.AcceptedOauthScopes.Clone(), + return new ApiInfo(Links.Clone(), + OauthScopes.Clone(), + AcceptedOauthScopes.Clone(), new String(this.Etag.ToCharArray()), - this.RateLimit.Clone()); + RateLimit.Clone()); } } } diff --git a/Octokit/Http/HttpClientAdapter.cs b/Octokit/Http/HttpClientAdapter.cs index af02007e..d2f855b6 100644 --- a/Octokit/Http/HttpClientAdapter.cs +++ b/Octokit/Http/HttpClientAdapter.cs @@ -230,7 +230,7 @@ namespace Octokit.Internal { newRequest.Headers.Authorization = null; } - response = await this.SendAsync(newRequest, cancellationToken); + response = await SendAsync(newRequest, cancellationToken); } return response; diff --git a/Octokit/Http/RateLimit.cs b/Octokit/Http/RateLimit.cs index aa23befc..2ed4249f 100644 --- a/Octokit/Http/RateLimit.cs +++ b/Octokit/Http/RateLimit.cs @@ -108,9 +108,9 @@ namespace Octokit { return new RateLimit { - Limit = this.Limit, - Remaining = this.Remaining, - ResetAsUtcEpochSeconds = this.ResetAsUtcEpochSeconds + Limit = Limit, + Remaining = Remaining, + ResetAsUtcEpochSeconds = ResetAsUtcEpochSeconds }; } } diff --git a/Octokit/Models/Response/ActivityPayloads/ActivityPayload.cs b/Octokit/Models/Response/ActivityPayloads/ActivityPayload.cs index 9e2cdfd1..99a9639a 100644 --- a/Octokit/Models/Response/ActivityPayloads/ActivityPayload.cs +++ b/Octokit/Models/Response/ActivityPayloads/ActivityPayload.cs @@ -10,7 +10,7 @@ namespace Octokit internal string DebuggerDisplay { - get { return this.Repository.FullName; } + get { return Repository.FullName; } } } }