diff --git a/Octokit.Tests.Integration/Clients/DeploymentStatusClientTests.cs b/Octokit.Tests.Integration/Clients/DeploymentStatusClientTests.cs index a7f26489..f7ab6835 100644 --- a/Octokit.Tests.Integration/Clients/DeploymentStatusClientTests.cs +++ b/Octokit.Tests.Integration/Clients/DeploymentStatusClientTests.cs @@ -11,7 +11,7 @@ public class DeploymentStatusClientTests : IDisposable IDeploymentsClient _deploymentsClient; Repository _repository; Commit _commit; - GitDeployment _deployment; + Deployment _deployment; string _repositoryOwner; public DeploymentStatusClientTests() diff --git a/Octokit.Tests/Clients/DeploymentsClientTests.cs b/Octokit.Tests/Clients/DeploymentsClientTests.cs index 21f97ec0..b1e73f17 100644 --- a/Octokit.Tests/Clients/DeploymentsClientTests.cs +++ b/Octokit.Tests/Clients/DeploymentsClientTests.cs @@ -52,7 +52,7 @@ public class DeploymentsClientTests var expectedUrl = "repos/owner/name/deployments"; client.GetAll("owner", "name"); - connection.Received().GetAll(Arg.Is(u => u.ToString() == expectedUrl), + connection.Received().GetAll(Arg.Is(u => u.ToString() == expectedUrl), Arg.Any>(), Arg.Any()); } @@ -64,7 +64,7 @@ public class DeploymentsClientTests var client = new DeploymentsClient(connection); client.GetAll("owner", "name"); - connection.Received().GetAll(Arg.Any(), + connection.Received().GetAll(Arg.Any(), Arg.Any>(), expectedAcceptsHeader); } @@ -115,7 +115,7 @@ public class DeploymentsClientTests var expectedUrl = "repos/owner/name/deployments"; client.Create("owner", "name", newDeployment); - connection.Received().Post(Arg.Is(u => u.ToString() == expectedUrl), + connection.Received().Post(Arg.Is(u => u.ToString() == expectedUrl), Arg.Any(), Arg.Any()); } @@ -127,7 +127,7 @@ public class DeploymentsClientTests var client = new DeploymentsClient(connection); client.Create("owner", "name", newDeployment); - connection.Received().Post(Arg.Any(), + connection.Received().Post(Arg.Any(), newDeployment, Arg.Any()); } @@ -139,7 +139,7 @@ public class DeploymentsClientTests var client = new DeploymentsClient(connection); client.Create("owner", "name", newDeployment); - connection.Received().Post(Arg.Any(), + connection.Received().Post(Arg.Any(), Arg.Any(), Arg.Is(expectedAcceptsHeader)); } diff --git a/Octokit/Clients/DeploymentsClient.cs b/Octokit/Clients/DeploymentsClient.cs index 5ded6e1a..665ff3d8 100644 --- a/Octokit/Clients/DeploymentsClient.cs +++ b/Octokit/Clients/DeploymentsClient.cs @@ -33,13 +33,13 @@ namespace Octokit /// /// The owner of the repository /// The name of the repository - /// All the s for the specified repository. - public Task> GetAll(string owner, string name) + /// All the s for the specified repository. + public Task> GetAll(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "login"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); - return ApiConnection.GetAll(ApiUrls.Deployments(owner, name), + return ApiConnection.GetAll(ApiUrls.Deployments(owner, name), null, acceptsHeader); } @@ -50,14 +50,14 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// A instance describing the new deployment to create - /// The created - public Task Create(string owner, string name, NewDeployment newDeployment) + /// The created + public Task Create(string owner, string name, NewDeployment newDeployment) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNull(newDeployment, "deployment"); - return ApiConnection.Post(ApiUrls.Deployments(owner, name), + return ApiConnection.Post(ApiUrls.Deployments(owner, name), newDeployment, acceptsHeader); } diff --git a/Octokit/Clients/IDeploymentsClient.cs b/Octokit/Clients/IDeploymentsClient.cs index a07050f5..5bb557fd 100644 --- a/Octokit/Clients/IDeploymentsClient.cs +++ b/Octokit/Clients/IDeploymentsClient.cs @@ -21,8 +21,8 @@ namespace Octokit /// /// The owner of the repository /// The name of the repository - /// All the s for the specified repository. - Task> GetAll(string owner, string name); + /// All the s for the specified repository. + Task> GetAll(string owner, string name); /// /// Creates a new deployment for the specified repository. @@ -31,8 +31,8 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// A instance describing the new deployment to create - /// The created - Task Create(string owner, string name, NewDeployment newDeployment); + /// The created + Task Create(string owner, string name, NewDeployment newDeployment); /// /// Client for managing deployment status. diff --git a/Octokit/Models/Response/GitDeployment.cs b/Octokit/Models/Response/Deployment.cs similarity index 84% rename from Octokit/Models/Response/GitDeployment.cs rename to Octokit/Models/Response/Deployment.cs index 0de5a91a..cf8e3623 100644 --- a/Octokit/Models/Response/GitDeployment.cs +++ b/Octokit/Models/Response/Deployment.cs @@ -1,8 +1,11 @@ using System; +using System.Diagnostics.CodeAnalysis; namespace Octokit { - public class GitDeployment + [SuppressMessage("Microsoft.Naming", "CA1724:TypeNamesShouldNotMatchNamespaces", + Justification="People can use fully qualified names if they want to use both.")] + public class Deployment { /// /// Id of this deployment. diff --git a/Octokit/Octokit-Mono.csproj b/Octokit/Octokit-Mono.csproj index 25d12f01..2d1fca44 100644 --- a/Octokit/Octokit-Mono.csproj +++ b/Octokit/Octokit-Mono.csproj @@ -250,10 +250,10 @@ - + \ No newline at end of file diff --git a/Octokit/Octokit-MonoAndroid.csproj b/Octokit/Octokit-MonoAndroid.csproj index ff75e645..ef43300a 100644 --- a/Octokit/Octokit-MonoAndroid.csproj +++ b/Octokit/Octokit-MonoAndroid.csproj @@ -260,10 +260,10 @@ - + \ No newline at end of file diff --git a/Octokit/Octokit-Monotouch.csproj b/Octokit/Octokit-Monotouch.csproj index 4d6b1ad9..d1774b94 100644 --- a/Octokit/Octokit-Monotouch.csproj +++ b/Octokit/Octokit-Monotouch.csproj @@ -255,10 +255,10 @@ - + \ No newline at end of file diff --git a/Octokit/Octokit-netcore45.csproj b/Octokit/Octokit-netcore45.csproj index 41b181a8..1f420523 100644 --- a/Octokit/Octokit-netcore45.csproj +++ b/Octokit/Octokit-netcore45.csproj @@ -248,10 +248,10 @@ - + diff --git a/Octokit/Octokit.csproj b/Octokit/Octokit.csproj index 3587649b..24b9c7a9 100644 --- a/Octokit/Octokit.csproj +++ b/Octokit/Octokit.csproj @@ -59,7 +59,7 @@ - +