zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2026-06-04 03:16:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add default messages for custom exceptions

Browse Source 
Right now, our exception messages come from the API response in most
cases. But if for any reason there isn't one, we supply a default. I
realized these messages might make it to people's logs so it might be
nice to spend time later making them even more useful.
This commit is contained in:
Haacked
2013-10-18 11:08:56 -07:00
parent a1887837be
commit c87944c884
15 changed files with 137 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Octokit.Tests/Exceptions/ApiExceptionTests.cs
+1
View File
@@ -34,6 +34,7 @@ namespace Octokit.Tests.Exceptions
[InlineData("")]
[InlineData(null)]
[InlineData("{{{{{")]
[InlineData("<html><body><h1>502 Bad Gateway</h1>The server returned an invalid or incomplete response.</body></html>")]
public void CreatesGitHubErrorIfResponseMessageIsNotValidJson(string responseContent)
{
var response = new ApiResponse<object>