build(deps): bump xunit from 2.6.1 to 2.6.3 (#2834)

* build(deps): bump xunit from 2.6.1 to 2.6.3

Bumps [xunit](https://github.com/xunit/xunit) from 2.6.1 to 2.6.3.
- [Commits](https://github.com/xunit/xunit/compare/2.6.1...2.6.3)

---
updated-dependencies:
- dependency-name: xunit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add required async/awaits

* public async void --> public async Task

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>

Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj

@@ -34,7 +34,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Include="xunit" Version="2.6.1" />
+    <PackageReference Include="xunit" Version="2.6.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
   </ItemGroup>
 

Octokit.Tests.Integration/Clients/ReleasesClientTests.cs

@@ -61,7 +61,7 @@ public class ReleasesClientTests
             var firstReleaseRequest = new NewRelease("0.1") { MakeLatest = MakeLatestQualifier.False };
             await _releaseClient.Create(_context.Repository.Id, firstReleaseRequest);
 
-            Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName));
+            await Assert.ThrowsAsync<NotFoundException>(async () => await _releaseClient.GetLatest(_context.RepositoryOwner, _context.RepositoryName));
 
             var secondReleaseRequest = new NewRelease("0.2") { MakeLatest = MakeLatestQualifier.True };
             var secondRelease = await _releaseClient.Create(_context.Repository.Id, secondReleaseRequest);

Octokit.Tests.Integration/Octokit.Tests.Integration.csproj

@@ -36,7 +36,7 @@
 	<PackageReference Include="GitHubJwt" Version="0.0.6" />
 	<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
 	<PackageReference Include="System.IO.Compression" Version="4.3.0" />
-  <PackageReference Include="xunit" Version="2.6.1" />
+  <PackageReference Include="xunit" Version="2.6.3" />
   <PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
   </ItemGroup>
 

Octokit.Tests/AsyncEnumerableExtensionTests.cs

@@ -13,11 +13,11 @@ namespace Octokit.Tests
         public class ThePaginatedList
         {
             [Fact]
-            public void RejectsInvalidValues()
+            public async Task RejectsInvalidValues()
             {
                 var client = Substitute.For<IRepositoriesClient>();
 
-                Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => client.GetAllForOrgAsync("octokit")[-1]);
+                await Assert.ThrowsAsync<ArgumentOutOfRangeException>(() => client.GetAllForOrgAsync("octokit")[-1]);
             }
 
             [Fact]
@@ -72,7 +72,7 @@ namespace Octokit.Tests
             public void RejectInvalidValues()
             {
                 var client = Substitute.For<IRepositoriesClient>();
-                
+
                 Assert.Throws<ArgumentOutOfRangeException>(() => client.GetAllForUserAsync("fake", -1));
                 Assert.Throws<ArgumentOutOfRangeException>(() => client.GetAllForUserAsync("fake", 0));
             }

Octokit.Tests/Caching/CachingHttpClientTests.cs

@@ -20,7 +20,7 @@ namespace Octokit.Tests.Caching
         public class TheSendMethod
         {
             [Fact]
-            public void EnsuresNonNullArguments()
+            public async Task EnsuresNonNullArguments()
             {
                 // arrange
                 var underlyingClient = Substitute.For<IHttpClient>();
@@ -29,7 +29,7 @@ namespace Octokit.Tests.Caching
                 var cachingHttpClient = new CachingHttpClient(underlyingClient, responseCache);
 
                 // act + assert
-                Assert.ThrowsAsync<ArgumentNullException>(() => cachingHttpClient.Send(null, CancellationToken.None));
+                await Assert.ThrowsAsync<ArgumentNullException>(() => cachingHttpClient.Send(null, CancellationToken.None));
             }
 
             [Theory]

Octokit.Tests/Clients/LicensesClientTests.cs

@@ -21,11 +21,11 @@ namespace Octokit.Tests.Clients
         public class TheGetAllLicensesMethod
         {
             [Fact]
-            public void EnsuresNonNullArguments()
+            public async Task EnsuresNonNullArguments()
             {
                 var client = new LicensesClient(Substitute.For<IApiConnection>());
 
-                Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
             }
 
             [Fact]

Octokit.Tests/Clients/MiscellaneousClientTests.cs

@@ -207,11 +207,11 @@ namespace Octokit.Tests.Clients
         public class TheGetAllLicensesMethod
         {
             [Fact]
-            public void EnsuresNonNullArguments()
+            public async Task EnsuresNonNullArguments()
             {
                 var client = new MiscellaneousClient(Substitute.For<IApiConnection>());
 
-                Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
+                await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllLicenses(null));
             }
 
             [Fact]

Octokit.Tests/Clients/OrganizationHooksClientTest.cs

@@ -123,11 +123,11 @@ namespace Octokit.Tests.Clients
             }
 
             [Fact]
-            public void EnsuresNonEmptyArguments()
+            public async Task EnsuresNonEmptyArguments()
             {
                 var client = new OrganizationsClient(Substitute.For<IApiConnection>());
                 var config = new Dictionary<string, string> { { "url", "" } };
-                Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Create("", new NewOrganizationHook("name", config)));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Create("", new NewOrganizationHook("name", config)));
             }
 
             [Fact]
@@ -167,10 +167,10 @@ namespace Octokit.Tests.Clients
             }
 
             [Fact]
-            public void EnsuresNonEmptyArguments()
+            public async Task EnsuresNonEmptyArguments()
             {
                 var client = new OrganizationsClient(Substitute.For<IApiConnection>());
-                Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Edit("", 123, new EditOrganizationHook()));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Edit("", 123, new EditOrganizationHook()));
             }
 
             [Fact]
@@ -197,10 +197,10 @@ namespace Octokit.Tests.Clients
             }
 
             [Fact]
-            public void EnsuresNonEmptyArguments()
+            public async Task EnsuresNonEmptyArguments()
             {
                 var client = new OrganizationsClient(Substitute.For<IApiConnection>());
-                Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Ping("", 123));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Ping("", 123));
             }
 
             [Fact]
@@ -237,10 +237,10 @@ namespace Octokit.Tests.Clients
             }
 
             [Fact]
-            public void EnsuresNonEmptyArguments()
+            public async Task EnsuresNonEmptyArguments()
             {
                 var client = new OrganizationsClient(Substitute.For<IApiConnection>());
-                Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Delete("", 123));
+                await Assert.ThrowsAsync<ArgumentException>(() => client.Hook.Delete("", 123));
             }
 
         }

Octokit.Tests/Octokit.Tests.csproj

@@ -35,7 +35,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageReference Include="System.Net.Http" Version="4.3.4" />
-    <PackageReference Include="xunit" Version="2.6.1" />
+    <PackageReference Include="xunit" Version="2.6.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.5" />
   </ItemGroup>