From cacd6020f257f18c63a3317d40206b4de23cafef Mon Sep 17 00:00:00 2001 From: Mordechai Zuber Date: Sun, 27 Mar 2016 11:29:57 +0300 Subject: [PATCH] :fire: ITeamsClient.IsMember() --- .../Clients/IObservableTeamsClient.cs | 10 -------- .../Clients/ObservableTeamsClient.cs | 15 ----------- Octokit/Clients/ITeamsClient.cs | 10 -------- Octokit/Clients/TeamsClient.cs | 25 ------------------- 4 files changed, 60 deletions(-) diff --git a/Octokit.Reactive/Clients/IObservableTeamsClient.cs b/Octokit.Reactive/Clients/IObservableTeamsClient.cs index dc17b6f4..0ca0a385 100644 --- a/Octokit.Reactive/Clients/IObservableTeamsClient.cs +++ b/Octokit.Reactive/Clients/IObservableTeamsClient.cs @@ -125,16 +125,6 @@ namespace Octokit.Reactive /// if the user was removed from the team; otherwise. IObservable RemoveMembership(int id, string login); - /// - /// Gets whether the user with the given - /// is a member of the team with the given . - /// - /// The team to check. - /// The user to check. - /// if the user is a member of the team; otherwise. - [Obsolete("Use GetMembership(id, login) to detect pending memberships")] - IObservable IsMember(int id, string login); - /// /// Gets whether the user with the given /// is a member of the team with the given . diff --git a/Octokit.Reactive/Clients/ObservableTeamsClient.cs b/Octokit.Reactive/Clients/ObservableTeamsClient.cs index 1711f78c..31f9b7aa 100644 --- a/Octokit.Reactive/Clients/ObservableTeamsClient.cs +++ b/Octokit.Reactive/Clients/ObservableTeamsClient.cs @@ -189,21 +189,6 @@ namespace Octokit.Reactive return _client.RemoveMembership(id, login).ToObservable(); } - /// - /// Gets whether the user with the given - /// is a member of the team with the given . - /// - /// The team to check. - /// The user to check. - /// if the user is a member of the team; otherwise. - [Obsolete("Use GetMembership(id, login) to detect pending memberships")] - public IObservable IsMember(int id, string login) - { - Ensure.ArgumentNotNullOrEmptyString(login, "login"); - - return _client.IsMember(id, login).ToObservable(); - } - /// /// Gets whether the user with the given /// is a member of the team with the given . diff --git a/Octokit/Clients/ITeamsClient.cs b/Octokit/Clients/ITeamsClient.cs index ec832db3..4249acaf 100644 --- a/Octokit/Clients/ITeamsClient.cs +++ b/Octokit/Clients/ITeamsClient.cs @@ -126,16 +126,6 @@ namespace Octokit /// if the user was removed from the team; otherwise. Task RemoveMembership(int id, string login); - /// - /// Gets whether the user with the given - /// is a member of the team with the given . - /// - /// The team to check. - /// The user to check. - /// if the user is a member of the team; otherwise. - [Obsolete("Use GetMembership(id, login) as this will report on pending requests")] - Task IsMember(int id, string login); - /// /// Gets whether the user with the given /// is a member of the team with the given . diff --git a/Octokit/Clients/TeamsClient.cs b/Octokit/Clients/TeamsClient.cs index ae721871..3ec477ac 100644 --- a/Octokit/Clients/TeamsClient.cs +++ b/Octokit/Clients/TeamsClient.cs @@ -252,31 +252,6 @@ namespace Octokit } } - /// - /// Gets whether the user with the given - /// is a member of the team with the given . - /// - /// The team to check. - /// The user to check. - /// if the user is a member of the team; otherwise. - [Obsolete("Use GetMembership(id, login) as this will report on pending requests")] - public async Task IsMember(int id, string login) - { - Ensure.ArgumentNotNullOrEmptyString(login, "login"); - - var endpoint = ApiUrls.TeamMember(id, login); - - try - { - var response = await ApiConnection.Connection.GetResponse(endpoint).ConfigureAwait(false); - return response.HttpResponse.StatusCode == HttpStatusCode.NoContent; - } - catch (NotFoundException) - { - return false; - } - } - /// /// Returns all team's repositories. ///