diff --git a/Octokit.Reactive/Clients/IObservableOauthClient.cs b/Octokit.Reactive/Clients/IObservableOauthClient.cs index 01f1d6f1..2afa944c 100644 --- a/Octokit.Reactive/Clients/IObservableOauthClient.cs +++ b/Octokit.Reactive/Clients/IObservableOauthClient.cs @@ -9,7 +9,7 @@ namespace Octokit.Reactive /// /// Parameters to the Oauth web flow login url /// - IObservable GetGitHubLoginUrl(OauthLoginRequest request); + Uri GetGitHubLoginUrl(OauthLoginRequest request); /// /// Makes a request to get an access token using the code returned when GitHub.com redirects back from the URL diff --git a/Octokit.Reactive/Clients/ObservableOauthClient.cs b/Octokit.Reactive/Clients/ObservableOauthClient.cs index cd73a94f..db62a7e1 100644 --- a/Octokit.Reactive/Clients/ObservableOauthClient.cs +++ b/Octokit.Reactive/Clients/ObservableOauthClient.cs @@ -15,11 +15,28 @@ namespace Octokit.Reactive _client = client; } - public IObservable GetGitHubLoginUrl(OauthLoginRequest request) + /// + /// Gets the URL used in the first step of the web flow. The Web application should redirect to this URL. + /// + /// Parameters to the Oauth web flow login url + /// + public Uri GetGitHubLoginUrl(OauthLoginRequest request) { - return Observable.Return(_client.Oauth.GetGitHubLoginUrl(request)); + return _client.Oauth.GetGitHubLoginUrl(request); } + /// + /// Makes a request to get an access token using the code returned when GitHub.com redirects back from the URL + /// GitHub login url to the application. + /// + /// + /// If the user accepts your request, GitHub redirects back to your site with a temporary code in a code + /// parameter as well as the state you provided in the previous step in a state parameter. If the states don’t + /// match, the request has been created by a third party and the process should be aborted. Exchange this for + /// an access token using this method. + /// + /// + /// public IObservable CreateAccessToken(OauthTokenRequest request) { return _client.Oauth.CreateAccessToken(request).ToObservable();