From ccd9654727a849f102e1eae81266626b671467f5 Mon Sep 17 00:00:00 2001 From: maddin2016 Date: Thu, 9 Jun 2016 15:06:02 +0200 Subject: [PATCH] fix some grammar and tests --- .../Enterprise/IObservableEnterpriseAdminStatsClient.cs | 3 +-- .../Clients/IObservableCommitCommentReactionsClient.cs | 2 +- .../Clients/IObservableIssueCommentReactionsClient.cs | 2 +- .../Clients/IObservableIssueReactionsClient.cs | 2 +- .../Clients/ObservableIssueCommentReactionsClient.cs | 4 ++-- .../Clients/IssueCommentReactionsClientTests.cs | 2 +- .../Clients/IssueReactionsClientTests.cs | 2 +- .../PullRequestReviewCommentReactionsClientTests.cs | 8 +++++++- 8 files changed, 15 insertions(+), 10 deletions(-) diff --git a/Octokit.Reactive/Clients/Enterprise/IObservableEnterpriseAdminStatsClient.cs b/Octokit.Reactive/Clients/Enterprise/IObservableEnterpriseAdminStatsClient.cs index 282a2219..62dccdb0 100644 --- a/Octokit.Reactive/Clients/Enterprise/IObservableEnterpriseAdminStatsClient.cs +++ b/Octokit.Reactive/Clients/Enterprise/IObservableEnterpriseAdminStatsClient.cs @@ -1,5 +1,4 @@ -using Octokit; -using System; +using System; using System.Diagnostics.CodeAnalysis; namespace Octokit.Reactive diff --git a/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs b/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs index 8a0f799b..174863fa 100644 --- a/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs @@ -5,7 +5,7 @@ namespace Octokit.Reactive public interface IObservableCommitCommentReactionsClient { /// - /// Creates a reaction for an specified Commit Comment + /// Creates a reaction for a specified Commit Comment /// /// https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment /// The owner of the repository diff --git a/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs b/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs index 6e41be81..6ee2e35f 100644 --- a/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs @@ -5,7 +5,7 @@ namespace Octokit.Reactive public interface IObservableIssueCommentReactionsClient { /// - /// Creates a reaction for an specified Issue Comment + /// Creates a reaction for a specified Issue Comment /// /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment /// The owner of the repository diff --git a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs index 829c6997..2a12a904 100644 --- a/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs @@ -5,7 +5,7 @@ namespace Octokit.Reactive public interface IObservableIssueReactionsClient { /// - /// Creates a reaction for an specified Issue. + /// Creates a reaction for a specified Issue. /// /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue /// The owner of the repository diff --git a/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs b/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs index a7c64ecf..3bb42d9f 100644 --- a/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssueCommentReactionsClient.cs @@ -19,7 +19,7 @@ namespace Octokit.Reactive } /// - /// Creates a reaction for an specified Issue Comment + /// Creates a reaction for a specified Issue Comment /// /// https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment /// The owner of the repository @@ -37,7 +37,7 @@ namespace Octokit.Reactive } /// - /// List reactions for an specified Issue Comment + /// List reactions for a specified Issue Comment /// /// https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment /// The owner of the repository diff --git a/Octokit.Tests.Integration/Clients/IssueCommentReactionsClientTests.cs b/Octokit.Tests.Integration/Clients/IssueCommentReactionsClientTests.cs index d6193bde..210a551e 100644 --- a/Octokit.Tests.Integration/Clients/IssueCommentReactionsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/IssueCommentReactionsClientTests.cs @@ -29,7 +29,7 @@ public class IssueCommentReactionsClientTests Assert.NotNull(issue); - var issueComment = await _issuesClient.Comment.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Id, "A test comment"); + var issueComment = await _issuesClient.Comment.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Number, "A test comment"); Assert.NotNull(issueComment); diff --git a/Octokit.Tests.Integration/Clients/IssueReactionsClientTests.cs b/Octokit.Tests.Integration/Clients/IssueReactionsClientTests.cs index a7e20fad..32f263fa 100644 --- a/Octokit.Tests.Integration/Clients/IssueReactionsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/IssueReactionsClientTests.cs @@ -29,7 +29,7 @@ public class IssueReactionsClientTests Assert.NotNull(issue); - var issueReaction = await _github.Reaction.Issue.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Id, new NewReaction(ReactionType.Heart)); + var issueReaction = await _github.Reaction.Issue.Create(_context.RepositoryOwner, _context.RepositoryName, issue.Number, new NewReaction(ReactionType.Heart)); Assert.NotNull(issueReaction); diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs index cc74c04b..b705bfa8 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs @@ -1,10 +1,11 @@ using Octokit; using Octokit.Tests.Integration; using Octokit.Tests.Integration.Helpers; +using System; using System.Threading.Tasks; using Xunit; -public class PullRequestReviewCommentReactionsClientTests +public class PullRequestReviewCommentReactionsClientTests : IDisposable { private readonly IGitHubClient _github; private readonly IPullRequestReviewCommentsClient _client; @@ -142,6 +143,11 @@ public class PullRequestReviewCommentReactionsClientTests Assert.Equal(position, comment.Position); } + public void Dispose() + { + _context.Dispose(); + } + class PullRequestData { public int Number { get; set; }