Organization membership preview API changes - Review user permission (#1633)

* Add organization membership preview header * Add API endpoints to preview a collaborators permission * Add methods to preview a collaborators permission * Add methods to the observable repo collaborator client * Fix convention test failure * Use correct API endpoint when using repository ID * Move the helper function pair so they aren't in between another pair * Use the correct URL for the review permission API endpoint * Add unit tests * Add integration tests for review permission methods * Fix spelling mistake * Renaming enum as per review
2026-06-07 20:30:41 +00:00 · 2017-07-29 15:08:44 +10:00
parent db74c3b4ad
commit cda714bef6
12 changed files with 597 additions and 2 deletions
@@ -253,6 +253,92 @@ namespace Octokit.Tests.Reactive
            }
        }

+        public class TheReviewPermissionMethod
+        {
+            private readonly IGitHubClient _gitHubClient;
+            private IObservableRepoCollaboratorsClient _client;
+
+            public TheReviewPermissionMethod()
+            {
+                _gitHubClient = Substitute.For<IGitHubClient>();
+            }
+
+            private void SetupWithoutNonReactiveClient()
+            {
+                _client = new ObservableRepoCollaboratorsClient(_gitHubClient);
+            }
+
+            private void SetupWithNonReactiveClient()
+            {
+                var collaboratorsClient = new RepoCollaboratorsClient(Substitute.For<IApiConnection>());
+                _gitHubClient.Repository.Collaborator.Returns(collaboratorsClient);
+                _client = new ObservableRepoCollaboratorsClient(_gitHubClient);
+            }
+
+            [Fact]
+            public void EnsuresNonNullArguments()
+            {
+                SetupWithNonReactiveClient();
+
+                Assert.Throws<ArgumentNullException>(() => _client.ReviewPermission(null, "test", "user1"));
+                Assert.Throws<ArgumentNullException>(() => _client.ReviewPermission("owner", null, "user1"));
+                Assert.Throws<ArgumentNullException>(() => _client.ReviewPermission("owner", "test", null));
+                Assert.Throws<ArgumentNullException>(() => _client.ReviewPermission(1L, null));
+            }
+
+            [Fact]
+            public void EnsuresNonEmptyArguments()
+            {
+                SetupWithNonReactiveClient();
+
+                Assert.Throws<ArgumentException>(() => _client.ReviewPermission("", "test", "user1"));
+                Assert.Throws<ArgumentException>(() => _client.ReviewPermission("owner", "", "user1"));
+                Assert.Throws<ArgumentException>(() => _client.ReviewPermission("owner", "test", ""));
+                Assert.Throws<ArgumentException>(() => _client.ReviewPermission(1L, ""));
+            }
+
+            [Fact]
+            public async Task EnsuresNonWhitespaceArguments()
+            {
+                SetupWithNonReactiveClient();
+
+                await AssertEx.ThrowsWhenGivenWhitespaceArgument(
+                    async whitespace => await _client.ReviewPermission(whitespace, "repo", "user"));
+                await AssertEx.ThrowsWhenGivenWhitespaceArgument(
+                    async whitespace => await _client.ReviewPermission("owner", whitespace, "user"));
+                await AssertEx.ThrowsWhenGivenWhitespaceArgument(
+                    async whitespace => await _client.ReviewPermission("owner", "repo", whitespace));
+                await AssertEx.ThrowsWhenGivenWhitespaceArgument(
+                    async whitespace => await _client.ReviewPermission(1L, whitespace));
+            }
+
+            [Fact]
+            public void CallsReviewPermissionOnRegularRepoCollaboratorsClient()
+            {
+                SetupWithoutNonReactiveClient();
+
+                _client.ReviewPermission("owner", "repo", "user");
+
+                _gitHubClient.Repository.Collaborator.Received(1).ReviewPermission(
+                    Arg.Is("owner"),
+                    Arg.Is("repo"),
+                    Arg.Is("user"));
+            }
+
+            [Fact]
+            public void CallsReviewPermissionOnRegularRepoCollaboratorsClientWithRepositoryId()
+            {
+                SetupWithoutNonReactiveClient();
+
+                var id = 1L;
+                _client.ReviewPermission(id, "user");
+
+                _gitHubClient.Repository.Collaborator.Received(1).ReviewPermission(
+                    Arg.Is(id),
+                    Arg.Is("user"));
+            }
+        }
+
        public class TheAddMethod
        {
            private readonly IGitHubClient _githubClient;