add RequiredApprovingReview preview functionality to branch protection calls (#1912)

This commit is contained in:
Ryan Gribble
2019-01-30 21:20:50 +10:00
committed by GitHub
parent 64cecbb264
commit cf442499ff
9 changed files with 213 additions and 163 deletions
@@ -184,7 +184,7 @@ namespace Octokit
/// <summary>
/// Specify teams (in addition to Administrators) allowed to push to this branch. Required status checks will still prevent these people from merging if the checks fail
/// </summary>
/// <param name="teams">Teams allowed to push to this branch</param>
/// <param name="teams">List of Team slugs allowed to push to this branch</param>
public BranchProtectionPushRestrictionsUpdate(BranchProtectionTeamCollection teams)
{
Ensure.ArgumentNotNull(teams, nameof(teams));
@@ -196,7 +196,7 @@ namespace Octokit
/// <summary>
/// Specify people (in addition to Administrators) allowed to push to this branch. Required status checks will still prevent these people from merging if the checks fail
/// </summary>
/// <param name="users">Users allowed to push to this branch</param>
/// <param name="users">List of User logins allowed to push to this branch</param>
public BranchProtectionPushRestrictionsUpdate(BranchProtectionUserCollection users)
{
Ensure.ArgumentNotNull(users, nameof(users));
@@ -208,8 +208,8 @@ namespace Octokit
/// <summary>
/// Specify teams and/or people (in addition to Administrators) allowed to push to this branch. Required status checks will still prevent these people from merging if the checks fail
/// </summary>
/// <param name="teams">Teams allowed to push to this branch</param>
/// <param name="users">Users allowed to push to this branch</param>
/// <param name="teams">List of Team slugs allowed to push to this branch</param>
/// <param name="users">List of User logins allowed to push to this branch</param>
public BranchProtectionPushRestrictionsUpdate(BranchProtectionTeamCollection teams, BranchProtectionUserCollection users)
{
Ensure.ArgumentNotNull(teams, nameof(teams));
@@ -220,12 +220,12 @@ namespace Octokit
}
/// <summary>
/// Teams allowed to push to this branch
/// List of Team slugs allowed to push to this branch
/// </summary>
public BranchProtectionTeamCollection Teams { get; private set; }
/// <summary>
/// Users allowed to push to this branch
/// List of User logins allowed to push to this branch
/// </summary>
public BranchProtectionUserCollection Users { get; private set; }
@@ -288,10 +288,12 @@ namespace Octokit
/// </summary>
/// <param name="dismissStaleReviews">Dismiss approved reviews automatically when a new commit is pushed.</param>
/// <param name="requireCodeOwnerReviews">Blocks merge until code owners have reviewed.</param>
public BranchProtectionRequiredReviewsUpdate(bool dismissStaleReviews, bool requireCodeOwnerReviews)
/// <param name="requiredApprovingReviewCount">Specify the number of reviewers required to approve pull requests. Use a number between 1 and 6.</param>
public BranchProtectionRequiredReviewsUpdate(bool dismissStaleReviews, bool requireCodeOwnerReviews, int requiredApprovingReviewCount)
{
DismissStaleReviews = dismissStaleReviews;
RequireCodeOwnerReviews = requireCodeOwnerReviews;
RequiredApprovingReviewCount = requiredApprovingReviewCount;
}
/// <summary>
@@ -300,13 +302,15 @@ namespace Octokit
/// <param name="dismissalRestrictions">Specify which users and teams can dismiss pull request reviews (applies only to Organization owned repositories).</param>
/// <param name="dismissStaleReviews">Dismiss approved reviews automatically when a new commit is pushed.</param>
/// <param name="requireCodeOwnerReviews">Blocks merge until code owners have reviewed.</param>
public BranchProtectionRequiredReviewsUpdate(BranchProtectionRequiredReviewsDismissalRestrictionsUpdate dismissalRestrictions, bool dismissStaleReviews, bool requireCodeOwnerReviews)
/// <param name="requiredApprovingReviewCount">Specify the number of reviewers required to approve pull requests. Use a number between 1 and 6.</param>
public BranchProtectionRequiredReviewsUpdate(BranchProtectionRequiredReviewsDismissalRestrictionsUpdate dismissalRestrictions, bool dismissStaleReviews, bool requireCodeOwnerReviews, int requiredApprovingReviewCount)
{
Ensure.ArgumentNotNull(dismissalRestrictions, nameof(dismissalRestrictions));
DismissalRestrictions = dismissalRestrictions;
DismissStaleReviews = dismissStaleReviews;
RequireCodeOwnerReviews = requireCodeOwnerReviews;
RequiredApprovingReviewCount = requiredApprovingReviewCount;
}
/// <summary>
@@ -324,14 +328,20 @@ namespace Octokit
/// </summary>
public bool RequireCodeOwnerReviews { get; protected set; }
/// <summary>
/// Specify the number of reviewers required to approve pull requests. Use a number between 1 and 6.
/// </summary>
public int RequiredApprovingReviewCount { get; protected set; }
internal string DebuggerDisplay
{
get
{
return string.Format(CultureInfo.InvariantCulture, "DismissalRestrictions: {0} DismissStaleReviews: {1} RequireCodeOwnerReviews: {2}",
return string.Format(CultureInfo.InvariantCulture, "DismissalRestrictions: {0} DismissStaleReviews: {1} RequireCodeOwnerReviews: {2} RequiredApprovingReviewCount: {3}",
DismissalRestrictions?.DebuggerDisplay ?? "disabled",
DismissStaleReviews,
RequireCodeOwnerReviews);
RequireCodeOwnerReviews,
RequiredApprovingReviewCount);
}
}
}
@@ -365,7 +375,7 @@ namespace Octokit
/// <summary>
/// Restrict dismissing reviews to the specified teams (in addition to Administrators).
/// </summary>
/// <param name="teams">Teams allowed to dismiss reviews</param>
/// <param name="teams">List of Team slugs allowed to dismiss reviews</param>
public BranchProtectionRequiredReviewsDismissalRestrictionsUpdate(BranchProtectionTeamCollection teams)
{
Ensure.ArgumentNotNull(teams, nameof(teams));
@@ -377,7 +387,7 @@ namespace Octokit
/// <summary>
/// Restrict dismissing reviews to the specified people (in addition to Administrators).
/// </summary>
/// <param name="users">Users allowed to dismiss reviews</param>
/// <param name="users">List of User logins allowed to dismiss reviews</param>
public BranchProtectionRequiredReviewsDismissalRestrictionsUpdate(BranchProtectionUserCollection users)
{
Ensure.ArgumentNotNull(users, nameof(users));
@@ -389,8 +399,8 @@ namespace Octokit
/// <summary>
/// Restrict dismissing reviews to the specified teams and people (in addition to Administrators).
/// </summary>
/// <param name="teams">Teams allowed to dismiss reviews</param>
/// <param name="users">Users allowed to dismiss reviews</param>
/// <param name="teams">List of Team slugs allowed to dismiss reviews</param>
/// <param name="users">List of User logins allowed to dismiss reviews</param>
public BranchProtectionRequiredReviewsDismissalRestrictionsUpdate(BranchProtectionTeamCollection teams, BranchProtectionUserCollection users)
{
Ensure.ArgumentNotNull(teams, nameof(teams));
@@ -401,12 +411,12 @@ namespace Octokit
}
/// <summary>
/// Teams allowed to dismiss reviews
/// List of Team slugs allowed to dismiss reviews
/// </summary>
public BranchProtectionTeamCollection Teams { get; private set; }
/// <summary>
/// Users allowed to dismiss reviews
/// List of User logins allowed to dismiss reviews
/// </summary>
public BranchProtectionUserCollection Users { get; private set; }