From cf683f0582c104e9a0d1e0ef7d59e7359d2ee2b6 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Thu, 9 Jun 2016 14:47:55 +0700 Subject: [PATCH] fixed unut tests --- .../Clients/RepositoryForksClientTests.cs | 30 +++++++++---------- .../ObservableRepositoryForksClientTests.cs | 2 -- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/Octokit.Tests/Clients/RepositoryForksClientTests.cs b/Octokit.Tests/Clients/RepositoryForksClientTests.cs index a5f436e0..32d8bccb 100644 --- a/Octokit.Tests/Clients/RepositoryForksClientTests.cs +++ b/Octokit.Tests/Clients/RepositoryForksClientTests.cs @@ -1,7 +1,7 @@ -using NSubstitute; -using System; +using System; using System.Collections.Generic; using System.Threading.Tasks; +using NSubstitute; using Xunit; namespace Octokit.Tests.Clients @@ -14,7 +14,7 @@ namespace Octokit.Tests.Clients public void EnsuresNonNullArguments() { Assert.Throws( - () => new RepositoryForksClient(null)); + () => new RepositoryForksClient(null)); } } @@ -24,9 +24,9 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new RepositoriesClient(connection); + var client = new RepositoryForksClient(connection); - await client.Forks.GetAll("fake", "repo"); + await client.GetAll("fake", "repo"); connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/forks"), Args.ApiOptions); } @@ -35,7 +35,7 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrlWithApiOptions() { var connection = Substitute.For(); - var client = new RepositoriesClient(connection); + var client = new RepositoryForksClient(connection); var options = new ApiOptions { @@ -44,7 +44,7 @@ namespace Octokit.Tests.Clients PageSize = 1 }; - await client.Forks.GetAll("fake", "repo", options); + await client.GetAll("fake", "repo", options); connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/forks"), options); } @@ -53,9 +53,9 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrlWithRequestParameters() { var connection = Substitute.For(); - var client = new RepositoriesClient(connection); + var client = new RepositoryForksClient(connection); - await client.Forks.GetAll("fake", "repo", new RepositoryForksListRequest { Sort = Sort.Stargazers }); + await client.GetAll("fake", "repo", new RepositoryForksListRequest { Sort = Sort.Stargazers }); connection.Received().GetAll( Arg.Is(u => u.ToString() == "repos/fake/repo/forks"), @@ -66,7 +66,7 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrlWithRequestParametersWithApiOptions() { var connection = Substitute.For(); - var client = new RepositoriesClient(connection); + var client = new RepositoryForksClient(connection); var options = new ApiOptions { @@ -75,7 +75,7 @@ namespace Octokit.Tests.Clients PageSize = 1 }; - await client.Forks.GetAll("fake", "repo", new RepositoryForksListRequest { Sort = Sort.Stargazers }, options); + await client.GetAll("fake", "repo", new RepositoryForksListRequest { Sort = Sort.Stargazers }, options); connection.Received().GetAll( Arg.Is(u => u.ToString() == "repos/fake/repo/forks"), @@ -94,10 +94,8 @@ namespace Octokit.Tests.Clients await Assert.ThrowsAsync(() => client.GetAll("owner", "name", (ApiOptions)null)); await Assert.ThrowsAsync(() => client.GetAll(null, "name", new RepositoryForksListRequest())); await Assert.ThrowsAsync(() => client.GetAll("owner", null, new RepositoryForksListRequest())); - await Assert.ThrowsAsync(() => client.GetAll("owner", "name", (RepositoryForksListRequest)null)); await Assert.ThrowsAsync(() => client.GetAll(null, "name", new RepositoryForksListRequest(), ApiOptions.None)); await Assert.ThrowsAsync(() => client.GetAll("owner", null, new RepositoryForksListRequest(), ApiOptions.None)); - await Assert.ThrowsAsync(() => client.GetAll("owner", "name", null, ApiOptions.None)); await Assert.ThrowsAsync(() => client.GetAll("owner", "name", new RepositoryForksListRequest(), null)); await Assert.ThrowsAsync(() => client.GetAll("", "name")); @@ -117,11 +115,11 @@ namespace Octokit.Tests.Clients public void RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new RepositoriesClient(connection); + var client = new RepositoryForksClient(connection); var newRepositoryFork = new NewRepositoryFork(); - client.Forks.Create("fake", "repo", newRepositoryFork); + client.Create("fake", "repo", newRepositoryFork); connection.Received().Post(Arg.Is(u => u.ToString() == "repos/fake/repo/forks"), newRepositoryFork); } @@ -140,4 +138,4 @@ namespace Octokit.Tests.Clients } } } -} \ No newline at end of file +} diff --git a/Octokit.Tests/Reactive/ObservableRepositoryForksClientTests.cs b/Octokit.Tests/Reactive/ObservableRepositoryForksClientTests.cs index 20f2756c..77acb660 100644 --- a/Octokit.Tests/Reactive/ObservableRepositoryForksClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableRepositoryForksClientTests.cs @@ -94,10 +94,8 @@ namespace Octokit.Tests.Reactive Assert.Throws(() => client.GetAll("owner", "name", (ApiOptions)null)); Assert.Throws(() => client.GetAll(null, "name", new RepositoryForksListRequest())); Assert.Throws(() => client.GetAll("owner", null, new RepositoryForksListRequest())); - Assert.Throws(() => client.GetAll("owner", "name", (RepositoryForksListRequest)null)); Assert.Throws(() => client.GetAll(null, "name", new RepositoryForksListRequest(), ApiOptions.None)); Assert.Throws(() => client.GetAll("owner", null, new RepositoryForksListRequest(), ApiOptions.None)); - Assert.Throws(() => client.GetAll("owner", "name", null, ApiOptions.None)); Assert.Throws(() => client.GetAll("owner", "name", new RepositoryForksListRequest(), null)); Assert.Throws(() => client.GetAll("", "name"));