diff --git a/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs b/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs index 2e867b13..4d387dae 100644 --- a/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs +++ b/Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs @@ -19,7 +19,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The issue comment id - /// [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] IObservable Get(string owner, string name, int id); @@ -30,7 +29,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#get-a-single-comment /// The ID of the repository /// The issue comment id - /// [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] IObservable Get(int repositoryId, int id); @@ -41,7 +39,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The owner of the repository /// The name of the repository - /// IObservable GetAllForRepository(string owner, string name); /// @@ -49,7 +46,6 @@ namespace Octokit.Reactive /// /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository - /// IObservable GetAllForRepository(int repositoryId); /// @@ -59,7 +55,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// Options for changing the API response - /// IObservable GetAllForRepository(string owner, string name, ApiOptions options); /// @@ -68,7 +63,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository /// Options for changing the API response - /// IObservable GetAllForRepository(int repositoryId, ApiOptions options); /// @@ -78,7 +72,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The issue number - /// IObservable GetAllForIssue(string owner, string name, int number); /// @@ -87,7 +80,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue /// The ID of the repository /// The issue number - /// IObservable GetAllForIssue(int repositoryId, int number); /// @@ -98,7 +90,6 @@ namespace Octokit.Reactive /// The name of the repository /// The issue number /// Options for changing the API response - /// IObservable GetAllForIssue(string owner, string name, int number, ApiOptions options); /// @@ -108,7 +99,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The issue number /// Options for changing the API response - /// IObservable GetAllForIssue(int repositoryId, int number, ApiOptions options); /// @@ -119,7 +109,6 @@ namespace Octokit.Reactive /// The name of the repository /// The number of the issue /// The text of the new comment - /// IObservable Create(string owner, string name, int number, string newComment); /// @@ -129,7 +118,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The number of the issue /// The text of the new comment - /// IObservable Create(int repositoryId, int number, string newComment); /// @@ -140,7 +128,6 @@ namespace Octokit.Reactive /// The name of the repository /// The comment id /// The modified comment - /// IObservable Update(string owner, string name, int id, string commentUpdate); /// @@ -150,7 +137,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The comment id /// The modified comment - /// IObservable Update(int repositoryId, int id, string commentUpdate); /// @@ -160,7 +146,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The comment id - /// IObservable Delete(string owner, string name, int id); /// @@ -169,7 +154,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#delete-a-comment /// The ID of the repository /// The comment id - /// IObservable Delete(int repositoryId, int id); } } diff --git a/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs b/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs index a7e1e766..37b42c67 100644 --- a/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs +++ b/Octokit.Reactive/Clients/ObservableIssueCommentsClient.cs @@ -31,7 +31,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The issue comment id - /// public IObservable Get(string owner, string name, int id) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -46,7 +45,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#get-a-single-comment /// The ID of the repository /// The issue comment id - /// public IObservable Get(int repositoryId, int id) { return _client.Get(repositoryId, id).ToObservable(); @@ -58,7 +56,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The owner of the repository /// The name of the repository - /// public IObservable GetAllForRepository(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -72,7 +69,6 @@ namespace Octokit.Reactive /// /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository - /// public IObservable GetAllForRepository(int repositoryId) { return GetAllForRepository(repositoryId, ApiOptions.None); @@ -85,7 +81,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// Options for changing the API response - /// public IObservable GetAllForRepository(string owner, string name, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -101,7 +96,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository /// Options for changing the API response - /// public IObservable GetAllForRepository(int repositoryId, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); @@ -116,7 +110,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The issue number - /// public IObservable GetAllForIssue(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -131,7 +124,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue /// The ID of the repository /// The issue number - /// public IObservable GetAllForIssue(int repositoryId, int number) { return GetAllForIssue(repositoryId, number, ApiOptions.None); @@ -145,7 +137,6 @@ namespace Octokit.Reactive /// The name of the repository /// The issue number /// Options for changing the API response - /// public IObservable GetAllForIssue(string owner, string name, int number, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -162,7 +153,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The issue number /// Options for changing the API response - /// public IObservable GetAllForIssue(int repositoryId, int number, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); @@ -178,7 +168,6 @@ namespace Octokit.Reactive /// The name of the repository /// The number of the issue /// The text of the new comment - /// public IObservable Create(string owner, string name, int number, string newComment) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -195,7 +184,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The number of the issue /// The text of the new comment - /// public IObservable Create(int repositoryId, int number, string newComment) { Ensure.ArgumentNotNull(newComment, "newComment"); @@ -211,7 +199,6 @@ namespace Octokit.Reactive /// The name of the repository /// The comment id /// The modified comment - /// public IObservable Update(string owner, string name, int id, string commentUpdate) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -228,7 +215,6 @@ namespace Octokit.Reactive /// The ID of the repository /// The comment id /// The modified comment - /// public IObservable Update(int repositoryId, int id, string commentUpdate) { Ensure.ArgumentNotNull(commentUpdate, "commentUpdate"); @@ -243,7 +229,6 @@ namespace Octokit.Reactive /// The owner of the repository /// The name of the repository /// The comment id - /// public IObservable Delete(string owner, string name, int id) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -258,7 +243,6 @@ namespace Octokit.Reactive /// http://developer.github.com/v3/issues/comments/#delete-a-comment /// The ID of the repository /// The comment id - /// public IObservable Delete(int repositoryId, int id) { return _client.Delete(repositoryId, id).ToObservable(); diff --git a/Octokit/Clients/IIssueCommentsClient.cs b/Octokit/Clients/IIssueCommentsClient.cs index c72d6569..b4e1c48e 100644 --- a/Octokit/Clients/IIssueCommentsClient.cs +++ b/Octokit/Clients/IIssueCommentsClient.cs @@ -19,7 +19,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The issue comment id - /// [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] Task Get(string owner, string name, int id); @@ -30,7 +29,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#get-a-single-comment /// The ID of the repository /// The issue comment id - /// [SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get", Justification = "Method makes a network request")] Task Get(int repositoryId, int id); @@ -41,7 +39,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The owner of the repository /// The name of the repository - /// Task> GetAllForRepository(string owner, string name); /// @@ -49,7 +46,6 @@ namespace Octokit /// /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository - /// Task> GetAllForRepository(int repositoryId); /// @@ -59,7 +55,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// Options for changing the API response - /// Task> GetAllForRepository(string owner, string name, ApiOptions options); /// @@ -68,7 +63,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository /// Options for changing the API response - /// Task> GetAllForRepository(int repositoryId, ApiOptions options); /// @@ -78,7 +72,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The issue number - /// Task> GetAllForIssue(string owner, string name, int number); /// @@ -87,7 +80,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue /// The ID of the repository /// The issue number - /// Task> GetAllForIssue(int repositoryId, int number); /// @@ -98,7 +90,6 @@ namespace Octokit /// The name of the repository /// The issue number /// Options for changing the API response - /// Task> GetAllForIssue(string owner, string name, int number, ApiOptions options); /// @@ -108,7 +99,6 @@ namespace Octokit /// The ID of the repository /// The issue number /// Options for changing the API response - /// Task> GetAllForIssue(int repositoryId, int number, ApiOptions options); /// @@ -119,7 +109,6 @@ namespace Octokit /// The name of the repository /// The number of the issue /// The new comment to add to the issue - /// Task Create(string owner, string name, int number, string newComment); /// @@ -129,7 +118,6 @@ namespace Octokit /// The ID of the repository /// The number of the issue /// The new comment to add to the issue - /// Task Create(int repositoryId, int number, string newComment); /// @@ -140,7 +128,6 @@ namespace Octokit /// The name of the repository /// The comment id /// The modified comment - /// Task Update(string owner, string name, int id, string commentUpdate); /// @@ -150,7 +137,6 @@ namespace Octokit /// The ID of the repository /// The comment id /// The modified comment - /// Task Update(int repositoryId, int id, string commentUpdate); /// @@ -160,7 +146,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The comment id - /// Task Delete(string owner, string name, int id); /// @@ -169,7 +154,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#delete-a-comment /// The ID of the repository /// The comment id - /// Task Delete(int repositoryId, int id); } } diff --git a/Octokit/Clients/IssueCommentsClient.cs b/Octokit/Clients/IssueCommentsClient.cs index 3f0d2235..87e9dd7c 100644 --- a/Octokit/Clients/IssueCommentsClient.cs +++ b/Octokit/Clients/IssueCommentsClient.cs @@ -26,7 +26,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The issue comment id - /// public Task Get(string owner, string name, int id) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -41,7 +40,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#get-a-single-comment /// The ID of the repository /// The issue comment id - /// public Task Get(int repositoryId, int id) { return ApiConnection.Get(ApiUrls.IssueComment(repositoryId, id)); @@ -53,7 +51,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The owner of the repository /// The name of the repository - /// public Task> GetAllForRepository(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -67,7 +64,6 @@ namespace Octokit /// /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository - /// public Task> GetAllForRepository(int repositoryId) { return GetAllForRepository(repositoryId, ApiOptions.None); @@ -80,7 +76,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// Options for changing the API response - /// public Task> GetAllForRepository(string owner, string name, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -96,7 +91,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-in-a-repository /// The ID of the repository /// Options for changing the API response - /// public Task> GetAllForRepository(int repositoryId, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); @@ -111,7 +105,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The issue number - /// public Task> GetAllForIssue(string owner, string name, int number) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -126,7 +119,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#list-comments-on-an-issue /// The ID of the repository /// The issue number - /// public Task> GetAllForIssue(int repositoryId, int number) { return GetAllForIssue(repositoryId, number, ApiOptions.None); @@ -140,7 +132,6 @@ namespace Octokit /// The name of the repository /// The issue number /// Options for changing the API response - /// public Task> GetAllForIssue(string owner, string name, int number, ApiOptions options) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -157,7 +148,6 @@ namespace Octokit /// The ID of the repository /// The issue number /// Options for changing the API response - /// public Task> GetAllForIssue(int repositoryId, int number, ApiOptions options) { Ensure.ArgumentNotNull(options, "options"); @@ -173,7 +163,6 @@ namespace Octokit /// The name of the repository /// The number of the issue /// The new comment to add to the issue - /// public Task Create(string owner, string name, int number, string newComment) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -190,7 +179,6 @@ namespace Octokit /// The ID of the repository /// The number of the issue /// The new comment to add to the issue - /// public Task Create(int repositoryId, int number, string newComment) { Ensure.ArgumentNotNull(newComment, "newComment"); @@ -206,7 +194,6 @@ namespace Octokit /// The name of the repository /// The comment id /// The modified comment - /// public Task Update(string owner, string name, int id, string commentUpdate) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -223,7 +210,6 @@ namespace Octokit /// The ID of the repository /// The comment id /// The modified comment - /// public Task Update(int repositoryId, int id, string commentUpdate) { Ensure.ArgumentNotNull(commentUpdate, "commentUpdate"); @@ -238,7 +224,6 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// The comment id - /// public Task Delete(string owner, string name, int id) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); @@ -253,7 +238,6 @@ namespace Octokit /// http://developer.github.com/v3/issues/comments/#delete-a-comment /// The ID of the repository /// The comment id - /// public Task Delete(int repositoryId, int id) { return ApiConnection.Delete(ApiUrls.IssueComment(repositoryId, id));