From d27d1f0a22f5f3f33af882cc7c2f2ad7c717d34e Mon Sep 17 00:00:00 2001 From: Michael Lehto Date: Fri, 23 Feb 2024 01:38:23 +0100 Subject: [PATCH] Change "IssueId" to `long` (#2890) * Change "IssueId" to `long` * Change "Id" to `long` in ctor * Change from `int` to `long` for issue id in "NewPullRequest" --- Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs | 2 +- .../Reactive/ObservableProjectCardsClientTests.cs | 2 +- Octokit/Models/Request/NewPullRequest.cs | 4 ++-- Octokit/Models/Response/Issue.cs | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs index 8607eb06..e9d5b238 100644 --- a/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs @@ -453,7 +453,7 @@ public class ProjectCardsClientTests return result; } - private static async Task CreateIssueCardHelper(IGitHubClient githubClient, int issueId, int columnId) + private static async Task CreateIssueCardHelper(IGitHubClient githubClient, long issueId, int columnId) { var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); diff --git a/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs b/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs index 7eeb5195..05369d95 100644 --- a/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs +++ b/Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs @@ -441,7 +441,7 @@ public class ObservableProjectCardsClientTests return result; } - private static async Task CreateIssueCardHelper(IObservableGitHubClient githubClient, int issueId, int columnId) + private static async Task CreateIssueCardHelper(IObservableGitHubClient githubClient, long issueId, int columnId) { var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue); var result = await githubClient.Repository.Project.Card.Create(columnId, newCard); diff --git a/Octokit/Models/Request/NewPullRequest.cs b/Octokit/Models/Request/NewPullRequest.cs index cdd5f7ec..b2b1ae78 100644 --- a/Octokit/Models/Request/NewPullRequest.cs +++ b/Octokit/Models/Request/NewPullRequest.cs @@ -32,7 +32,7 @@ namespace Octokit /// The number of an existing issue to convert into a pull request. /// The branch (or git ref where your changes are implemented. In other words, the source branch/ref /// The base (or git ref) reference you want your changes pulled into. In other words, the target branch/ref - public NewPullRequest(int issueId, string head, string baseRef) + public NewPullRequest(long issueId, string head, string baseRef) { Ensure.ArgumentNotNullOrEmptyString(head, nameof(head)); Ensure.ArgumentNotNullOrEmptyString(baseRef, nameof(baseRef)); @@ -50,7 +50,7 @@ namespace Octokit /// /// The number of an existing issue to convert into a pull request (required if not provided). /// - public int? IssueId { get; private set; } + public long? IssueId { get; private set; } /// /// The branch (or git ref) you want your changes pulled into (required). diff --git a/Octokit/Models/Response/Issue.cs b/Octokit/Models/Response/Issue.cs index b18e99c9..b2fc9930 100644 --- a/Octokit/Models/Response/Issue.cs +++ b/Octokit/Models/Response/Issue.cs @@ -12,7 +12,7 @@ namespace Octokit { public Issue() { } - public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList