zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-20 14:15:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added verb to Sha1 method

Browse Source
This commit is contained in:
Roger Tinsley
2016-03-16 23:30:41 +00:00
parent faa19af748
commit d9fd0b7e2c
6 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Octokit.Reactive/Clients/IObservableRepositoryCommitsClients.cs
View File

@@ -51,6 +51,6 @@ namespace Octokit.Reactive
/// <param name="name">The name of the repository</param> /// <param name="name">The name of the repository</param>
/// <param name="reference">The repository reference</param> /// <param name="reference">The repository reference</param>
/// <returns></returns> /// <returns></returns>
IObservable<string> Sha1(string owner, string name, string reference); IObservable<string> GetSha1(string owner, string name, string reference);
} }
} }

4
Octokit.Reactive/Clients/ObservableRepositoryCommitsClients.cs
View File

@@ -81,13 +81,13 @@ namespace Octokit.Reactive
/// <param name="name">The name of the repository</param> /// <param name="name">The name of the repository</param>
/// <param name="reference">The repository reference</param> /// <param name="reference">The repository reference</param>
/// <returns></returns> /// <returns></returns>
public IObservable<string> Sha1(string owner, string name, string reference) public IObservable<string> GetSha1(string owner, string name, string reference)
{ {
Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNullOrEmptyString(name, "name");
Ensure.ArgumentNotNullOrEmptyString(reference, "reference"); Ensure.ArgumentNotNullOrEmptyString(reference, "reference");
return _commit.Sha1(owner, name, reference).ToObservable(); return _commit.GetSha1(owner, name, reference).ToObservable();
} }
} }
} }

2
Octokit.Tests.Integration/Clients/RepositoryCommitsClientTests.cs
View File

@@ -91,7 +91,7 @@ public class RepositoryCommitsClientTests
[IntegrationTest] [IntegrationTest]
public async Task CanGetSha1() public async Task CanGetSha1()
{ {
var sha1 = await _fixture.Sha1("octokit", "octokit.net", "master"); var sha1 = await _fixture.GetSha1("octokit", "octokit.net", "master");
Assert.NotNull(sha1); Assert.NotNull(sha1);
} }

14
Octokit.Tests/Clients/RepositoriesClientTests.cs
View File

@@ -798,14 +798,14 @@ namespace Octokit.Tests.Clients
{ {
var client = new RepositoryCommitsClient(Substitute.For<IApiConnection>()); var client = new RepositoryCommitsClient(Substitute.For<IApiConnection>());
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Sha1(null, "name", "reference")); await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetSha1(null, "name", "reference"));
await Assert.ThrowsAsync<ArgumentException>(() => client.Sha1("", "name", "reference")); await Assert.ThrowsAsync<ArgumentException>(() => client.GetSha1("", "name", "reference"));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Sha1("owner", null, "reference")); await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetSha1("owner", null, "reference"));
await Assert.ThrowsAsync<ArgumentException>(() => client.Sha1("owner", "", "reference")); await Assert.ThrowsAsync<ArgumentException>(() => client.GetSha1("owner", "", "reference"));
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Sha1("owner", "name", null)); await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetSha1("owner", "name", null));
await Assert.ThrowsAsync<ArgumentException>(() => client.Sha1("owner", "name", "")); await Assert.ThrowsAsync<ArgumentException>(() => client.GetSha1("owner", "name", ""));
} }
[Fact] [Fact]
@@ -814,7 +814,7 @@ namespace Octokit.Tests.Clients
var connection = Substitute.For<IApiConnection>(); var connection = Substitute.For<IApiConnection>();
var client = new RepositoryCommitsClient(connection); var client = new RepositoryCommitsClient(connection);
client.Sha1("owner", "name", "reference"); client.GetSha1("owner", "name", "reference");
connection.Received() connection.Received()
.Get<string>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null, AcceptHeaders.CommitReferenceSha1Preview); .Get<string>(Arg.Is<Uri>(u => u.ToString() == "repos/owner/name/commits/reference"), null, AcceptHeaders.CommitReferenceSha1Preview);

2
Octokit/Clients/IRepositoryCommitsClient.cs
View File

@@ -58,6 +58,6 @@ namespace Octokit
/// <param name="name">The name of the repository</param> /// <param name="name">The name of the repository</param>
/// <param name="reference">The repository reference</param> /// <param name="reference">The repository reference</param>
/// <returns></returns> /// <returns></returns>
Task<string> Sha1(string owner, string name, string reference); Task<string> GetSha1(string owner, string name, string reference);
} }
} }

2
Octokit/Clients/RepositoryCommitsClient.cs
View File

@@ -87,7 +87,7 @@ namespace Octokit
/// <param name="name">The name of the repository</param> /// <param name="name">The name of the repository</param>
/// <param name="reference">The repository reference</param> /// <param name="reference">The repository reference</param>
/// <returns></returns> /// <returns></returns>
public Task<string> Sha1(string owner, string name, string reference) public Task<string> GetSha1(string owner, string name, string reference)
{ {
Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(owner, "owner");
Ensure.ArgumentNotNullOrEmptyString(name, "name"); Ensure.ArgumentNotNullOrEmptyString(name, "name");