From da6ad0371a3e250634a980aa72a2b0804c4605b1 Mon Sep 17 00:00:00 2001 From: "aedampir@gmail.com" Date: Wed, 15 Jun 2016 16:32:03 +0700 Subject: [PATCH] refactored unit tests --- .../CommitCommentReactionsClientTests.cs | 40 +++++++++---------- ...rvableCommitCommentReactionsClientTests.cs | 40 +++++++++---------- 2 files changed, 40 insertions(+), 40 deletions(-) diff --git a/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs b/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs index 4d5429ea..72bf0b66 100644 --- a/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs +++ b/Octokit.Tests/Clients/CommitCommentReactionsClientTests.cs @@ -22,9 +22,9 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrl() { var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - client.CommitComment.GetAll("fake", "repo", 42); + client.GetAll("fake", "repo", 42); connection.Received().GetAll(Arg.Is(u => u.ToString() == "repos/fake/repo/comments/42/reactions"), "application/vnd.github.squirrel-girl-preview"); } @@ -33,9 +33,9 @@ namespace Octokit.Tests.Clients public async Task RequestsCorrectUrlWithRepositoryId() { var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - client.CommitComment.GetAll(1, 42); + client.GetAll(1, 42); connection.Received().GetAll(Arg.Is(u => u.ToString() == "repositories/1/comments/42/reactions"), "application/vnd.github.squirrel-girl-preview"); } @@ -44,13 +44,13 @@ namespace Octokit.Tests.Clients public async Task EnsuresNotNullArguments() { var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - await Assert.ThrowsAsync(() => client.CommitComment.GetAll(null, "name", 1)); - await Assert.ThrowsAsync(() => client.CommitComment.GetAll("owner", null, 1)); + await Assert.ThrowsAsync(() => client.GetAll(null, "name", 1)); + await Assert.ThrowsAsync(() => client.GetAll("owner", null, 1)); - await Assert.ThrowsAsync(() => client.CommitComment.GetAll("", "name", 1)); - await Assert.ThrowsAsync(() => client.CommitComment.GetAll("owner", "", 1)); + await Assert.ThrowsAsync(() => client.GetAll("", "name", 1)); + await Assert.ThrowsAsync(() => client.GetAll("owner", "", 1)); } } @@ -62,9 +62,9 @@ namespace Octokit.Tests.Clients NewReaction newReaction = new NewReaction(ReactionType.Heart); var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - client.CommitComment.Create("fake", "repo", 1, newReaction); + client.Create("fake", "repo", 1, newReaction); connection.Received().Post(Arg.Is(u => u.ToString() == "repos/fake/repo/comments/1/reactions"), Arg.Any(), "application/vnd.github.squirrel-girl-preview"); } @@ -75,9 +75,9 @@ namespace Octokit.Tests.Clients NewReaction newReaction = new NewReaction(ReactionType.Heart); var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - client.CommitComment.Create(1, 1, newReaction); + client.Create(1, 1, newReaction); connection.Received().Post(Arg.Is(u => u.ToString() == "repositories/1/comments/1/reactions"), Arg.Any(), "application/vnd.github.squirrel-girl-preview"); } @@ -86,16 +86,16 @@ namespace Octokit.Tests.Clients public async Task EnsuresNotNullArguments() { var connection = Substitute.For(); - var client = new ReactionsClient(connection); + var client = new CommitCommentReactionsClient(connection); - await Assert.ThrowsAsync(() => client.CommitComment.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", "name", 1, null)); + await Assert.ThrowsAsync(() => client.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Create("owner", "name", 1, null)); - await Assert.ThrowsAsync(() => client.CommitComment.Create(1, 1, null)); + await Assert.ThrowsAsync(() => client.Create(1, 1, null)); - await Assert.ThrowsAsync(() => client.CommitComment.Create("", "name", 1, new NewReaction(ReactionType.Heart))); - await Assert.ThrowsAsync(() => client.CommitComment.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Create("", "name", 1, new NewReaction(ReactionType.Heart))); + await Assert.ThrowsAsync(() => client.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); } } } diff --git a/Octokit.Tests/Reactive/ObservableCommitCommentReactionsClientTests.cs b/Octokit.Tests/Reactive/ObservableCommitCommentReactionsClientTests.cs index 67aa23d7..021e9f24 100644 --- a/Octokit.Tests/Reactive/ObservableCommitCommentReactionsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservableCommitCommentReactionsClientTests.cs @@ -22,9 +22,9 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var gitHubClient = Substitute.For(); - var client = new ObservableReactionsClient(gitHubClient); + var client = new ObservableCommitCommentReactionsClient(gitHubClient); - client.CommitComment.GetAll("fake", "repo", 42); + client.GetAll("fake", "repo", 42); gitHubClient.Received().Reaction.CommitComment.GetAll("fake", "repo", 42); } @@ -33,9 +33,9 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrlWithRepositoryId() { var gitHubClient = Substitute.For(); - var client = new ObservableReactionsClient(gitHubClient); + var client = new ObservableCommitCommentReactionsClient(gitHubClient); - client.CommitComment.GetAll(1, 42); + client.GetAll(1, 42); gitHubClient.Received().Reaction.CommitComment.GetAll(1, 42); } @@ -44,13 +44,13 @@ namespace Octokit.Tests.Reactive public void EnsuresNotNullArguments() { var gitHubClient = Substitute.For(); - var client = new ObservableReactionsClient(gitHubClient); + var client = new ObservableCommitCommentReactionsClient(gitHubClient); - Assert.Throws(() => client.CommitComment.GetAll(null, "name", 1)); - Assert.Throws(() => client.CommitComment.GetAll("owner", null, 1)); + Assert.Throws(() => client.GetAll(null, "name", 1)); + Assert.Throws(() => client.GetAll("owner", null, 1)); - Assert.Throws(() => client.CommitComment.GetAll("", "name", 1)); - Assert.Throws(() => client.CommitComment.GetAll("owner", "", 1)); + Assert.Throws(() => client.GetAll("", "name", 1)); + Assert.Throws(() => client.GetAll("owner", "", 1)); } } @@ -60,10 +60,10 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrl() { var githubClient = Substitute.For(); - var client = new ObservableReactionsClient(githubClient); + var client = new ObservableCommitCommentReactionsClient(githubClient); var newReaction = new NewReaction(ReactionType.Confused); - client.CommitComment.Create("fake", "repo", 1, newReaction); + client.Create("fake", "repo", 1, newReaction); githubClient.Received().Reaction.CommitComment.Create("fake", "repo", 1, newReaction); } @@ -72,10 +72,10 @@ namespace Octokit.Tests.Reactive public void RequestsCorrectUrlWithRepositoryId() { var githubClient = Substitute.For(); - var client = new ObservableReactionsClient(githubClient); + var client = new ObservableCommitCommentReactionsClient(githubClient); var newReaction = new NewReaction(ReactionType.Confused); - client.CommitComment.Create(1, 1, newReaction); + client.Create(1, 1, newReaction); githubClient.Received().Reaction.CommitComment.Create(1, 1, newReaction); } @@ -84,16 +84,16 @@ namespace Octokit.Tests.Reactive public void EnsuresNotNullArguments() { var gitHubClient = Substitute.For(); - var client = new ObservableReactionsClient(gitHubClient); + var client = new ObservableCommitCommentReactionsClient(gitHubClient); - Assert.Throws(() => client.CommitComment.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); - Assert.Throws(() => client.CommitComment.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); - Assert.Throws(() => client.CommitComment.Create("owner", "name", 1, null)); + Assert.Throws(() => client.Create(null, "name", 1, new NewReaction(ReactionType.Heart))); + Assert.Throws(() => client.Create("owner", null, 1, new NewReaction(ReactionType.Heart))); + Assert.Throws(() => client.Create("owner", "name", 1, null)); - Assert.Throws(() => client.CommitComment.Create(1, 1, null)); + Assert.Throws(() => client.Create(1, 1, null)); - Assert.Throws(() => client.CommitComment.Create("", "name", 1, new NewReaction(ReactionType.Heart))); - Assert.Throws(() => client.CommitComment.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); + Assert.Throws(() => client.Create("", "name", 1, new NewReaction(ReactionType.Heart))); + Assert.Throws(() => client.Create("owner", "", 1, new NewReaction(ReactionType.Heart))); } } }