zoriya/octokit.net
1
0
Fork 0
mirror of https://github.com/zoriya/octokit.net.git synced 2025-12-20 14:15:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support requests with HttpContent body

Browse Source 
If a 3rd party client needs to provide a specific HttpContent, we should
allow that in the adapter. Our clients probably shouldn't do this as it
would break encapsulation.
This commit is contained in:
Haacked
2013-10-11 14:34:09 -07:00
parent db0dc1c00b
commit db2f805bc8
3 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Octokit.Tests/Exceptions/ApiValidationExceptionTests.cs
View File

@@ -3,7 +3,6 @@ using System.IO;
using System.Linq;
using System.Runtime.Serialization.Formatters.Binary;
using NSubstitute;
using Octokit.Internal;
using Xunit;
using Xunit.Extensions;

18
Octokit.Tests/Http/HttpClientAdapterTests.cs
View File

@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Net;
using System.Net.Http;
@@ -57,6 +58,23 @@ namespace Octokit.Tests.Http
Assert.Equal("text/plain", requestMessage.Content.Headers.ContentType.MediaType);
}
[Fact]
public void SetsHttpContentBody()
{
var request = new Request
{
Method = HttpMethod.Post,
Body = new FormUrlEncodedContent(new Dictionary<string, string> {{"foo", "bar"}})
};
var tester = new HttpClientAdapterTester();
var requestMessage = tester.BuildRequestMessageTester(request);
Assert.NotNull(requestMessage.Content);
Assert.IsType<FormUrlEncodedContent>(requestMessage.Content);
Assert.Equal("application/x-www-form-urlencoded", requestMessage.Content.Headers.ContentType.MediaType);
}
[Fact]
public void EnsuresArguments()
{

9
Octokit/Http/HttpClientAdapter.cs
View File

@@ -1,4 +1,5 @@
using System;
using System.IO;
using System.Linq;
using System.Net.Http;
using System.Text;
@@ -68,13 +69,19 @@ namespace Octokit.Internal
{
requestMessage.Headers.Add(header.Key, header.Value);
}
var httpContent = request.Body as HttpContent;
if (httpContent != null)
{
requestMessage.Content = httpContent;
}
var body = request.Body as string;
if (body != null)
{
requestMessage.Content = new StringContent(body, Encoding.UTF8, request.ContentType);
}
var bodyStream = request.Body as System.IO.Stream;
var bodyStream = request.Body as Stream;
if (bodyStream != null)
{
requestMessage.Content = new StreamContent(bodyStream);