mirror of
https://github.com/zoriya/octokit.net.git
synced 2026-06-07 04:16:51 +00:00
added new unit tests
This commit is contained in:
aedampir@gmail.com
@@ -1,6 +1,5 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Reactive.Threading.Tasks;
|
||||
using System.Threading.Tasks;
|
||||
using NSubstitute;
|
||||
using Octokit.Reactive;
|
||||
@@ -13,7 +12,7 @@ namespace Octokit.Tests.Reactive
|
||||
public class TheGetMethod
|
||||
{
|
||||
[Fact]
|
||||
public void GetsFromClientIssueComment()
|
||||
public void RequestsCorrectUrl()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
@@ -23,15 +22,27 @@ namespace Octokit.Tests.Reactive
|
||||
gitHubClient.Issue.Comment.Received().Get("fake", "repo", 42);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RequestsCorrectUrlWithRepositoryId()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.Get(1, 42);
|
||||
|
||||
gitHubClient.Issue.Comment.Received().Get(1, 42);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresNonNullArguments()
|
||||
{
|
||||
var client = new ObservableIssueCommentsClient(Substitute.For<IGitHubClient>());
|
||||
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Get(null, "name", 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Get("", "name", 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Get("owner", null, 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Get("owner", "", 1).ToTask());
|
||||
Assert.Throws<ArgumentNullException>(() => client.Get(null, "name", 1));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Get("owner", null, 1));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.Get("", "name", 1));
|
||||
Assert.Throws<ArgumentException>(() => client.Get("owner", "", 1));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -51,18 +62,31 @@ namespace Octokit.Tests.Reactive
|
||||
"application/vnd.github.squirrel-girl-preview");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RequestsCorrectUrlWithRepositoryId()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.GetAllForRepository(1);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
new Uri("repositories/1/issues/comments", UriKind.Relative), Args.EmptyDictionary, null);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RequestsCorrectUrlWithApiOptions()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
var options=new ApiOptions
|
||||
var options = new ApiOptions
|
||||
{
|
||||
StartPage = 1,
|
||||
PageSize = 1,
|
||||
PageCount = 1
|
||||
};
|
||||
|
||||
client.GetAllForRepository("fake", "repo", options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
@@ -72,18 +96,42 @@ namespace Octokit.Tests.Reactive
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresArgumentsNotNull()
|
||||
public void RequestsCorrectUrlWithRepositoryIdWithApiOptions()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForRepository(null, "name").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForRepository("", "name").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForRepository("owner", null).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForRepository("owner", "").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForRepository("owner", "name", null).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForRepository("", "name", ApiOptions.None).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForRepository("owner", "", ApiOptions.None).ToTask());
|
||||
var options = new ApiOptions
|
||||
{
|
||||
StartPage = 1,
|
||||
PageSize = 1,
|
||||
PageCount = 1
|
||||
};
|
||||
|
||||
client.GetAllForRepository(1, options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
new Uri("repositories/1/issues/comments", UriKind.Relative), Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresNonNullArguments()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository(null, "name"));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository("owner", null));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository(null, "name", ApiOptions.None));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository("owner", null, ApiOptions.None));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository("owner", "name", null));
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForRepository(1, null));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForRepository("", "name"));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForRepository("owner", ""));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForRepository("", "name", ApiOptions.None));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForRepository("owner", "", ApiOptions.None));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -103,39 +151,74 @@ namespace Octokit.Tests.Reactive
|
||||
"application/vnd.github.squirrel-girl-preview");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RequestsCorrectUrlWithRepositoryId()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.GetAllForIssue(1, 3);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
new Uri("repositories/1/issues/3/comments", UriKind.Relative), Args.EmptyDictionary, null);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RequestsCorrectUrlWithApiOptions()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
var options=new ApiOptions
|
||||
var options = new ApiOptions
|
||||
{
|
||||
StartPage = 1,
|
||||
PageSize = 1,
|
||||
PageCount = 1
|
||||
};
|
||||
|
||||
client.GetAllForIssue("fake", "repo", 3, options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
new Uri("repos/fake/repo/issues/3/comments", UriKind.Relative),
|
||||
Arg.Any<Dictionary<string, string>>(),
|
||||
"application/vnd.github.squirrel-girl-preview");
|
||||
new Uri("repos/fake/repo/issues/3/comments", UriKind.Relative), Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresArgumentsNotNull()
|
||||
public void RequestsCorrectUrlWithRepositoryIdWithApiOptions()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForIssue(null, "name", 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForIssue("", "name", 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForIssue("owner", null, 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForIssue("owner", "", 1).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.GetAllForIssue("owner", "name", 1, null).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForIssue("", "name", 1, ApiOptions.None).ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.GetAllForIssue("owner", "", 1, ApiOptions.None).ToTask());
|
||||
var options = new ApiOptions
|
||||
{
|
||||
StartPage = 1,
|
||||
PageSize = 1,
|
||||
PageCount = 1
|
||||
};
|
||||
|
||||
client.GetAllForIssue(1, 3, options);
|
||||
|
||||
gitHubClient.Connection.Received(1).Get<List<IssueComment>>(
|
||||
new Uri("repositories/1/issues/3/comments", UriKind.Relative), Arg.Is<IDictionary<string, string>>(d => d.Count == 2), null);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresNonNullArguments()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue(null, "name", 1));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue("owner", null, 1));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue(null, "name", 1, ApiOptions.None));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue("owner", null, 1, ApiOptions.None));
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue("owner", "name", 1, null));
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.GetAllForIssue(1, 1, null));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForIssue("", "name", 1));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForIssue("owner", "", 1));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForIssue("", "name", 1, ApiOptions.None));
|
||||
Assert.Throws<ArgumentException>(() => client.GetAllForIssue("owner", "", 1, ApiOptions.None));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -154,16 +237,31 @@ namespace Octokit.Tests.Reactive
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresArgumentsNotNull()
|
||||
public void PostsToCorrectUrlWithRepositoryId()
|
||||
{
|
||||
const string newComment = "some title";
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.Create(1, 1, newComment);
|
||||
|
||||
gitHubClient.Issue.Comment.Received().Create(1, 1, newComment);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresNonNullArguments()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", 1, "title").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", 1, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, 1, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", 1, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", "name", 1, null).ToTask());
|
||||
Assert.Throws<ArgumentNullException>(() => client.Create(null, "name", 1, "x"));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Create("owner", null, 1, "x"));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Create("owner", "name", 1, null));
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.Create(1, 1, null));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.Create("", "name", 1, "x"));
|
||||
Assert.Throws<ArgumentException>(() => client.Create("owner", "", 1, "x"));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -182,16 +280,69 @@ namespace Octokit.Tests.Reactive
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresArgumentsNotNull()
|
||||
public void PostsToCorrectUrlWithRepositoryId()
|
||||
{
|
||||
const string issueCommentUpdate = "Worthwhile update";
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.Update(1, 42, issueCommentUpdate);
|
||||
|
||||
gitHubClient.Issue.Comment.Received().Update(1, 42, issueCommentUpdate);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresNonNullArguments()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Update(null, "name", 42, "title").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Update("", "name", 42, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Update("owner", null, 42, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentException>(() => client.Update("owner", "", 42, "x").ToTask());
|
||||
await Assert.ThrowsAsync<ArgumentNullException>(() => client.Update("owner", "name", 42, null).ToTask());
|
||||
Assert.Throws<ArgumentNullException>(() => client.Update(null, "name", 42, "title"));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Update("owner", null, 42, "x"));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Update("owner", "name", 42, null));
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.Update(1, 42, null));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.Update("", "name", 42, "x"));
|
||||
Assert.Throws<ArgumentException>(() => client.Update("owner", "", 42, "x"));
|
||||
}
|
||||
}
|
||||
|
||||
public class TheDeleteMethod
|
||||
{
|
||||
[Fact]
|
||||
public void DeletesCorrectUrl()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.Delete("fake", "repo", 42);
|
||||
|
||||
gitHubClient.Issue.Comment.Received().Delete("fake", "repo", 42);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void DeletesCorrectUrlWithRepositoryId()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
client.Delete(1, 42);
|
||||
|
||||
gitHubClient.Issue.Comment.Received().Delete(1, 42);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task EnsuresArgumentsNotNullOrEmpty()
|
||||
{
|
||||
var gitHubClient = Substitute.For<IGitHubClient>();
|
||||
var client = new ObservableIssueCommentsClient(gitHubClient);
|
||||
|
||||
Assert.Throws<ArgumentNullException>(() => client.Delete(null, "name", 42));
|
||||
Assert.Throws<ArgumentNullException>(() => client.Delete("owner", null, 42));
|
||||
|
||||
Assert.Throws<ArgumentException>(() => client.Delete("", "name", 42));
|
||||
Assert.Throws<ArgumentException>(() => client.Delete("owner", "", 42));
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user