From ec2f6ddca2c814d1359ce02d1a951419d6995e0c Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 4 Jan 2015 11:23:07 +0930 Subject: [PATCH] cleanup these dictionary responses to be have consistently --- Octokit.Tests/Clients/RepositoriesClientTests.cs | 2 +- Octokit/Clients/RepositoriesClient.cs | 15 +++++++-------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/Octokit.Tests/Clients/RepositoriesClientTests.cs b/Octokit.Tests/Clients/RepositoriesClientTests.cs index 505ecc2d..2599af3c 100644 --- a/Octokit.Tests/Clients/RepositoriesClientTests.cs +++ b/Octokit.Tests/Clients/RepositoriesClientTests.cs @@ -386,7 +386,7 @@ namespace Octokit.Tests.Clients client.GetAllLanguages("owner", "name"); connection.Received() - .Get>(Arg.Is(u => u.ToString() == "repos/owner/name/languages"), null); + .Get>(Arg.Is(u => u.ToString() == "repos/owner/name/languages"), null); } [Fact] diff --git a/Octokit/Clients/RepositoriesClient.cs b/Octokit/Clients/RepositoriesClient.cs index 346c96b8..f3b2cdae 100644 --- a/Octokit/Clients/RepositoriesClient.cs +++ b/Octokit/Clients/RepositoriesClient.cs @@ -386,18 +386,17 @@ namespace Octokit /// The owner of the repository /// The name of the repository /// All languages used in the repository and the number of bytes of each language. - public Task> GetAllLanguages(string owner, string name) + public async Task> GetAllLanguages(string owner, string name) { Ensure.ArgumentNotNullOrEmptyString(owner, "owner"); Ensure.ArgumentNotNullOrEmptyString(name, "name"); - return ApiConnection - .Get>(ApiUrls.RepositoryLanguages(owner, name)) - .ContinueWith>(t => - new ReadOnlyCollection( - t.Result.Select(kvp => new RepositoryLanguage(kvp.Key, kvp.Value)).ToList() - ), - TaskContinuationOptions.OnlyOnRanToCompletion); + var data = await ApiConnection + .Get>(ApiUrls.RepositoryLanguages(owner, name)) + .ConfigureAwait(false); + + return new ReadOnlyCollection( + data.Select(kvp => new RepositoryLanguage(kvp.Key, kvp.Value)).ToList()); } ///