From c595f265159afe86afcff64897411d839473137e Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 1 Mar 2015 20:04:35 +0930 Subject: [PATCH 1/3] unshipping preview API changes due to excessive paging introduced in some situations --- Octokit.Tests/Http/ConnectionTests.cs | 2 +- Octokit.Tests/Http/JsonHttpPipelineTests.cs | 2 +- Octokit/Http/JsonHttpPipeline.cs | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Octokit.Tests/Http/ConnectionTests.cs b/Octokit.Tests/Http/ConnectionTests.cs index 45e9bfe1..3e352839 100644 --- a/Octokit.Tests/Http/ConnectionTests.cs +++ b/Octokit.Tests/Http/ConnectionTests.cs @@ -439,7 +439,7 @@ namespace Octokit.Tests.Http httpClient.Received().Send(Arg.Is(req => req.BaseAddress == _exampleUri && req.Body == body && - req.Headers["Accept"] == "application/vnd.github.moondragon+json; charset=utf-8,application/vnd.github.v3+json; charset=utf-8" && + req.Headers["Accept"] == "application/vnd.github.v3+json; charset=utf-8" && req.ContentType == "application/arbitrary" && req.Method == HttpMethod.Post && req.Endpoint == new Uri("https://other.host.com/path?query=val")), Args.CancellationToken); diff --git a/Octokit.Tests/Http/JsonHttpPipelineTests.cs b/Octokit.Tests/Http/JsonHttpPipelineTests.cs index 68dbea2f..be4b19ea 100644 --- a/Octokit.Tests/Http/JsonHttpPipelineTests.cs +++ b/Octokit.Tests/Http/JsonHttpPipelineTests.cs @@ -30,7 +30,7 @@ namespace Octokit.Tests.Http jsonPipeline.SerializeRequest(request); Assert.Contains("Accept", request.Headers.Keys); - Assert.Equal("application/vnd.github.moondragon+json; charset=utf-8,application/vnd.github.v3+json; charset=utf-8", request.Headers["Accept"]); + Assert.Equal("application/vnd.github.v3+json; charset=utf-8", request.Headers["Accept"]); } [Fact] diff --git a/Octokit/Http/JsonHttpPipeline.cs b/Octokit/Http/JsonHttpPipeline.cs index d5af3334..a79876d3 100644 --- a/Octokit/Http/JsonHttpPipeline.cs +++ b/Octokit/Http/JsonHttpPipeline.cs @@ -11,7 +11,6 @@ namespace Octokit.Internal /// public class JsonHttpPipeline { - private const string moondragonPreviewApiVersion = "application/vnd.github.moondragon+json; charset=utf-8"; private const string v3ApiVersion = "application/vnd.github.v3+json; charset=utf-8"; readonly IJsonSerializer _serializer; @@ -34,7 +33,7 @@ namespace Octokit.Internal if (!request.Headers.ContainsKey("Accept")) { - request.Headers["Accept"] = String.Join(",", moondragonPreviewApiVersion, v3ApiVersion); + request.Headers["Accept"] = v3ApiVersion; } if (request.Method == HttpMethod.Get || request.Body == null) return; From e51dab8b577231d29dfcbcdbc8baa264c9b1305b Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 1 Mar 2015 20:06:44 +0930 Subject: [PATCH 2/3] release notes --- ReleaseNotes.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ReleaseNotes.md b/ReleaseNotes.md index 9fb9078e..44e057e9 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -1,3 +1,6 @@ +### New in 0.7.2 (released 2015/03/01) +* Fixed: unshipped Orgs Permissions preview API changes due to excessive paging in some situations. + ### New in 0.7.1 (released 2015/02/26) * New: `SearchCodeRequest` has overloads for owner and repository name - #705 via @kfrancis * New - support for preview Authorization API changes - #647 via @shiftkey From 5b703d40d29fa315f9cb25c97232c11a5cf50c21 Mon Sep 17 00:00:00 2001 From: Brendan Forster Date: Sun, 1 Mar 2015 20:08:35 +0930 Subject: [PATCH 3/3] version bump --- SolutionInfo.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/SolutionInfo.cs b/SolutionInfo.cs index 46751c42..3981c473 100644 --- a/SolutionInfo.cs +++ b/SolutionInfo.cs @@ -3,11 +3,11 @@ using System.Reflection; using System.Runtime.InteropServices; [assembly: AssemblyProductAttribute("Octokit")] -[assembly: AssemblyVersionAttribute("0.7.1")] -[assembly: AssemblyFileVersionAttribute("0.7.1")] +[assembly: AssemblyVersionAttribute("0.7.2")] +[assembly: AssemblyFileVersionAttribute("0.7.2")] [assembly: ComVisibleAttribute(false)] namespace System { internal static class AssemblyVersionInformation { - internal const string Version = "0.7.1"; + internal const string Version = "0.7.2"; } }