From 27848326f04aaaa0c49c667ef887583465f55899 Mon Sep 17 00:00:00 2001 From: half-ogre Date: Tue, 8 Oct 2013 16:48:48 -0700 Subject: [PATCH 1/2] make the CA nag happy --- Octokit/Http/ICredentialStore.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/Octokit/Http/ICredentialStore.cs b/Octokit/Http/ICredentialStore.cs index d53bfe67..90b67c07 100644 --- a/Octokit/Http/ICredentialStore.cs +++ b/Octokit/Http/ICredentialStore.cs @@ -5,6 +5,7 @@ namespace Octokit.Internal { public interface ICredentialStore { + [SuppressMessage("Microsoft.Design", "CA1024:UsePropertiesWhereAppropriate", Justification="Nope")] Task GetCredentials(); } } From afd2c5db686e6210b97e81e6252197ec87463ac4 Mon Sep 17 00:00:00 2001 From: half-ogre Date: Tue, 8 Oct 2013 16:49:47 -0700 Subject: [PATCH 2/2] work around Enterprise strangeness GitHub Enterprise uses a sentinel value of 999999999999 to denote "unlimited". --- Octokit/Models/Plan.cs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Octokit/Models/Plan.cs b/Octokit/Models/Plan.cs index 10d2f6bf..a7740656 100644 --- a/Octokit/Models/Plan.cs +++ b/Octokit/Models/Plan.cs @@ -8,7 +8,8 @@ namespace Octokit /// /// The number of collaborators allowed with this plan. /// - public int Collaborators { get; set; } + /// This returns because GitHub Enterprise uses a sentinel value of 999999999999 to denote an "unlimited" number of collaborators. + public long Collaborators { get; set; } /// /// The name of the plan. @@ -18,12 +19,14 @@ namespace Octokit /// /// The number of private repositories allowed with this plan. /// - public int PrivateRepos { get; set; } + /// This returns because GitHub Enterprise uses a sentinel value of 999999999999 to denote an "unlimited" number of plans. + public long PrivateRepos { get; set; } /// /// The amount of disk space allowed with this plan. /// - public int Space { get; set; } + /// This returns because GitHub Enterprise uses a sentinel value of 999999999999 to denote an "unlimited" amount of disk space. + public long Space { get; set; } /// /// The billing email for the organization. Only has a value in response to editing an organization.